4b02e562b3
Eliminate mention of wxString from ErrorDialog.h ...
...
... whether std::wstring is the best alternative type, or whether we should
use UTF8 encoded std::string -- I wish to defer that, and revisit it later
2021-07-01 13:37:40 -04:00
77dab158c3
Make Audacity build in C++17 ...
...
... Fixing many conditional operators with explicit construction of wxString
instead of simple string literals;
And fixing allocation of more strictly aligned structures on Mac, without need
for 10.14 as the minimum SDK, by means of some class-specific operators new
and delete.
2021-06-18 21:44:55 +03:00
950d170ae6
Adds context to SQLite3 exceptions
2021-06-08 08:08:26 -07:00
690772ccb0
Use ShowExceptionDialog when we want to show ErrorReportDialog
2021-06-08 08:08:26 -07:00
df91d14c9e
Bug 2793 - AUP3 projects fail to compact if project's path contains a single-quote
2021-05-20 11:27:21 +01:00
b9ca0acb4a
Move some macros out of Audacity.h into various header files
2021-05-10 00:05:23 -05:00
cf0293396d
Fix project backup
...
I broke this in the development version by changing the return type
of FastMode to return an Sqlite return code.
2021-04-30 09:09:12 +01:00
b73aa1cfc0
Update Wording
...
Include the wording updates that were queued up at:
https://wiki.audacityteam.org/wiki/Wording
2021-04-10 10:14:52 +01:00
d9260df634
Some additional error checking and logging
2021-04-04 14:18:05 -05:00
392a060389
Bug 2700 - "Failed to open the project database"
2021-04-01 01:13:15 -05:00
f1395ff621
Bug 2718 - improve the error message when opening a project in a read-only directory.
2021-03-29 18:40:40 +01:00
125114cfe7
Bug 2700 - "Failed to open the project database"
...
Only information gathering changes...not a fix
2021-03-27 14:26:30 -05:00
6908d37a90
Bug 2720 - Error message improvement.
...
The error message occurs whether or not the blockfiles
are 'orphan blockfiles', so change the wording.
2021-03-27 19:10:26 +00:00
e19d1f2340
Bug 2720 - Residual
...
Handling of failed to open. Now if we fail, we abandon that connection,
rather than plough on.
2021-03-27 17:54:14 +00:00
6435f595cc
Bug 2720 - Cannot open project that's in a read only folder - error message vague.
...
The error message is now no longer vague, but 2720 can't be closed yet.
Audacity continues with a connection to an unusable project still open,
and then crashes later.
2021-03-27 17:19:19 +00:00
ffebbe064e
Bug 2714 - (Japanese & Korean) "Unable to parse project information"
2021-03-25 00:19:11 -05:00
2c47dc5ba1
Bug 2688 - Bad saves with Unicode project filenames
2021-03-08 12:42:09 -06:00
b99a2e464f
Bug 2668 - Residual: Help button on error dialog.
...
Bug 2668 is Audacity fails to report incompatible/future file versions
This change adds a help link on the error dialog to https://alphamanual.audacityteam.org/man/FAQ:Errors_opening_an_Audacity_project
2021-02-19 11:24:45 +00:00
9a0753d214
Change database version format and add comments
2021-02-18 02:05:07 -06:00
449d0932fa
Fix file version checking bug.
...
Opening a 1.2.4 Audacity version would previously
report an error, as being 'more recent' than 1.3.0.
Found by whitebox testing.
2021-02-17 15:30:56 +00:00
ade2cadaa6
A little remnant of the "tags" table expulsion.
2021-02-16 14:57:47 -06:00
56852ae4c1
Remove unused tags table from the database schema
2021-02-13 15:22:40 -05:00
b928e7e9f2
Add dump of active AUP3 XML doc to support data
2021-02-13 01:58:09 -06:00
92e36332f3
Reimplement importation of .aup3 file more simply...
...
... Breaking dependency of ProjectFileIO on on TimeTrack, and reusing the same
functions that implement cross-document copy and paste of tracks.
Also changing behavior, so that if a TimeTrack exists but another is imported,
then the import quietly replaces the existing completely.
2021-02-02 15:22:44 -05:00
f59ba86faf
Wording fixes (minor)
2021-01-26 12:13:54 +00:00
c9d37675f7
First stab at responding to whitebox review
...
In some cases, I've simply left the REVIEW: in and
responded to it. In other cases, I've resolved what
was mentioned in the review.
2021-01-26 02:21:12 -06:00
42a105ee0a
Review DB/Data safety.
...
I've added the comment 'REVIEW:' where I have some concern that
the database and our copy of it could get out of step, or simply that
we fail to report a problem to the user.
I'd like these reviewed and turned into comments that make it
easier to check for correctness, for example saying where an
error is reported, or why it is OK to do no further recovery action.
2021-01-23 19:00:36 +00:00
b5ee77f737
Bug 2632 - Original project isn't compacted when doing Save As
2021-01-20 22:39:19 -06:00
43574553fc
Break dependency cycle introduced at 50f3321...
...
... This only cuts and pastes some functions from FileNames to another new file
and namespace, and changes namespace qualifiers where they are called.
The cycle resulted because of the need to include widgets/ErrorDialog.h
2021-01-16 13:28:37 -05:00
9e53df0c47
Fix handling of Unicode when decoding project blob
...
If a TAG with Unicode characters outside the normal ASCII
range were saved to an AUP3, you would not be able to reopen
it and you'd receive the following error:
Unable to parse project information.
2021-01-14 01:09:21 -06:00
534359de6c
Fix minor typos ( #720 )
...
Co-authored-by: freddii <https://freddii@github.com >
2021-01-12 11:56:09 +00:00
e093ed1846
Bug 2624 - Win: large projects saved to slow USB drive when aborted yield error on reopening
2021-01-12 01:53:19 -06:00
ac55e228ce
Remove experimental attempt at FAT detection
...
We'll just have to address each instance individually.
2021-01-11 12:24:14 -06:00
28a286c656
Experimental commit for testing more FAT exclusion
2021-01-11 08:51:17 -06:00
8fa0b13432
Ensure error dialog is displayed in a couple more instances
2021-01-06 01:12:29 -06:00
56c8bdcd24
Bug 2609 - Save Project when disk is full gives a second disk-full message
2021-01-03 19:22:22 -06:00
b1c8cd6479
Bug2602: correct record capacity estimate for Win+FAT filesystem...
...
... effectively reverting commit 0d5b9753bc
2020-12-08 13:18:26 -05:00
aa0b33dc8f
Detect failure to reconnect to temp project when first saving it
2020-12-06 23:20:44 -05:00
41eb66fccf
Where CurConn() is used, don't assume it is non-null
2020-12-06 21:31:06 -05:00
900bf44219
ProjectFileIO::CloseProject does not assert that project was open
2020-12-06 21:25:34 -05:00
38b169ab7e
Guarantee postcondition of ProjectFileIO::OpenConnection()
2020-12-06 21:18:48 -05:00
c5e454e109
Move IsOnFATFileSystem to FileNames
2020-12-06 12:23:19 -05:00
b6ce29d234
Bug2605: Don't leave orphans in original project after save-as
2020-12-02 13:05:22 -05:00
47bdf27f2d
Revert "Bug2605: Save-as should not cause original to repoen with warnings..."
...
This reverts commit 742134caaa
2020-12-02 12:39:35 -05:00
742134caaa
Bug2605: Save-as should not cause original to repoen with warnings...
...
... Problem was that before abandoning the connection to the original path,
compaction was done only sometimes, according to the criterion of estimated
%20 space savings at least. But this could cause the project to reopen with
orphan blocks in it, which were detected and reported as an improper save.
The easy solution is to force compaction always in this case.
Direct save does not have this problem because what would otherwise be orphaned
blocks are directly deleted from the database when undo states are destroyed
and sample blocks become unreferenced. So compacting only sometimes does not
cause orphan blocks on reopening.
2020-12-02 00:41:07 -05:00
6944ba564c
Use events to break dependency cycle introduced at 3978e8c
2020-11-25 12:24:21 -05:00
6a10177404
Bug2594: Fix Save Backup...
...
... It broke at 16b249a
2020-11-24 16:30:10 -05:00
7e1e339f72
Bug2599: -wal and -shm of discarded temp projects should clean up
2020-11-24 14:38:58 -05:00
0d5b9753bc
Don't open a file just to query its length
2020-11-24 14:22:29 -05:00
5ebfe4670c
Bug2596: Error dialogs opening unreadable project should not be blank
2020-11-24 12:43:00 -05:00
Paul Licameli
Dmitry Vedenko
James Crook
Leland Lucius
freddii