Commit Graph

6394 Commits

Author SHA1 Message Date
James Crook
1deff18c15 Bug 231 - Cut Preview should play all selected/sync-locked tracks, respecting Mute/Solo during preview 2018-09-10 16:57:36 +01:00
Paul Licameli
b881b06b53 When scrubbing backwards unpinned, scroll tracks by whole panel width 2018-09-09 13:53:51 -04:00
Paul Licameli
f31a1a6f8e Don't halt scrub playback with display paging at high magnification 2018-09-09 13:40:10 -04:00
Paul Licameli
52ad43daac Scrubbing at high mag, play head won't stray left of track edge 2018-09-09 13:10:01 -04:00
Paul Licameli
03def8dbaf Bug1967: scrub shouldn't be clicky...
... And this further simplifies the use of the clock.  Rely on the regularity
of spacing between calls to FillBuffers at commit a62cf53
2018-09-09 11:01:01 -04:00
James Crook
e724ef0793 Bug 1970 - Missing tick marks in Timeline 2018-09-09 12:33:10 +01:00
James Crook
ff01d39601 Undo Workaround for Bug 1969
Turned out this was not the correct fix.
2018-09-08 23:17:20 +01:00
James Crook
596feddfe7 Workaround for Bug 1969 - Windows: no monitored sound for 15 secs with software playthrough with default MME host
This is not a proper fix, as we do not fully understand the problem - which is in release builds only.
It may be enough though to get us through to release.
2018-09-08 16:55:34 +01:00
James Crook
0f5c8d4d84 Wording: "Duplex" -> "Overdub" (missing piece). 2018-09-08 14:41:43 +01:00
Steve Daulton
ad19ca0fa2 Fix for bug 1972 2018-09-06 20:32:08 +01:00
James Crook
1ecff6d5db Bug 1971 - Linux: Scriptables screenshot command only grab a small rectangle of window 2018-09-05 19:16:07 +01:00
Paul Licameli
f61989e922 Part fixes for compilation of EXPERIMENTAL_SCOREALIGN 2018-09-05 13:25:41 -04:00
Paul Licameli
544c3b9770 spelling in comments 2018-09-04 23:04:18 -04:00
Paul Licameli
69bf7fd120 remove unused function 2018-09-04 23:04:18 -04:00
James Crook
2758491a4a Bug 1966 - Manage Macros: Import and Export buttons are always inactive. 2018-09-03 22:58:57 +01:00
James Crook
7d0839393b Report selectedness of all tracks, not just WaveTracks.
(Suggested by Steve Daulton).
2018-09-03 22:02:15 +01:00
Paul Licameli
ad6962250b Bug1958: shouldn't crash recording with playthrough 2018-09-03 15:04:24 -04:00
Paul Licameli
a56a5be30b Replace _ with XO (won't affect generated audacity.pot) 2018-09-03 09:10:45 -04:00
Paul Licameli
1baf12d7bc Bug1960: position of play head during scrub right to left 2018-09-01 09:56:26 -04:00
James Crook
3f7c639c3f Make the 'wait for fade out' latency dependent.
This gives time for the fading out to clear the sound card, OR if
we would wait around too long, just close down the stream without waiting.
2018-09-01 10:24:50 +01:00
James Crook
8ed0edd599 Fix two problems with Nyquist translation.
1. The 'Select a File' button (which comes from wxFileSelectorPrompt) was not being translated.
2. rhythmtrack.ny was missing an (_ ) on one string.
2018-08-31 22:51:20 +01:00
Paul Licameli
af276ac4f9 Now implement scrubbing default to unpinned, see commit ac1017e...
... This was motivated by punch and roll recording:  it appears most convenient
to pin the head for recording purposes, and drag it near the right, but when
stopping and finding the splice point for the correction, it is better to
scrub unpinned.
2018-08-31 10:46:08 -04:00
James Crook
792fddbd22 Bug 1962 - Nyquist effect dialog labels not translated 2018-08-31 10:51:10 +01:00
James Crook
094c574e63 Fixes for missing/problematic strings for translation.
Two strings were not marked with _().
2018-08-30 22:05:30 +01:00
James Crook
40ab579442 Bug 1957 - Overdub disabled when enabled in Transport menu 2018-08-30 12:42:51 +01:00
Olivier Humbert
052f5d355d Update HelpText.cpp 2018-08-29 23:07:37 -04:00
Olivier Humbert
ac87eddd60 Update VampEffect.h 2018-08-29 23:07:37 -04:00
Paul Licameli
d050afb658 Scrubbing calculation now needs clock precision greater than sample rate 2018-08-29 15:01:31 -04:00
James Crook
919571e79f Bug 1950 - Pause mutes and stops head progressing, but does not 'pause' audio.
Logic changed to delay pause by one frame, if there is a need to fade out.
So we calculate whether we are already faded out, and if we are pause, otherwise delay the real pause for one frame.
2018-08-29 19:54:11 +01:00
James Crook
41959d4d54 Bug 1952 - Windows: Timer Record - debug failure msg
Now we show "11:07:29 +" for a time 100 years, 11 hours, 7 mins and 29 seconds in the future, rather than ASSERTing.
The + should probably be mentioned in the manual.  "In the countdown, times more than 24 hours ahead aren't shown fully.  A '+' sign after the time indicates that it is more than a day ahead."
2018-08-29 15:14:28 +01:00
James Crook
b5f9acefa4 Fix some warnings in AudioIO.cpp 2018-08-29 14:00:57 +01:00
David Bailes
a5e9fb9e34 Bug 1949: WASAPI playback stops before the end of the selection
Problem: When using WASAPI on Windows, the last "latency buffer length" of a selection is not played. This is a fairly nasty bug for those relying on playback when making fine adjustments to the position of the cursor, or the start or end of selection.

During playback the "latency buffer length" has no effect on the actual latency of the playback, but the playback cursor is positioned as if the "latency buffer length" did have an effect, that is, it is positioned by this amount after the audio being played.

So an obvious workaround is for the user to set the latency buffer length to zero when using WASAPI. However they then have to remember to change it if they use another audio host.

Fix: The real problem is presumably a portaudio bug, but this fix just hard codes the workaround given above. For playback, when using WASAPI, set the suggested latency to 0, regardless of user setting.
2018-08-29 13:47:32 +01:00
James Crook
85c1eb4720 Fix GetInfo: Type=Labels counts channels rather than tracks. 2018-08-29 13:35:21 +01:00
James Crook
481370b7b3 Fix ASSERT opening FFmpeg Options Dialog.
Was caused by passing a non hWnd window to the ExportOptions constructor.
2018-08-29 13:25:18 +01:00
James Crook
0ea4ff1395 Add internationalization hints. 2018-08-28 16:35:06 +01:00
Paul Licameli
85f13b433f Fix Linux build... uniform initialization not implemented right in g++? 2018-08-28 07:36:39 -04:00
Paul Licameli
eae38b0676 Fix Linux build 2018-08-28 06:20:04 -04:00
Paul Licameli
9aad60d12c Make polling loop period slightly shorter than Audio thread loop...
... but we don't need to make it as precise, using steady_clock.

Do this so that the Audio thread doesn't read the same polling message twice,
halting the scrub.  It's all right that it might miss one of the messages
instead.
2018-08-27 17:02:37 -04:00
Paul Licameli
e4e7a814c8 FillBuffers won't quit too early priming the RingBuffer for scrub 2018-08-27 17:02:36 -04:00
Paul Licameli
ba52753ff7 Scrub options don't need starting time 2018-08-27 17:02:36 -04:00
Paul Licameli
9d17d335b7 Poller thread leaves messages, Audio interprets; a buffer not a queue 2018-08-27 16:53:16 -04:00
Paul Licameli
832bcef3a6 Postpone work from ctor of ScrubState to the first call of Update 2018-08-27 16:53:16 -04:00
Paul Licameli
a62cf53161 Make AudioThread wake-ups as uniformly spaced as we can 2018-08-27 16:53:16 -04:00
Paul Licameli
0c0cc07686 Define utility class MessageBuffer for inter-thread messages 2018-08-27 16:48:15 -04:00
Paul Licameli
4e461f8755 Explicit scrub shut-down signal replaces the "nudge" 2018-08-27 16:41:45 -04:00
Paul Licameli
303ac9367a Start scrub polling before the PortAudio stream...
... A part, but only a part, of the fix for "bounce" at start of scrub
2018-08-27 16:41:45 -04:00
Steve Daulton
27ede251d5 Don't collapse recorded tracks when Auto-fit enabled 2018-08-27 14:45:25 +01:00
James Crook
878818a1aa Wording: "Duplex" -> "Overdub" 2018-08-27 14:23:45 +01:00
James Crook
e31fe6b242 Make AUD-DO return T or NIL as result status.
Previously it was returning 1 or NIL
2018-08-27 10:25:53 +01:00
Steve Daulton
70467e1523 Enable (most) Nyquist property lists for tool scripts
The global *TRACK* variable and its properties remain unavailable for
;type tool scripts.
2018-08-26 16:47:00 +01:00