audacia/audacia
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
9,695 Commits 2 Branches 0 Tags 223 MiB
b4ce681867
Commit Graph

29 Commits

Author SHA1 Message Date
Paul Licameli
b4ce681867 WaveTrack.h does not include WaveClip.h 2019-03-18 01:44:42 -04:00
James Crook
20178b15e1 Fix some 'declaration hides' warnings. 
We were for example getting many of these:
\audacity\src\widgets\numerictextctrl.h(171): warning C4458: declaration of 'value' hides class member

MSVC2013 didn't warn about these, but MSVC2017 does.
 2018-06-27 12:36:13 +01:00
Paul Licameli
a9e7a7e5d5 movable_ptr(_with_deleter) -> std::unique_ptr 2018-05-10 00:56:37 -04:00
Paul Licameli
b8a8712ba0 make_movable -> std::make_unique 2018-05-10 00:56:36 -04:00
James Crook
1d9477a455 SetClip, SetLabel, SetProject added 
- SetTrack also updated with more options.
 2018-02-24 14:20:24 -05:00
Paul Licameli
01c5f25a19 Rewrite one try-catch with GuardedCall so we can show the user errors 2017-03-17 17:53:01 -04:00
Paul Licameli
1a3212611b ODComputeSummaryTask is safe for exceptions; makes no progress then 2017-03-17 17:52:55 -04:00
Paul Licameli
4744f5cc5e OD tasks store weak pointers to block files... 
... This means unneeded block files can be reclaimed sooner.

This also eliminates the checks of use_count, which might vary in a
multithreaded context; though that didn't really matter (because once it
was below 2, the function had the only remaining shared_ptr to the block file,
so it could not have increased again to 2).
 2017-03-17 17:52:37 -04:00
Paul Licameli
3c4a15f5cb Remove some unused members 2017-03-17 17:52:30 -04:00
Paul Licameli
78be459fa1 Convert sampleCount <-> floating or -> long long explicitly ... 
... A non-narrowing conversion out to long long is a necessity, but the
conversions to float and double are simply conveniences.

Conversion from floating is explicit, to avoid unintended consequences with
arithmetic operators, when later sampleCount ceases to be an alias for an
integral type.

Some conversions are not made explicit, where I expect to change the type of
the variable later to have mere size_t width.
 2016-09-15 21:02:31 -04:00
Paul Licameli
d783762737 Remove unnecessary std::move in return statements... 
... and comment where it is necessary.
 2016-09-15 07:39:46 -04:00
Paul Licameli
52417c444d Remove unnecessary casts to sampleCount 2016-08-24 14:50:46 -04:00
Paul Licameli
79c79f9cd3 Remove many mentions of sampleCount with auto and decltype... 
... This makes much code agnostic about how other things (functions and
arguments) are typed.

Many of these neeed to become size_t instead of sampleCount.
 2016-08-24 14:50:45 -04:00
Paul Licameli
8b72bd2f92 Manage block files with std::shared_ptr, BlockHash stores weak_ptr 2016-08-16 12:29:59 -04:00
Paul Licameli
2ede67be96 Use type alias for pointer to BlockFile, which is still a dumb pointer 2016-08-16 12:29:59 -04:00
Paul Licameli
84a6456788 Iterate over all clips of a track, including cutlines, where needed 2016-08-13 20:17:55 -04:00
Paul Licameli
b548e641ae Simplify iterations over WaveClips outside of WaveTrack/WaveClip; ... 
... also add some const qualifiers
 2016-08-12 20:53:37 -04:00
Paul Licameli
473e955da3 Remove some naked new amd delete in: ondemand 2016-08-08 07:53:28 -04:00
Paul Licameli
c9d50dc20b ODTask cloners return smart pointers 2016-04-06 16:06:36 -04:00
Paul Licameli
55d85f1b25 Remove more uses of at(); use a std::vector of bare pointers, not wx array 2016-02-16 09:35:03 -05:00
Paul Licameli
7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli
6c28276daf Use RAII idiom for lock and locking mutex in Sequence 2016-02-04 00:53:54 -05:00
Paul Licameli
38ba19183d One less indirection accessing SeqBlock 2016-02-03 22:17:07 -05:00
Paul Licameli
f81231efae Remove Sequence.h from other headers 2015-07-28 10:02:08 -04:00
Paul Licameli
d39eaa4e65 Remove WaveTrack.h from other headers 2015-07-28 10:02:05 -04:00
richardash1981
2a7c7de30d Commit a warnings removal patch from Benjamin Drung to correct a string of minor misdemeanors. 2011-02-07 20:24:04 +00:00
mchinen
0fac236e9a Fix whitespace and comments in ODComputeSummaryTask and ODManager 2010-07-19 13:25:52 +00:00
mchinen
5ccce1ed4b checking in cleanup of on-demand files following james' review. also speeds up od cursor updating when user clicks for on-demand 2010-03-08 01:52:38 +00:00
ra
e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00