Commit Graph

83 Commits

Author SHA1 Message Date
Paul Licameli df6a7c5464 More uses of safenew for classes we derive from wxWindow classes...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli 3f237daddc Use macro safenew for many allocations of wxWindow subclasses 2016-02-14 20:20:19 -05:00
Paul Licameli 6052b5f9be Throw by value, catch by reference: don't use pointers...
... that's what the better books on C++ recommend.
2016-02-14 19:36:17 -05:00
Paul Licameli 7c4c45a0d5 "new"->"NEW" in comments, easier to find remaining naked operator new 2016-02-14 18:52:41 -05:00
Paul Licameli 56e7653343 "delete"->"DELETE" in comments, easier to find remaining naked operator delete 2016-02-14 18:50:45 -05:00
Leland Lucius 76436fc3fd Don't display message if the EQ curves file is missing.
I can't think of a reason for having the message.  Either the curves
are there or they are not.
2015-12-21 23:38:05 -06:00
Leland Lucius 2a234d86f8 "Should" fix the remaining issue in bug #1081 2015-08-27 10:16:28 -05:00
Leland Lucius e15236efdc Fix the assertion mentioned in bug #1081 2015-08-27 09:38:09 -05:00
Paul Licameli 1b8f44d053 ViewInfo does not redundantly (or inconsistently!) store the screen width 2015-08-21 22:39:18 -04:00
Leland Lucius 5a9025b558 Hopefully this'll fix the assertions 2015-08-16 15:04:24 -05:00
Paul Licameli cf45a58fdc dB range is now in Waveforms preferences and view settings, and ...
... the preference is independent of those in Interface and Recording
preferences, which affect meters, sound activated recordings, time track,
and Plot Spectrum
2015-08-15 18:07:29 -04:00
Leland Lucius 7a77109c7b Should fix slider alignment (wx3) issue and fix bugs #1081 and #1088 2015-08-15 12:45:16 -05:00
Leland Lucius 1e195ecea6 Fix many wx3.1.0 assertions now to prevent double testing 2015-07-30 02:05:23 -05:00
Paul Licameli d39eaa4e65 Remove WaveTrack.h from other headers 2015-07-28 10:02:05 -04:00
Steve Daulton df8ddde874 Added dB - linear amplitude conversion macros. 2015-07-24 21:59:34 +01:00
Paul Licameli e0f4595485 TrackArtist, LabelTrack, TimeTrack, Envelope functions take ZoomInfo...
... and SelectedRegion, and not ViewInfo or zoom level as a double.

Also some leftOffset arguments.

Assumptions of uniform zoom level persist in TrackArtist::DrawClipSpectrum and
in TrackArtist::DrawClipWaveform but no longer in the rest.
2015-07-19 11:44:13 -04:00
Paul-Licameli bd08c7c778 Envelope event handlers do not directly use zoom (pps) values 2015-07-19 11:44:08 -04:00
Leland Lucius 0ef7ccb1d1 Fix permissions...not sure why this was happening though 2015-05-29 19:49:28 -05:00
Leland Lucius c816d2562d Fix for bug #985
Was not able to reproduce the assert mentioned in the report though.
2015-05-29 11:32:55 -05:00
Leland Lucius d0d8f37d85 Correct dialog background color on GTK 2015-05-19 09:51:06 -05:00
Steve Daulton d9f3c432d4 Fix for bugs 943, 942, 941, 843 and 775.
Non-linear effects now process tracks before mixing.
This will be slower when multiple tracks are selected
but the preview should now match the applied effect.
SetLinearEffectFlag(true) allows linear effects to
preview more quickly when multiple tracks selected, by
pre-mixing selected tracks.
Simple generators like Tone and Noise may be marked as
'linear' so that they only preview a few seconds.
Generators that vary over time (such as Chirp) must use
the full duration that is set. As this currently
requires calculating the full duration, preview for
'non-linear' generators are not limited to the preview
length.
2015-05-15 12:51:51 +01:00
James Crook ccc71c31b6 Some effect descriptions (for Doxygen). 2015-05-09 17:36:54 +01:00
Leland Lucius 4d0de66523 Fix for bug #387
As this is a reversal of change committed in 2007 with no real
explanation or history behind that change other than it was
done for Export, we should probably give exporting a bit of a
workout.
2015-05-03 23:36:30 -05:00
Daniel Winzen 038989e41d Fix uninitialized variable in Equalizer effect
Delete mCustomBackup, as it is never used
2015-04-30 11:49:21 +02:00
Leland Lucius 27657ddea7 Restore non-preset values when Factory Preset -> Defaults is selected 2015-04-27 10:52:42 -05:00
Daniel Winzen 92d522132e Variable cleanup 2015-04-23 18:30:38 +02:00
Leland Lucius 76864cb2d3 Fix EQ effect based on Peter's feedback 2015-04-22 13:02:55 -05:00
Leland Lucius 7a0aa43a82 Convert all wxTRANSLATE() to XO()
XO() can be used anywhere a string must be extracted for translation
but not automatically translated at runtime.
2015-04-18 23:03:49 -05:00
Leland Lucius 8fbfa460c4 Migrating the remaining effects
This brings the builtin, LV2, and VAMP effects inline with the
Audio Units, LADSPA, and VST effects.  All effects now share
a common UI.

This gives all effects (though not implemented for all):

User and factory preset capability
Preset import/export capability
Shared or private configuration options

Builtin effects can now be migrated to RTP, depending on algorithm.
LV2 effects now support graphical interfaces if the plugin supplies one.
Nyquist prompt enhanced to provide some features of the Nyquist Workbench.

It may not look like it, but this was a LOT of work, so trust me, there
WILL be problems and everything effect related should be suspect.  Keep
a sharp eye (or two) open.
2015-04-16 23:36:28 -05:00
Leland Lucius a03d65ef4d Cleanup lib-src
Removing:

id3lib
libresample
libsamplerate
taglib
2015-04-16 14:41:41 -05:00
v.audacity c70c02130a Martyn's patch for Bug 721 - Equalization: Changing language from non-English to English creates two "unnamed" curves. 2014-08-01 20:15:30 +00:00
RichardAsh1981@gmail.com 59b8cdeaa8 separate out Help system functions into their own source file (pending some extra ones) and change the required includes to accomodate this. As a result, some error class definitions have to move from .cpp file to .h file. 2014-06-06 21:34:36 +00:00
benjamin.drung@gmail.com 277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
martynshaw99 f1ce8a5cc2 Optimisation for speed, due to some code I found in an FFT routine. 2014-02-17 00:00:59 +00:00
james.k.crook@gmail.com 88bfabbd76 Indentation of EVENT_MAPS fixed. 2014-01-16 18:25:03 +00:00
james.k.crook@gmail.com d847ee7162 Andrew Hallendorff's SSE accelerated Equalization. 2014-01-16 17:55:35 +00:00
martynshaw99 3f1ebbe3dd Don't allow 'Classic Filters' to be applied to mixed sample-rate tracks, as we don't support that.
Fix a typo in the name of 'Classic Filters'.
Improve consistency layout as we switch filter types.
Remove a win warning in EQ.
Improve some code readability / change styles (please don't shoot me for that!).   OK, possibly increased the inconsistency.
2014-01-09 00:13:34 +00:00
martynshaw99 45973724b3 Eject if tracks are not all at the same sampling rate.
We could perhaps apply the filter at different sampling rates, but that would require a lot of reworking.
2014-01-08 01:03:31 +00:00
lllucius 8a260f33d0 Fix for bug #662
http://bugzilla.audacityteam.org/show_bug.cgi?id=662
2013-10-11 20:01:41 +00:00
martynshaw99 4f5de6d5e3 Quiet a bunch of 'unreferenced formal parameter' warnings on Windows.
The remaining ones are 'formal parameter's referenced by other platforms.
2013-09-25 22:57:54 +00:00
martynshaw99 4ce2643d5f Remove the
// Indentation settings for Vim and Emacs
etc. lines from all files, as Campbell's patch (except for other changes to Languages.cpp)
2013-09-24 00:14:37 +00:00
RichardAsh1981@gmail.com 81f6306d7f check the loop boundary before dereferncing the array to avoid an out-of-bounds access. Patch by Campbell Barton with revisions suggested by Alan Horstmann 2013-09-18 19:46:47 +00:00
james.k.crook@gmail.com dba81b3f1c Cleanup: Fixed lots of trivial MSVC warnings. 2013-08-25 21:51:26 +00:00
v.audacity 51e0391b7d Campbell Barton's patch for mem leaks, http://www.graphicall.org/ftp/ideasman42/audacity_mem_leak_fix_r12450.diff 2013-08-03 00:24:26 +00:00
v.audacity b33983833b Remove individual credits from built-in effects. Should always be in About dialog instead. 2013-06-21 22:10:50 +00:00
v.audacity fb94bd9203 Steve Daulton's fix for bug 599 2013-04-23 05:39:57 +00:00
martynshaw99 025c6ad6d6 Reset tool tip when the Flatten button is pressed. 2013-04-20 20:42:54 +00:00
martynshaw99 da3d1c5564 Fix bug 627 by taking into account changes to envelope code. 2013-04-20 20:29:23 +00:00
v.audacity c26b3c6b49 Campbell Barton's further patch to turn many, many tabs to our 3-space convenbtion 2013-02-23 04:33:20 +00:00
v.audacity fd14d9cfc0 slight adjustment to better distinguish caption from message 2013-01-08 00:57:15 +00:00