Commit Graph

182 Commits

Author SHA1 Message Date
Paul Licameli d2bdd60e91 Internat doesn't depend on wxCore, ComponentInterface, MemoryX 2021-05-27 09:51:32 -04:00
Paul Licameli 5fef82dccf Define Setting classes, bundling config path with settings value...
... the intention being, that no string literal for a path, or its default
value, shall ever occur twice in the code, relying on long-distance coincidence
of literal values.  Instead, a named Setting object is constructed once, then
read and written.

For now, the Tie... functions in ShuttleGuiBase will take references to
implicitly constructed temporary Setting objects.  But all should later be
made static objects, and the constructors made explicit.
2021-05-17 08:46:08 -04:00
Paul Licameli c5ebc396eb Audacity.h has shrunk to nothing, now remove it! 2021-05-10 00:05:23 -05:00
Paul Licameli e653b4aaf8 Eliminate Experimental.h, configure compile options instead...
... This makes it impossible to forget to include the EXPERIMENTAL definitions
(such as when cutting and pasting code) and so get unintended quiet changes of
behavior.

The EXPERIMENTAL flags are now specified instead in new file Experimental.cmake
2021-04-27 12:40:07 -04:00
Leland Lucius 6450495426 Bug 2211 - Mac: keyboard navigation problem in Libraries preferences dialog 2021-04-05 03:37:36 -05:00
Leland Lucius 57ce22e38a Bug 2432 - Linux/Mac: Bad placement of '?' (help) Icon 2021-02-14 01:41:11 -06:00
Leland Lucius 5861ce3c66 Bug 2432 - Linux/Mac: Bad placement of '?' (help) Icon 2021-02-13 01:30:45 -06:00
luzpaz 7a3bdcf3f2
Fix typos (user facing and non-user facing) (#727)
Found via `codespell v2.1.dev0`  
`codespell -q 3 -S *.po,./lib-src -L parm,parms,toke`
2021-01-24 09:46:08 +00:00
freddii 2593a84d56 Fix some spelling mistakes. 2021-01-12 09:55:31 +00:00
James Crook caf4eadb97 Help button for many warning messages; Restored warning icon.
The error icon was gone because we are now using the ErrorDialog, which didn't have it.  So added back explicitly.  I decided to go with wxART_WARNING rather than wxART_ERROR because nearly all of these present as warnings.
2020-09-14 17:43:28 +01:00
Leland Lucius 85b4a5376f AUP3: Make suggested directory preferences changes
In addition, I've extracted the wxTextCtrl wrapper from the
TimerRecordDialog intto widgets/wxTextCtrlWrapper.h and made
it the default for ShuttleGui::AddTextBox(). This way readonly
text controls are always included in the tab order.
2020-07-29 00:08:48 -05:00
Paul Licameli fa4d35296e AllThemeResources.h has a .cpp & doesnt include Theme.h...
... (it used to, via MacroMagic)

This splits a cycle of 8 into 6 + 1 + 1
2020-05-28 05:50:24 -04:00
James Crook dc5ad0309e Fix build 2020-05-25 12:03:56 +01:00
Paul Licameli 5bb1152fe9 Separate ShuttleGuiBase::ApplyItem 2020-05-25 05:40:46 -04:00
Paul Licameli 2397499ba3 Sufficient width of text control boxes (don't hard-code char width) 2020-05-23 09:13:56 -04:00
Paul Licameli 7fb4652c88 Remove some unused functions and forward declarations 2020-05-23 05:16:59 -04:00
Yuri Chornoivan d1ada5f08c Fix minor typos 2020-04-11 10:06:24 +01:00
Paul Licameli 664dc59392 Bug2289: alternative fix...
... see also b23d98fd05 and
bed7b41af9
2020-02-27 08:33:38 -05:00
Paul Licameli b23d98fd05 Bug2289: initial sizing of export mixer slider on Linux...
... bug began at bed7b41af9

Apparently, for GTK one must set the size of a slider before adding it to a
sizer.
2020-02-25 10:11:21 -05:00
Paul Licameli 358aac3181 Change some behavior of ShuttleGui::AddBitmapButton...
... which is not now used, but soon will be
2020-01-23 19:06:17 -05:00
Paul Licameli 2570b56176 Rename Maybe and its members more like std::optional of C++17 2020-01-19 11:38:12 -05:00
Paul Licameli a69fba9990 TracksPrefs does not use hardcoded list of all view types...
... It does have some duplication of string values, but only for purposes of
upgrading old config files.
2020-01-18 20:28:54 -05:00
Paul Licameli 416cdbefb6 ShuttleGuiBase::DoTieChoice is no longer needed 2019-12-26 15:33:47 -05:00
Paul Licameli d396472c9f Rewrite overload of TieChoice that took wxString& instead of int& ...
... let it take TranslatableString& instead.

It was used only in AudioUnitEffect.cpp.
2019-12-26 15:33:47 -05:00
Paul Licameli 8b65b1ae08 ShuttleGui::StartNotebookPage takes TranslatableString...
... and remove an unused overload
2019-12-26 15:33:47 -05:00
Paul Licameli d1637c22c0 TranslatableString for explicit prompts and units in ShuttleGui 2019-12-23 19:22:03 -05:00
Paul Licameli 747c35645a TranslatableString for checkbox captions 2019-12-23 19:15:34 -05:00
Paul Licameli c23451af9d TranslatableString for prompts of radio buttons 2019-12-23 19:02:21 -05:00
Paul Licameli 455d3185a8 TranslatableString for list control column headers, menus 2019-12-23 19:02:21 -05:00
Paul Licameli 6b235bdec5 TranslatableString for captions of sliders 2019-12-23 19:02:21 -05:00
Paul Licameli 13417b6d5b ShuttleGui::AddFixedText takes TranslatableString 2019-12-23 19:02:19 -05:00
Paul Licameli acd1158e1b TranslatableString for titles, and spin control and combo prompts 2019-12-23 18:53:00 -05:00
Paul Licameli 707a069712 ShuttleGui::AddVariableText takes TranslatableString 2019-12-23 18:53:00 -05:00
Paul Licameli 5168d62e3d TranslatableString for captions of text entry boxes 2019-12-23 18:53:00 -05:00
Paul Licameli b404eb7800 TranslatableString for static text box captions 2019-12-23 18:52:37 -05:00
Paul Licameli 21e7b9f2de TranslatableString for prompts of choice controls 2019-12-23 15:39:49 -05:00
Paul Licameli 1944ac2040 TranslatableString for labels of ShuttleGui buttons 2019-12-23 15:35:48 -05:00
Paul Licameli 75996a851c ShuttleGui::AddChoice and TieChoice take TranslatableStrings 2019-12-23 15:35:47 -05:00
Paul Licameli 0247329077 Remove eIs(Getting|Saving)ViaShuttle enum values...
... Because:

1 They weren't used

2 The branches selected by them were wrongly passing user-visible prompt strings
to DoDataShuttle, which elsewhere takes a preference path (this is an error that
could have been detected and avoided if there weren't naked wxString arguments)

3 Without those branches, the affected Tie... functions become more parallel to
other ShuttleGui member functions, which might later be unified into fewer
functions
2019-12-23 15:35:21 -05:00
Paul Licameli 5e26ef1eba Define and use non-mutating TranslatableString::Stripped 2019-12-19 16:41:45 -05:00
Paul Licameli 2dbf0096cc ShuttleGui always sets name of static text box 2019-12-18 10:43:15 -05:00
Paul Licameli 027a5ca32e ShuttleGui static boxes can wrap long text 2019-12-18 10:43:15 -05:00
Paul Licameli f16709945b Define TranslatableString::Strip() 2019-12-16 10:58:05 -05:00
Paul Licameli 7d38500ecf ShuttleGui::AddSpace takes prop argument...
... This will be needed to rewrite EffectRack
2019-12-10 09:58:39 -05:00
Paul Licameli f825c32a50 ShuttleGui can specify orientation and minimum size...
... This will be needed for rewrite of EffectUIHost dialog
2019-12-10 09:58:39 -05:00
Paul Licameli bb3159c758 Don't SetMinSize in ShuttleGui::StartNotebookPage...
... This could only affect the About dialog now, but does not have noticeable
effects.

StartNotebookPage will be reused for Export and Export Multiple dialogs, and
the effects of this SetMinSize call would be undesirable for them.
2019-12-10 09:58:39 -05:00
Paul Licameli 3b69a038c8 Add ShuttleGui functions to make simple book controls...
... analogous to StartNotebook() and EndNotebook()

This will be needed to rewrite export dialogs
2019-12-10 09:58:39 -05:00
Paul Licameli 1802b9316e ShuttleGui::AddStandardButtons takes more general wxWindow *extra...
... This will be needed to rewrite the EffectUIHost dialog
2019-12-10 09:58:39 -05:00
James Crook 23f05c618c Fix signed/unsigned comparison warnings. 2019-12-06 11:33:22 +00:00
Paul Licameli 674ac42de9 ShuggleGui::NameSuffix inserts a space 2019-12-04 00:12:47 -05:00