... Moved many misplaced ones, which msgfmt would not have extracted into
audacity.pot.
Duplicated some of them, to appear with related but distinct msgids.
Added a few new comments.
Deleted one that was no longer needed in ProjectManager.cpp.
Several of the dialog were missing acccess keys.
Note: access keys not added to Distortion effect as yet, due to complexity of control names changing when the Distortion type is changed.
... Wrong results could happen in effects that don't compute the channels
independently, such as the built-in Reverb.
To fix it, always fetch same position of left & right channels when
computing effects.
This removes the ability to import/export multiple presets at
once and add the standard method used by the other plug-ings.
It also adds a workaround for the AU view not updating after
setting a new preset. I will continue to look for the true
cause of this, but the workaround does correct the display
issue.
... without making undesirable dependency cycles.
Eliminate calls to NewWaveTrack in effects, but in Edit>Copy too, which was
not mentioned in the bug report. (Copying a track, deselecting all, and pasting
preserved CLIP colors, but not the TRACK color setting which applies to newly
generated clips.)
Instead, always use the new function WaveTrack::EmptyCopy from the track to be
later replaced, getting color information.
NewWaveTrack is still used in benchmark test, import, the Track menu
commands that make new tracks, recording to new tracks, and generators without
a selection, where there is no track to copy from.
Also when deserializing tracks from the .aup file, in which case the saved
color is later retrieved from the file.
Also, in mix-and-render, where other logic decides whether to copy colors
afterward.
See commit a9658e6ef7
Nearly all of the entire preset handling was broken. It was based
on the parameter names only and for various reasons, that was very
inadequate.
So, it now uses the recommended approach.
EffectChangePitch:: Don't use the inputTracks() when building the GUI
in Batch mode.
Repeat and NyquistEffect had the same problem as they could call
FindProject() which used inputTracks() on a closed project. Fixed by a change in Effect::GetSelectionFormat().
... Force you to pass bool now. Break compilation in case you pass literal
"false", rather than implicitly converting it to bool true !
See commit 7766d9a192 which was in 2.3.2
But Max merged later at d9608cddea in 2.4.0, with
his effect apparently written analogously with the old code in Normalize from
before that, and this quetly compiled with the wrong effects.
... or, what I saw in my Mac builds: there wasn't a hang, but there was
incorrect behavior on alternate attempts to export presets. Sometimes, instead
of (correctly) giving a file overwrite warning, there was instead a message
box about failure to open a non-existent file path, which had the last path
component duplicated.
Problem:
Screen readers don't automatically read the units of the values in text boxes.
Fix:
Add units the the accessibility name of the text boxes.
Thanks to Paul for providing ShuttleGui::NameSuffix(), which makes the code neat and readable.
