audacia/audacia
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
04d7108509
audacia/src
History
David Bailes f9ee3cdc45 Fix some of the accessibility names that disappeared with the move to WX 3.1.1 
The main change in wxWidgets for the setting of accessibility names is:
7dab555f71 (diff-04f5191d86f95b1c4d5d9c979da65878)

Before this change, with wxUSE_ACCESSIBILITY set to 1, for wxWindow and all the classes derived from it, wxWidgets automatically created accessible objects to handle accessibility itself. Because the way wxWindowAccessible::GetName() was written, the accessibility names of lots of windows and controls had to be set using SetName().

After the change, by default, the accessibility of instances of these classes is handled by Windows. Where the accessibility of a control is handled by Windows, then the accessibility name is automatically set to so the appropriate value. However, an accessible can still be set using SetAccessible() then wxWidgets handles the accessibility for this object.

So for many controls we can just leave Windows to set the accessibility name. However, for controls which don't have any visible labels, or where we want to accessibility name to different from the visible text, then we have to set an accessible object for that control, and then call SetName(). The Class WindowAccessible can be used for this purpose. And for custom widgets, like the TrackPanel, and the NumericTextCtrl, SetAccessible() still has to be called, since they need bespoke accessible objects

So in the cases where we want the accessible name to be different from normal, we now need to explicitly set an accessible object. (Before, this wasn't needed, as accessible objects were automatically created.).

Some notes of the fixes included in this commit:
1. The fixes cover the main window, preferences, and built-in effects. Other fixes will follow.

2. In ShuttleGui, I've set accessible objects for wxTextCtrls and wxSliders. So all of these widgets still need the name set. This was done because there are a lot of instances where these controls need non standard accessibility names, and so it saves having to put lots of SetAccessibles throughout the code.

3. For wxPanel, Windows picks up the accessibility name from the label, and so SetLabel() can be used instead of SetName(). This is just as well, since for windows that contain other windows or controls, setting WindowAccessible as the accessibility object breaks the accessibility tree.

Note that at some stage a lot of calls to SetName() can be removed from the code as they are no longer needed, but it might be better to leave them there for the moment, just in case they are unexpectedly needed.
2018-04-06 17:24:40 +01:00
..
blockfile Move definition of _ and related into Internat.h 2018-01-06 21:03:32 -05:00
commands Fix mod-nyq-bench compilation under Windows. 2018-04-05 19:41:10 +01:00
effects Add "Help" button to Noise Reduction. 2018-04-04 15:16:04 +01:00
export Allow 'Export Multiple' of a single track. 2018-04-01 17:52:34 +01:00
import Increase max sample rate for RAW to 384 kHz 2018-04-03 19:04:44 +01:00
ondemand Redo format setting choices in Quality preferences 2018-03-25 14:46:53 -04:00
prefs Fix some of the accessibility names that disappeared with the move to WX 3.1.1 2018-04-06 17:24:40 +01:00
toolbars Fix some of the accessibility names that disappeared with the move to WX 3.1.1 2018-04-06 17:24:40 +01:00
tracks Bug 1837 - Unable to set empty track name 2018-03-25 13:43:49 +01:00
widgets Add missing files to Mac build. 2018-04-04 14:14:59 +01:00
xml Remove wxArray(Int|Long|Double) except where wxWidgets fns need it 2018-02-21 19:33:31 -05:00
AboutDialog.cpp Fix incorrect https and translation markings. 2018-02-26 14:09:07 +00:00
AboutDialog.h Display translator credit only for the chosen locale 2017-11-28 09:17:27 -05:00
AColor.cpp Bug 1701 - Mac: Text descriptors in Selection Toolbar become invisible after Open command 2017-08-13 23:04:13 +01:00
AColor.h doxygen. Class list completed for letter 'A'. 2017-11-09 18:32:29 +00:00
AllThemeResources.h Theme Tweaks 2017-07-19 15:27:00 +01:00
audacity.desktop.in audacity.desktop.in for ja, zh_CN, and zh_TW (thanks to mkpoli) 2017-11-25 17:10:35 -05:00
Audacity.h Avoid multiple include of configunix.h 2018-04-06 11:54:15 +01:00
audacity.xml
AudacityApp.cpp fixed "unknown pragma" warnings for GCC 2018-03-06 21:29:51 +00:00
AudacityApp.h Update fix for #1554 2018-01-10 11:33:05 +00:00
AudacityException.cpp Translate "Message" as default title of message box... 2018-01-01 17:50:02 -05:00
AudacityException.h Simplify GuardedCall and default its return type to void 2018-01-13 01:32:41 -05:00
AudacityHeaders.cpp
AudacityHeaders.h fix Mac build 2018-03-31 23:28:08 -04:00
AudacityLogger.cpp Rewrite many calls to Connect() with Bind()... 2018-02-21 19:28:11 -05:00
AudacityLogger.h Calls to Disconnect or Unbind in destructors are not needed, if... 2018-02-21 19:28:06 -05:00
AudioIO.cpp Redo format setting choices in Quality preferences 2018-03-25 14:46:53 -04:00
AudioIO.h Remove wxArray(Int|Long|Double) except where wxWidgets fns need it 2018-02-21 19:33:31 -05:00
AudioIOListener.h
AutoRecovery.cpp Get rid of wx object arrays, use std::vector 2018-02-21 19:33:27 -05:00
AutoRecovery.h Get rid of wx object arrays, use std::vector 2018-02-21 19:33:27 -05:00
BatchCommandDialog.cpp Use TranslatedInternalString in MacroCommandsCatalog 2018-03-15 19:53:38 -04:00
BatchCommandDialog.h Define MacroCommandsCatalog to associate friendly and internal names... 2018-03-06 18:47:56 -05:00
BatchCommands.cpp Bug 1861 - SplitLabels command fails in Macros 2018-03-27 19:55:57 +01:00
BatchCommands.h Rename 'chain' to 'macro' in history and comments. 2018-03-16 18:47:39 +00:00
BatchProcessDialog.cpp Fix crash on second invocation of Macros after apply to projects. 2018-03-23 09:30:25 +00:00
BatchProcessDialog.h Rename 'chain' to 'macro' in history and comments. 2018-03-16 18:47:39 +00:00
Benchmark.cpp Translate "Message" as default title of message box... 2018-01-01 17:50:02 -05:00
Benchmark.h
BlockFile.cpp Re-fix some warnings about mixing signed and unsigned better... 2018-01-23 18:51:53 -05:00
BlockFile.h Fix error in Mac build uncovered by the previous 2017-06-25 15:36:32 -04:00
ClassicThemeAsCeeCode.h Add Hover-Over-Down State for Button 2017-12-14 14:39:56 +00:00
CMakeLists.txt Compile all libs and link (Debug only so far) using CMake 2018-04-01 15:51:11 +01:00
configtemplate.h Regenerate configure scripts and Makefile.in's 2017-07-04 07:50:16 -04:00
CrossFade.cpp Fix some warnings (MSVC) 2018-03-31 19:47:16 +01:00
CrossFade.h Change sampleCount arguments, variables, return values to size_t... 2016-09-15 21:03:17 -04:00
DarkThemeAsCeeCode.h Shift+Z for Zoom Toggle. Theme tweaks. 2018-01-11 19:24:26 +00:00
Dependencies.cpp Use std::[tr1::]unordered_(set|map), not the wxWidgets container macros 2018-01-08 18:22:51 -05:00
Dependencies.h
DeviceChange.cpp Use wxPrintf not printf 2017-12-16 11:54:32 -05:00
DeviceChange.h
DeviceManager.cpp
DeviceManager.h
Diags.cpp ThomasFeher - Unused parameters clean up. 2016-09-11 20:31:49 +01:00
Diags.h
DirManager.cpp Simplify GuardedCall and default its return type to void 2018-01-13 01:32:41 -05:00
DirManager.h remove unused 2018-01-16 17:51:03 -05:00
Dither.cpp Make enum class for dither type 2018-03-25 14:48:01 -04:00
Dither.h Fix MSVC build. 2018-03-25 21:41:55 +01:00
Envelope.cpp Re-fix some warnings about mixing signed and unsigned better... 2018-01-23 18:51:53 -05:00
Envelope.h Add envelope commands 2018-02-24 14:20:27 -05:00
Experimental.h Possibly correct some cases of clicky playback or corrupt recording... 2018-03-17 23:44:50 -04:00
FFmpeg.cpp Update for FFmpeg 3.5 2018-01-26 19:18:25 -05:00
FFmpeg.h Update for FFmpeg 3.5 2018-01-28 15:49:44 -05:00
FFT.cpp Move definition of _ and related into Internat.h 2018-01-06 21:03:32 -05:00
FFT.h pixel column counts and sample window sizes use unsigned types 2016-09-11 20:28:13 -04:00
FileException.cpp Move definition of _ and related into Internat.h 2018-01-06 21:03:32 -05:00
FileException.h Avoid long repetitions of message boxes for opening corrupt project 2017-10-21 10:40:41 -04:00
FileFormats.cpp Bug1829, more: check all errors flushing and closing export files... 2018-01-22 16:48:20 -05:00
FileFormats.h Fix Windows build 2018-01-24 11:44:06 -05:00
FileIO.cpp Bug1829, more: check all errors flushing and closing export files... 2018-01-22 16:48:20 -05:00
FileIO.h Bug1829, more: check all errors flushing and closing export files... 2018-01-22 16:48:20 -05:00
FileNames.cpp Migrate old chains... 2018-03-15 05:21:04 -04:00
FileNames.h Migrate old chains... 2018-03-15 05:21:04 -04:00
float_cast.h
FreqWindow.cpp Follow wxWidgets argument conventions for other ctors 2018-02-21 19:21:03 -05:00
FreqWindow.h Follow wxWidgets argument conventions for other ctors 2018-02-21 19:21:03 -05:00
HelpText.cpp Fix incorrect https and translation markings. 2018-02-26 14:09:07 +00:00
HelpText.h
HiContrastThemeAsCeeCode.h Shift+Z for Zoom Toggle. Theme tweaks. 2018-01-11 19:24:26 +00:00
HistoryWindow.cpp Replace more Connect with Bind; needed redeclaration of custom events 2018-02-21 19:30:40 -05:00
HistoryWindow.h Rewrite more Connect() with Bind(), which were type incorrect... 2018-02-21 19:28:12 -05:00
HitTestResult.h windows build 2017-07-16 14:46:47 -04:00
ImageManipulation.cpp Add code for iota theme-bitmap 2018-04-04 21:30:10 +01:00
ImageManipulation.h
InconsistencyException.cpp Move definition of _ and related into Internat.h 2018-01-06 21:03:32 -05:00
InconsistencyException.h Sequence consistency check will not throw in 2.2.1 2017-11-20 20:28:04 -05:00
Internat.cpp Fix mod-nyq-bench compilation under Windows. 2018-04-05 19:41:10 +01:00
Internat.h Fix mod-nyq-bench compilation under Windows. 2018-04-05 19:41:10 +01:00
InterpolateAudio.cpp Clean up some dead code and MSVC warnings. 2017-12-08 15:20:39 +00:00
InterpolateAudio.h Remove naked new[] in: linear algebra functions for Repair 2017-03-17 17:52:49 -04:00
LabelDialog.cpp IdentInterfaceSymbol in NumericTextCtrl; don't persist translated 2018-03-28 14:00:17 -04:00
LabelDialog.h IdentInterfaceSymbol in NumericTextCtrl; don't persist translated 2018-03-28 14:00:17 -04:00
LabelTrack.cpp Bug 1551 - Active transport inhibits the operation of "Type to create a label" 2018-03-17 19:17:53 +00:00
LabelTrack.h SetClip, SetLabel, SetProject added 2018-02-24 14:20:24 -05:00
LangChoice.cpp Move definition of _ and related into Internat.h 2018-01-06 21:03:32 -05:00
LangChoice.h
Languages.cpp Use std::[tr1::]unordered_(set|map), not the wxWidgets container macros 2018-01-08 18:22:51 -05:00
Languages.h
Legacy.cpp Remove needless uses of wxString::c_str() in wxString::Format... 2018-01-01 20:34:33 -05:00
Legacy.h
LightThemeAsCeeCode.h Shift+Z for Zoom Toggle. Theme tweaks. 2018-01-11 19:24:26 +00:00
LoadModules.cpp
LoadModules.h
Lyrics.cpp Get rid of wx object arrays, use std::vector 2018-02-21 19:33:27 -05:00
Lyrics.h Fix windows build... 2018-02-22 12:32:53 -05:00
LyricsWindow.cpp Replace more Connect with Bind; needed redeclaration of custom events 2018-02-21 19:30:40 -05:00
LyricsWindow.h Calls to Disconnect or Unbind in destructors are not needed, if... 2018-02-21 19:28:06 -05:00
MacroMagic.h
Makefile.am Build on Linux 2018-02-24 14:20:30 -05:00
Makefile.in Build on Linux 2018-02-24 14:20:30 -05:00
Matrix.cpp Clean up some dead code and MSVC warnings. 2017-12-08 15:20:39 +00:00
Matrix.h Remove naked new[] in: linear algebra functions for Repair 2017-03-17 17:52:49 -04:00
MemoryX.h Compile with wxWidgets 3.1.1 (on Windows). 2018-03-28 12:40:19 +01:00
Menus.cpp IdentInterfaceSymbol in NumericTextCtrl; don't persist translated 2018-03-28 14:00:17 -04:00
Menus.h Add Select->Region->Track Start to End 2018-03-18 20:43:45 +00:00
MenusMac.cpp No more functor objects; all command handler functions take same args 2018-01-05 09:27:29 -05:00
Mix.cpp More use of shared_ptr to Track, for safety... 2018-01-10 20:05:11 -05:00
Mix.h More use of shared_ptr to Track, for safety... 2018-01-10 20:05:11 -05:00
MixerBoard.cpp Make it possible to const'ify xpm. 2018-03-27 05:36:02 -04:00
MixerBoard.h Remove wxArrays of pointers 2018-02-21 19:33:32 -05:00
ModuleManager.cpp Automation: AudacityCommand 2018-02-24 14:20:22 -05:00
ModuleManager.h Automation: AudacityCommand 2018-02-24 14:20:22 -05:00
NoteTrack.cpp Split "Do" functions out of the "Set" functions for some Track settings 2018-02-21 19:20:55 -05:00
NoteTrack.h Split "Do" functions out of the "Set" functions for some Track settings 2018-02-21 19:20:55 -05:00
NumberScale.h simplify SpectrogramSettings::GetScale; abstract frequency-to-bin... 2017-03-17 17:52:27 -04:00
PitchName.cpp Move definition of _ and related into Internat.h 2018-01-06 21:03:32 -05:00
PitchName.h Plot Spectrum, Change Pitch localize pitch names; Unicode sharp/flat 2018-01-02 12:20:04 -05:00
PlatformCompatibility.cpp indentation, final newlines, spelling, remove unused members 2017-11-05 21:01:38 -05:00
PlatformCompatibility.h
PluginManager.cpp Fix an issue caused by the accessibility changes in wxWidgets 3.1.1 2018-04-03 14:57:59 +01:00
PluginManager.h Cleaner class hierarchy 2018-02-24 14:20:24 -05:00
Prefs.cpp Define EnumSetting and EncodedEnumSetting 2018-03-25 13:45:29 -04:00
Prefs.h Possible MSVC buildbot fix. 2018-04-02 19:46:08 +01:00
Printing.cpp Remove EXPERIMENTAL_OUTPUT_DISPLAY... 2018-01-12 12:08:09 -05:00
Printing.h
Profiler.cpp Use wxFprintf not fprintf and you don't need c_str 2017-12-16 11:54:18 -05:00
Profiler.h Remove naked new[] in: various 2017-03-17 17:52:47 -04:00
Project.cpp Fix some of the accessibility names that disappeared with the move to WX 3.1.1 2018-04-06 17:24:40 +01:00
Project.h IdentInterfaceSymbol in NumericTextCtrl; don't persist translated 2018-03-28 14:00:17 -04:00
RealFFTf.cpp Redo type HFFT as a smart pointer, remove malloc and free 2017-03-17 17:52:51 -04:00
RealFFTf.h Redo type HFFT as a smart pointer, remove malloc and free 2017-03-17 17:52:51 -04:00
RealFFTf48x.cpp Remove naked malloc (or similar) and free in: various 2017-03-17 17:52:54 -04:00
RealFFTf48x.h Redo type HFFT as a smart pointer, remove malloc and free 2017-03-17 17:52:51 -04:00
RefreshCode.h doxygen. Class list completed for letter 'A'. 2017-11-09 18:32:29 +00:00
Registrar.h Automation: AudacityCommand 2018-02-24 14:20:22 -05:00
Resample.cpp Redo resampler method choices in Quality preferences 2018-03-25 14:47:58 -04:00
Resample.h Redo resampler method choices in Quality preferences 2018-03-25 14:47:58 -04:00
RevisionIdent.h Bug 1597 - Enh: Greater clarity over status of versions needed 2017-02-25 23:00:39 +00:00
RingBuffer.cpp Fix compilation on Windows. 2018-03-18 10:40:11 +00:00
RingBuffer.h Possibly correct some cases of clicky playback or corrupt recording... 2018-03-17 23:44:50 -04:00
SampleFormat.cpp Redo dither method choices in Quality preferences 2018-03-25 14:48:48 -04:00
SampleFormat.h Remove naked malloc (or similar) and free in: various 2017-03-17 17:52:54 -04:00
Screenshot.cpp use const 2018-03-26 18:04:36 -04:00
Screenshot.h
SelectedRegion.cpp Comment where xml writing functions may throw 2017-03-18 11:45:05 -04:00
SelectedRegion.h SetClip, SetLabel, SetProject added 2018-02-24 14:20:24 -05:00
SelectionState.cpp More careful use of weak pointers to tracks in UIHandles 2017-06-28 01:46:59 -04:00
SelectionState.h Use weak_ptr in track selection state 2017-06-25 13:35:16 -04:00
Sequence.cpp Redo format setting choices in Quality preferences 2018-03-25 14:46:53 -04:00
Sequence.h Get rid of wx object arrays, use std::vector 2018-02-21 19:33:27 -05:00
Shuttle.cpp IdentInterfaceSymbol to distinguish internal vs visible enum settings 2018-03-27 07:51:44 -04:00
Shuttle.h IdentInterfaceSymbol to distinguish internal vs visible enum settings 2018-03-27 07:51:44 -04:00
ShuttleGui.cpp Fix some of the accessibility names that disappeared with the move to WX 3.1.1 2018-04-06 17:24:40 +01:00
ShuttleGui.h Define and use TieNumberAsChoice for Quality sample rate setting 2018-03-25 14:48:52 -04:00
ShuttlePrefs.cpp
ShuttlePrefs.h
Snap.cpp IdentInterfaceSymbol in NumericTextCtrl; don't persist translated 2018-03-28 14:00:17 -04:00
Snap.h IdentInterfaceSymbol in NumericTextCtrl; don't persist translated 2018-03-28 14:00:17 -04:00
SoundActivatedRecord.cpp Move definition of _ and related into Internat.h 2018-01-06 21:03:32 -05:00
SoundActivatedRecord.h Remove unnecessary semicolons 2016-09-18 10:36:53 -04:00
Spectrum.cpp Remove naked new[] in: various 2017-03-17 17:52:47 -04:00
Spectrum.h pixel column counts and sample window sizes use unsigned types 2016-09-11 20:28:13 -04:00
SplashDialog.cpp Replace 2.2.2 'Easter Egg' with place-holder 2018-02-24 16:05:41 +00:00
SplashDialog.h
SseMathFuncs.cpp
SseMathFuncs.h indentation, final newlines, spelling, remove unused members 2017-11-05 21:01:38 -05:00
Tags.cpp Simplify GuardedCall and default its return type to void 2018-01-13 01:32:41 -05:00
Tags.h Fix windows build... 2018-02-22 12:32:53 -05:00
Theme.cpp Generate JSON box list for ThemeCache 2018-04-04 21:34:15 +01:00
Theme.h Remove wxArray(Int|Long|Double) except where wxWidgets fns need it 2018-02-21 19:33:31 -05:00
ThemeAsCeeCode.h
TimeDialog.cpp IdentInterfaceSymbol in NumericTextCtrl; don't persist translated 2018-03-28 14:00:17 -04:00
TimeDialog.h IdentInterfaceSymbol in NumericTextCtrl; don't persist translated 2018-03-28 14:00:17 -04:00
TimerRecordDialog.cpp Fix an issue caused by the accessibility changes in wxWidgets 3.1.1 2018-04-03 14:57:59 +01:00
TimerRecordDialog.h use override 2017-11-05 21:01:52 -05:00
TimeTrack.cpp Use wxPrintf not printf 2017-12-16 11:54:32 -05:00
TimeTrack.h Pass more context information into drawing routines 2017-07-09 12:34:27 -04:00
Track.cpp Bug 1548 - Newly recorded tracks do not acquire focus 2018-03-24 16:05:10 +00:00
Track.h Fix more hassle from the MSVC STL implementation. 2018-02-28 05:14:21 -05:00
TrackArtist.cpp Fix some warnings (MSVC) 2018-03-31 19:47:16 +01:00
TrackArtist.h Redo sample display choice in Tracks preferences 2018-03-25 14:35:59 -04:00
TrackPanel.cpp Make it possible to const'ify xpm. 2018-03-27 05:36:02 -04:00
TrackPanel.h Automation: AudacityCommand 2018-02-24 14:20:22 -05:00
TrackPanelAx.cpp Fix an issue caused by the accessibility changes in wxWidgets 3.1.1 2018-04-03 14:57:59 +01:00
TrackPanelAx.h Fix an issue caused by the accessibility changes in wxWidgets 3.1.1 2018-04-03 14:57:59 +01:00
TrackPanelCell.h TrackPanelCell hit tests can return multiple results... 2017-07-09 08:17:40 -04:00
TrackPanelCellIterator.h Fix end of range of TrackPanelCellIterator 2017-12-20 11:21:29 -05:00
TrackPanelDrawingContext.h Revert the reversion of the elegant fix of wrong MSVC compiler warning 2018-01-13 14:04:25 -05:00
TrackPanelListener.h
TrackPanelMouseEvent.h VZooming Changes 2017-12-11 18:41:48 +00:00
TrackPanelResizeHandle.cpp Remove EXPERIMENTAL_OUTPUT_DISPLAY... 2018-01-12 12:08:09 -05:00
TrackPanelResizeHandle.h Simplify by removing class HitTestResult... 2017-07-09 07:57:34 -04:00
TrackPanelResizerCell.cpp TrackPanelCell hit tests can return multiple results... 2017-07-09 08:17:40 -04:00
TrackPanelResizerCell.h TrackPanelCell hit tests can return multiple results... 2017-07-09 08:17:40 -04:00
TranslatableStringArray.h Replace more Connect with Bind; needed redeclaration of custom events 2018-02-21 19:30:40 -05:00
UIHandle.cpp Remove tab key target cycling and snap escape; reimplement for Esc 2017-07-15 20:37:39 -04:00
UIHandle.h Remove tab key target cycling and snap escape; reimplement for Esc 2017-07-15 20:37:39 -04:00
UndoManager.cpp Bug1845: Remove the vacuous undo check, wasn't good enough anyway 2018-02-26 09:49:01 -05:00
UndoManager.h Scanned for bad naked new; found none; changed comments, used safenew 2017-07-23 09:35:01 -04:00
UserException.cpp Define an AudacityException subclass for user cancellation of progress 2017-03-17 17:52:58 -04:00
UserException.h Fix move constructors and assignments of AudacityException classes 2017-03-21 14:11:17 -04:00
ViewInfo.cpp Zoom Toggle 2018-01-07 17:14:33 +00:00
ViewInfo.h Zoom Toggle 2018-01-07 17:14:33 +00:00
VoiceKey.cpp Fix identical sub-expressions of - operator 2018-01-26 10:12:14 -05:00
VoiceKey.h EXPERIMENTAL_VOICE_DETECTION: compile, use const, more careful casts 2017-03-17 17:52:17 -04:00
WaveClip.cpp Re-fix some warnings about mixing signed and unsigned better... 2018-01-23 18:51:53 -05:00
WaveClip.h Doxygen, Clips and Labels 2018-02-24 14:20:24 -05:00
WaveTrack.cpp Bug 1860 - Enh: Add preference to disable half-wave view on collapse. 2018-03-27 14:41:06 +01:00
WaveTrack.h Redo view mode choice in Tracks preferences 2018-03-25 14:35:12 -04:00
WaveTrackLocation.h Highlighting of cutlines and clip boundaries 2017-07-11 13:57:58 -04:00
WrappedType.cpp
WrappedType.h
wxFileNameWrapper.h