WIP: Add initial pager implementation to category view #106

Draft
isti wants to merge 1 commits from isti/linkulator2:master into master
Contributor

A WIP pager implementation for post listing in category view, because it
some lists have become quite long in RTC

This is a pretty makeshift proof-of-concept solution that doesn't use curses.

It is similar to the idea in the first comment of @asdf in #9

Anyways, I would love to hear what you think

A WIP pager implementation for post listing in category view, because it some lists have become quite long in RTC This is a pretty makeshift proof-of-concept solution that doesn't use curses. It is similar to the idea in the first comment of @asdf in #9 Anyways, I would love to hear what you think
isti added 1 commit 2022-03-06 08:19:20 +00:00
015374fc00 Add initial pager implementation to category view
A WIP pager implementation for post listing in category view, because it
some lists went quite long in RTC
Collaborator

hi @isti looks good, will be interesting to see your approach on this.

do you see this approach working on all pages or only category and category details? like would you split link details into multiple screens or just leave the user to scroll it?

what do you think of the length of the input prompt with the addition of page changing instructions?

hi @isti looks good, will be interesting to see your approach on this. do you see this approach working on all pages or only category and category details? like would you split link details into multiple screens or just leave the user to scroll it? what do you think of the length of the input prompt with the addition of page changing instructions?
Author
Contributor

do you see this approach working on all pages or only category and category details? like would you split link details into multiple screens or just leave the user to scroll it?

Currently the link details screen rarely requires scrolling on RTC, as opposed to the other pages. I'm not sure, honestly.

However, if we implemented this form of paging for comments, a good question would be whether we want to "scroll just the comments" (i.e. re-print the post information before each page) or the whole page. I'm not sure.

what do you think of the length of the input prompt with the addition of page changing instructions?

That is something I'm concerned about as well, I just didn't bother for now, as this is currently just a proof-of-concept idea.

> do you see this approach working on all pages or only category and category details? like would you split link details into multiple screens or just leave the user to scroll it? Currently the link details screen rarely requires scrolling on RTC, as opposed to the other pages. I'm not sure, honestly. However, if we implemented this form of paging for comments, a good question would be whether we want to "scroll just the comments" (i.e. re-print the post information before each page) or the whole page. I'm not sure. > what do you think of the length of the input prompt with the addition of page changing instructions? That is something I'm concerned about as well, I just didn't bother for now, as this is currently just a proof-of-concept idea.
This pull request is marked as a work in progress.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b isti-master master
git pull master

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff isti-master
git push origin master
Sign in to join this conversation.
No description provided.