cmccabe
/
linkulator2
4
10
Fork 4
Code Issues 21 Pull Requests 3 Releases Wiki Activity

Ensure data has trailing line break characters removed #47

Manually merged
asdf merged 1 commits from data-rework into master 2019-12-06 18:40:17 +00:00
Conversation 0 Commits 1 Files Changed 1 +3 -2
asdf commented 2019-12-06 18:15:18 +00:00
Collaborator
Copy Link

Fixes #46 by ensuring line brake/carriage return are removed from the end of the line.

Fixes #46 by ensuring line brake/carriage return are removed from the end of the line.
asdf added the
bug
 label 2019-12-06 18:15:18 +00:00
asdf closed this pull request 2019-12-06 18:40:17 +00:00
sloum reviewed 2019-12-06 23:51:32 +00:00
data.py
sloum commented 2019-12-06 23:51:32 +00:00
Collaborator
Copy Link

Dead code?

Dead code?
sloum reviewed 2019-12-06 23:51:43 +00:00
data.py
sloum commented 2019-12-06 23:51:43 +00:00
Collaborator
Copy Link

Unused var?

Unused var?
asdf reviewed 2019-12-07 08:14:29 +00:00
data.py
asdf commented 2019-12-07 08:14:29 +00:00
Author
Collaborator
Copy Link

Yeah, sorry I should have been clearer that data.py is not in a finished state. Working, but incomplete. The regex was what you had suggested, but I have not gotten far with making it work yet. To fix this bug, I just reverted to the old way of cleaning up the lines.

Yeah, sorry I should have been clearer that data.py is not in a finished state. Working, but incomplete. The regex was what you had suggested, but I have not gotten far with making it work yet. To fix this bug, I just reverted to the old way of cleaning up the lines.
asdf deleted branch data-rework 2020-01-09 04:19:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
compatibility

Deals with compatibility issues

  
documentation

Deals with documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
future release

Lower priority, for a future release.

  
help wanted

Need some help

  
invalid

Something is wrong

  
non-code

For things that are not code themselves but do not fall into other categories cleanly

  
question

More information is needed

  
refactor

Deals with cleaning up or refactoring code

  
testing

Creates tests or investigates failures of tests

  
this release

To be done before this release is finished.

  
wontfix

This won't be fixed

No Label
bug
compatibility
documentation
duplicate
enhancement
future release
help wanted
invalid
non-code
question
refactor
testing
this release
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cmccabe/linkulator2#47
No description provided.
Delete Branch "data-rework"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?