Set minimum Python version required to 3.6, configures tox for testing different Python versions #85

Merged
cmccabe merged 1 commits from set-version-requirements into master 2020-01-31 15:23:54 +00:00
Collaborator

Fixes #73

  • Amend README.md to specify minimum required Python version, and a note about what can happen if this is not met.
  • Add setup.py, requires python 3.6 (this is mainly added for using tox, but acts as a version requirement gateway).
  • Add tox.ini to allow testing with tox for python 3.6, 3.7 and 3.8
  • The different versions of Python must be available for tox or the InterpreterNotFound error occurs. How this is done may differ between systems (I used pyenv, but each could also be installed through the OS package manager) and so this configuration/information is not included.
  • Amend .gitignore to ignore artefacts produced when testing with tox
  • Removed code from linkulator.py for checking minimum Python version compatibility as it did not have the desired effect. Python 3.5 and earlier encounter a syntax error during initial parsing, before this code could run. I couldn't find another way to get this working, so opted to remove it for now.

Checked manually on rawtext.club. Unit tests passing (now in tox on multiple python versions).

Fixes #73 - Amend README.md to specify minimum required Python version, and a note about what can happen if this is not met. - Add setup.py, requires python 3.6 (this is mainly added for using tox, but acts as a version requirement gateway). - Add tox.ini to allow testing with tox for python 3.6, 3.7 and 3.8 - The different versions of Python must be available for tox or the *InterpreterNotFound* error occurs. How this is done may differ between systems (I used pyenv, but each could also be installed through the OS package manager) and so this configuration/information is not included. - Amend .gitignore to ignore artefacts produced when testing with tox - Removed code from linkulator.py for checking minimum Python version compatibility as it did not have the desired effect. Python 3.5 and earlier encounter a syntax error during initial parsing, before this code could run. I couldn't find another way to get this working, so opted to remove it for now. Checked manually on rawtext.club. Unit tests passing (now in tox on multiple python versions).
asdf added the
bug
enhancement
labels 2020-01-29 04:55:28 +00:00
sloum approved these changes 2020-01-29 05:54:50 +00:00
sloum left a comment
Collaborator

Looks solid to me 👍

Looks solid to me :thumbsup:
cmccabe closed this pull request 2020-01-31 15:23:54 +00:00
asdf deleted branch set-version-requirements 2020-01-31 22:16:24 +00:00
Sign in to join this conversation.
No description provided.