Category Details screen now fits terminal width, with aligned columns #93

asdf · 2020-07-02T05:46:40Z

asdf commented

2020-07-02 05:46:40 +00:00

Fixes #88

Targets "release" branch as I have a few small changes to go in
The Category Details screen (the one that lists all links in a category) is now formatted for the width of the console. The description field is shortened to allow for this.
The width of the User column is automatically calculated based on the longest user name length. This means that all rows are now aligned no matter the length of a name.
Ran code formatter

No new tests, will require manual review.

Some things for further consideration:

There is no limit on the length of the username field.
The ID field width could exceed 3 digits and break formatting again.
I put a really long comment in there to explain how the description field width is calculated. Might be good to rethink this.

Fixes #88 - Targets "release" branch as I have a few small changes to go in - The Category Details screen (the one that lists all links in a category) is now formatted for the width of the console. The description field is shortened to allow for this. - The width of the User column is automatically calculated based on the longest user name length. This means that all rows are now aligned no matter the length of a name. - Ran code formatter No new tests, will require manual review. Some things for further consideration: - There is no limit on the length of the username field. - The ID field width could exceed 3 digits and break formatting again. - I put a really long comment in there to explain how the description field width is calculated. Might be good to rethink this.

cmccabe referenced this issue from a commit

2020-07-03 10:19:01 +00:00

Merge pull request 'Category Details screen now fits terminal width, with aligned columns' (#93) from semioticformatic into release Reviewed-on: https://tildegit.org/cmccabe/linkulator2/pulls/93

cmccabe merged commit 90166b470a into release

2020-07-03 10:19:01 +00:00

Sign in to join this conversation.

No reviewers