validated motd scripts

update-motd/00-header

@@ -1,3 +1,2 @@
-#!/bin/bash
-
+#!/bin/sh
 /usr/bin/env figlet  -f /etc/fonts/contessa "$(hostname)" | /usr/games/lolcat -f

update-motd/20-sysinfo

@@ -1,27 +1,29 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # get load averages
-IFS=" " read LOAD1 LOAD5 LOAD15 <<<$(cat /proc/loadavg | awk '{ print $1,$2,$3 }')
-# get free memory
-IFS=" " read USED FREE TOTAL <<<$(free -htm | grep "Mem" | awk {'print $3,$4,$2'})
-# get processes
-PROCESS=`ps -eo user=|sort|uniq -c | awk '{ print $2 " " $1 }'`
-PROCESS_ALL=`echo "$PROCESS"| awk {'print $2'} | awk '{ SUM += $1} END { print SUM }'`
-PROCESS_ROOT=`echo "$PROCESS"| grep root | awk {'print $2'}`
-PROCESS_USER=`echo "$PROCESS"| grep -v root | awk {'print $2'} | awk '{ SUM += $1} END { print SUM }'`
-# get processors
-PROCESSOR_NAME=`grep "model name" /proc/cpuinfo | cut -d ' ' -f3- | awk {'print $0'} | head -1`
-PROCESSOR_COUNT=`grep -ioP 'processor\t:' /proc/cpuinfo | wc -l`
+IFS=" " read -r LOAD1 LOAD5 LOAD15 <<< "$(awk '{ print $1,$2,$3 }' "/proc/loadavg")"
 
-W="\e[0;39m"
-G="\e[1;32m"
+# get free memory
+IFS=" " read -r USED FREE TOTAL <<< "$(free -htm | grep "Mem" | awk '{print $3,$4,$2}')"
+
+# get processes
+PROCESS="$(ps -eo user=|sort|uniq -c | awk '{ print $2 " " $1 }')"
+PROCESS_ALL="$(echo "$PROCESS"| awk '{print $2}' | awk '{ SUM += $1} END { print SUM }')"
+PROCESS_ROOT="$(echo "$PROCESS"| grep root | awk '{print $2}')"
+PROCESS_USER="$(echo "$PROCESS"| grep -v root | awk '{print $2}' | awk '{ SUM += $1} END { print SUM }')"
+# get processors
+PROCESSOR_NAME="$(grep "model name" /proc/cpuinfo | cut -d ' ' -f3- | awk '{print $0}' | head -1)"
+PROCESSOR_COUNT="$(grep -ioP 'processor\t:' /proc/cpuinfo | wc -l)"
+
+W="\\e[0;39m"
+G="\\e[1;32m"
 
 echo -e "
 ${W}system info:
-$W  Distro......: $W`cat /etc/*release | grep "PRETTY_NAME" | cut -d "=" -f 2- | sed 's/"//g'`
-$W  Kernel......: $W`uname -sr`
+$W  Distro......: $W$(cat /etc/*release | grep "PRETTY_NAME" | cut -d "=" -f 2- | sed 's/"//g')
+$W  Kernel......: $W$(uname -sr)
 
-$W  Uptime......: $W`uptime -p`
+$W  Uptime......: $W$(uptime -p)
 $W  Load........: $G$LOAD1$W (1m), $G$LOAD5$W (5m), $G$LOAD15$W (15m)
 $W  Processes...:$W $G$PROCESS_ROOT$W (root), $G$PROCESS_USER$W (user), $G$PROCESS_ALL$W (total)
 

update-motd/35-diskspace

@@ -1,21 +1,21 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 # config
 max_usage=90
 bar_width=50
 # colors
-white="\e[39m"
-green="\e[1;32m"
-red="\e[1;31m"
-dim="\e[2m"
-undim="\e[0m"
+white="\\e[39m"
+green="\\e[1;32m"
+red="\\e[1;31m"
+dim="\\e[2m"
+undim="\\e[0m"
 
 # disk usage: ignore zfs, squashfs & tmpfs
 mapfile -t dfs < <(df -H -x zfs -x squashfs -x tmpfs -x devtmpfs --output=target,pcent,size | tail -n+2)
 for line in "${dfs[@]}"; do
     # get disk usage
     usage=$(echo "$line" | awk '{print $2}' | sed 's/%//')
-    used_width=$((($usage*$bar_width)/100))
+    used_width=$(((usage*bar_width)/100))
     # color is green if usage < max_usage, else red
     if [ "${usage}" -ge "${max_usage}" ]; then
         color=$red
@@ -24,12 +24,12 @@ for line in "${dfs[@]}"; do
     fi
     # print green/red bar until used_width
     bar="[${color}"
-    for ((i=0; i<$used_width; i++)); do
+    for ((i=0; i<used_width; i++)); do
         bar+="="
     done
     # print dimmmed bar until end
     bar+="${white}${dim}"
-    for ((i=$used_width; i<$bar_width; i++)); do
+    for ((i=used_width; i<bar_width; i++)); do
         bar+="="
     done
     bar+="${undim}]"

update-motd/90-motd

@@ -1,4 +1,3 @@
-#!/bin/bash
-
+#!/bin/sh
 printf "\\n"
 grep -v '^<' /var/wiki/changelog.html | awk -v RS= 'NR==1 || NR==2 {print $0 "\n"}' | /usr/games/lolcat -f