khuxkm
/
cosmicbot
2
2
Fork 4
Code Issues Pull Requests Releases Wiki Activity

Add latest command #2

Merged
khuxkm merged 1 commits from alexis/cosmicbot:latest into master 2018-12-07 23:12:41 +00:00
Conversation 2 Commits 1 Files Changed 3 +29 -21
alexis commented 2018-12-07 05:30:17 +00:00
Contributor
Copy Link

There was some byplay in #cosmic about adding this, so I did that. It will only report the five most recent updates, to avoid spamming the channel.

It could easily say something like (Visit gopher://cosmic.voyage:70 or https://cosmic.voyage for more!) at the end of output, but it doesn't, because I only just thought of it while writing this PR description just now. I don't mind adding that before merge if it's considered worthwhile.

This PR also includes a sidecar commit replacing the ZWS from #1 with ~a zero-width non-breaking space, which prevents soft line wrapping from occurring within nicks in the output of the roster command.~ surrounding underscores, to avoid issues with clients where Unicode support is imperfect. The same sidecar commit also fixes argument handling to !roster, such that e.g. !roster dei genetrix passes dei genetrix to the underlying shell command, and returns the expected result.

There was some byplay in #cosmic about adding this, so I did that. It will only report the five most recent updates, to avoid spamming the channel. It could easily say something like `(Visit gopher://cosmic.voyage:70 or https://cosmic.voyage for more!)` at the end of output, but it doesn't, because I only just thought of it while writing this PR description just now. I don't mind adding that before merge if it's considered worthwhile. This PR also includes a sidecar commit replacing the ZWS from #1 with ~a zero-width non-breaking space, which prevents soft line wrapping from occurring within nicks in the output of the `roster` command.~ surrounding underscores, to avoid issues with clients where Unicode support is imperfect. The same sidecar commit also fixes argument handling to `!roster`, such that e.g. `!roster dei genetrix` passes `dei genetrix` to the underlying shell command, and returns the expected result.
khuxkm commented 2018-12-07 12:47:28 +00:00
Owner
Copy Link

Please do add the "Visit cosmic.voyage for more". (But add it to the end of the "latest X entries" message please)

Please do add the "Visit cosmic.voyage for more". (But add it to the end of the "latest X entries" message please)
khuxkm commented 2018-12-07 13:50:54 +00:00
Owner
Copy Link

Actually, could you try using the RSS feedparser lib (for purposes of having URLs)?

Actually, could you try using the RSS feedparser lib (for purposes of having URLs)?
khuxkm closed this pull request 2018-12-07 23:12:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: khuxkm/cosmicbot#2
No description provided.
Delete Branch "alexis/cosmicbot:latest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?