khuxkm
/
cosmicbot
2
2
Fork 4
Code Issues Pull Requests Releases Wiki Activity

Allow !latest to accept strings for regex matches #6

Merged
khuxkm merged 4 commits from tomasino/cosmicbot:latest-regex into master 2019-02-13 19:18:35 +00:00
Conversation 8 Commits 4 Files Changed 1 +9 -6
tomasino commented 2019-01-22 15:52:16 +00:00
Contributor
Copy Link

The shell command latest now includes post number in the output. After seeing people in the IRC channel attempt to get the latest posts by ship name, I've implemented that feature in the shell. Passing an int to latest gives that number of entries. Passing a string does a grep -i search and returns up to 5 results.

The shell command `latest` now includes post number in the output. After seeing people in the IRC channel attempt to get the latest posts by ship name, I've implemented that feature in the shell. Passing an int to `latest` gives that number of entries. Passing a string does a `grep -i` search and returns up to 5 results.
tomasino commented 2019-01-22 15:54:31 +00:00
Author
Contributor
Copy Link

There might be some extra variable casting necessary. I'm not sure if the bot interprets all params as strings, even numeric ones. If that's the case then the isinstance probably needs to be replaced with a regex test instead.

I'm not sure of a way to test these changes prior to PR, sadly.

There *might* be some extra variable casting necessary. I'm not sure if the bot interprets all params as strings, even numeric ones. If that's the case then the isinstance probably needs to be replaced with a regex test instead. I'm not sure of a way to test these changes prior to PR, sadly.
khuxkm commented 2019-01-22 19:10:19 +00:00
Owner
Copy Link

@tomasino All params are strings. Probably you could do:

if re.match(r"d+",count): count = int(count)
@tomasino All params are strings. Probably you could do: ```python if re.match(r"d+",count): count = int(count) ```
tomasino commented 2019-01-22 19:30:37 +00:00
Author
Contributor
Copy Link

Updated the code to reflect that test.

Updated the code to reflect that test.
khuxkm commented 2019-02-01 19:21:55 +00:00
Owner
Copy Link

Please update the "Latest entry from" message for the case that it's a string and not a number.

Please update the "Latest entry from" message for the case that it's a string and not a number.
tomasino commented 2019-02-05 00:39:38 +00:00
Author
Contributor
Copy Link

I've provided a different message for non-numeric searches.

I've provided a different message for non-numeric searches.
khuxkm commented 2019-02-06 21:23:00 +00:00
Owner
Copy Link

Will it work with the weird indent on else?

Will it work with the weird indent on `else`?
tomasino commented 2019-02-09 01:10:53 +00:00
Author
Contributor
Copy Link

No, it definitely wouldn't. Vim was expanding tabs, sadly. I've fixed the indenting. Do you want me to squash these commits down prior to merge?

No, it definitely wouldn't. Vim was expanding tabs, sadly. I've fixed the indenting. Do you want me to squash these commits down prior to merge?
khuxkm commented 2019-02-13 19:18:31 +00:00
Owner
Copy Link

No, I'll merge as is. Thanks!

No, I'll merge as is. Thanks!
khuxkm closed this pull request 2019-02-13 19:18:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: khuxkm/cosmicbot#6
No description provided.
Delete Branch "tomasino/cosmicbot:latest-regex"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?