The thousands separator was being used for messages and thus became incompatible with pcoin. Now, the thousands separator is only used to display amounts and not stored in the message files for tcoin/pcoin
As seems login forgot to close a parenthesis in the manual recovery
messages, and also appears like I am hunting for errors in tcoin :)
I have just changed the instances of the manual recovery messages from
"login@tilde.town (town-only) or login@tilde.team (internet wide [...]"
to:
"login@tilde.town (town-only) or login@tilde.team (internet wide) [...]"
pcoin -aib now doesn't allow you to add to your own internal balance. in the future, pcoin -ib <your own program name> will allow you to see what your 'net balance' is, i.e., pcoin -b minus pcoin -to
Due to krowbar not being here and krowbar's tildebot not rejoining, shifting tildescores file location to jmjl's tildescores location. jmjl is running krobwar's tildebot with the name 'ju' in tilde.town's internal irc's #bots channel
This is expected to help a pcoin escrow program confirm that a key supplied to it is that of the right pcoin account by checking what the output of 'pcoin name' is. In the future, it may be expected that 'view key', 'spend key' and 'transfer key' would be three different keys that would split power over the pcoin account. And each of the previously mentioned 'keys' could be m-of-n keys. Maybe some kind of social recovery feature could also be added (where other users confirm who you are so you can get your account back, but you nominate them as your 'social recovery circle' beforehand.
Made this change so that new "!minercoin ask" awarded minercoins will still show up in tcoin without losing old !minercoins awarded.
In other words, the inflation will continue until morale improves.
ntcoin creates a new tcoin directory structure, and copies relevant files. Some permissions were set wrongly by ntcoin and its variants. Those have been fixed now.
Thanks to ~jmjl, I was able to find that pcoin_keys didn't work. To fix it, tcoin uses sneaky magic but with stdin isntead of an argument, and a new library imported called popen2, that lets me send both stdin and receive stdout, to successfully get "ls <path to the pcoin_keys directory>" to work (it execl's another instance of the tcoin comand so that it runs under setuid instead of as the original user who ran it.
/usr/bin/whoami doesn't give the euid's username, but the uid's on FreeBSD, so did the same thing I did for tilde.institute, but for tilde.guru too and introduced a new flag for it, TILDEGURU.
tilde.guru doesn't have the default group of new files be the 'tilde' group, so the group should be manually changed in the compile_tcoin and compile_pcoin scripts. ntcoin_freebsd_tildeguru creates those scripts, so the changes have been made in that file.
This is preparing tcoin/pcoin for the automatic registration of program accounts.
Eventually, I want program accounts to be tradeable by there being a way to regenerate a new key.
So, send the current key to whomever you want the program account to be used by, then the new owner regenerates the key
to complete the transfer. The old owner will no longer be able to use the old key to operate the new account. The key is
long and the key generation random enough for key collisions to be virtually impossible.
Improved the way 5 arguments were handled, where the intention was to
send a message along with the amount and receiver, with a new error code
and a slightly modified error message.
There were many more places where I had hardcoded values, but
should have used strlen() or sizeof(). I have gone through
tcoin.cpp and pcoin.cpp, found those, and fixed them.
Hopefully, this is all of them.
In user_has_initialised(..), the path lengths were hardcoded.
This has now been changed to being calculated via sizeof().
In get_file_value and add_file_value, strlen() was used. This has
also been replaced with sizeof().