Merge branch 'release2.3.3' into gemini-gutter
This commit is contained in:
commit
824d8bbf81
|
@ -25,10 +25,10 @@ Changes are implemented to the default branch when:
|
||||||
|
|
||||||
### Process for introducing a new change
|
### Process for introducing a new change
|
||||||
|
|
||||||
Please refer to our [notes on contributing](README.md#contributing) to get an understanding of how new changes are initiated, the type of changes accepted and the review process.
|
Before you begin, please refer to our [notes on contributing](README.md#contributing) to get an understanding of how new changes are initiated, the type of changes accepted and the review process.
|
||||||
|
|
||||||
1. Create a new feature branch based on the **develop** branch.
|
1. Create a new feature branch based on the **develop** branch.
|
||||||
1. Raise a pull request (PR) targeting the **develop** branch.
|
1. Raise a pull request (PR) targeting the current release branch (confirm this in the issue comments before proceeding).
|
||||||
1. The PR is reviewed.
|
1. The PR is reviewed.
|
||||||
1. If the PR is approved, it is merged.
|
1. If the PR is approved, it is merged.
|
||||||
1. The version number is incremented, along with any other release activity.
|
1. The version number is incremented, along with any other release activity.
|
||||||
|
|
|
@ -102,6 +102,7 @@ func Getch() rune {
|
||||||
|
|
||||||
func GetLine(prefix string) (string, error) {
|
func GetLine(prefix string) (string, error) {
|
||||||
termios.SetLineMode()
|
termios.SetLineMode()
|
||||||
|
defer termios.SetCharMode()
|
||||||
|
|
||||||
reader := bufio.NewReader(os.Stdin)
|
reader := bufio.NewReader(os.Stdin)
|
||||||
fmt.Print(prefix)
|
fmt.Print(prefix)
|
||||||
|
@ -110,7 +111,6 @@ func GetLine(prefix string) (string, error) {
|
||||||
return "", err
|
return "", err
|
||||||
}
|
}
|
||||||
|
|
||||||
termios.SetCharMode()
|
|
||||||
return text[:len(text)-1], nil
|
return text[:len(text)-1], nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue