Remove unused functions getCurrentPageRawData & getCurrentPageUrl #100
No reviewers
Labels
No Label
blocked
bug
build
documentation
duplicate
enhancement
finger
gemini
gopher
help wanted
http
in progress
invalid
local
needs-info
non-code
non-functional
non-urgent
question
release
rendering
suggestion
telnet
terminal
urgent
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: sloum/bombadillo#100
Loading…
Reference in New Issue
No description provided.
Delete Branch "remove-getCurrentPage-"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #98
Functions getCurrentPageRawData & getCurrentPageUrl were identified as unused and are to be removed.
Did some minor testing, no issues observed.
This can be held off until after the 2.0.0 release.
Looks good. I have not generated the binaries for release yet (I think I should wait and make the release TAG before generating the binaries), so we could merge this in now if you think it would be good to do so. On the other hand there will always be things to come up. Maybe best to respect the code freeze? Let me know. I'm good either way. But if we merge this it really should be the last code change.