Query strings are not being escaped for gemini status 1x requests #161

New Issue

sloum · 2020-05-24T18:14:53Z

sloum commented

2020-05-24 18:14:53 +00:00

This was not included in the last build due to some perceived ambiguity on my part. It seemed that the major search engines were not unescaping query strings. However, this has been shown to be incorrect. They do escape, but they do not seem to support + as meaning <space>. The tools in net/url encode a space as +, which causes the, mostly built with python, servers to just render a +.

I am actvely seeking advice for this issue on the message board. This did not make it into 2.3.0, but can be a minor release sometime soon once a path forward is figured out.

This was not included in the last build due to some perceived ambiguity on my part. It seemed that the major search engines were not unescaping query strings. However, this has been shown to be incorrect. They do escape, but they do not seem to support `+` as meaning `<space>`. The tools in `net/url` encode a space as `+`, which causes the, mostly built with python, servers to just render a `+`. I am actvely seeking advice for this issue on the message board. This did not make it into `2.3.0`, but can be a minor release sometime soon once a path forward is figured out.

sloum added the

bug

gemini

labels 2020-05-24 18:15:09 +00:00

sloum commented

2020-05-24 18:16:00 +00:00

This is related to #157 which was closed as fixing the main issue being brought to attention by that issue card. However, it can be referenced for more info on this issue.

sloum referenced this issue

2020-05-24 18:19:43 +00:00

Repeated queries are not handled correctly #157

sloum changed title from ~~Query strings are not being escaped for gemini status 1x responses~~ to Query strings are not being escaped for gemini status 1x requests

2020-05-24 18:24:32 +00:00

sloum referenced this issue

2020-05-26 02:45:31 +00:00

Adds in the correct variable when checking for existing querystring value #166

sloum commented

2020-05-26 02:46:23 +00:00

A fix for this has a PR: #166

Using PathEscape rather than QueryEscape seems to avoid the issue of + being used for spaces, as it uses %20.

A fix for this has a PR: #166 Using `PathEscape` rather than `QueryEscape` seems to avoid the issue of `+` being used for spaces, as it uses `%20`.

sloum added the

in progress

label 2020-05-26 02:46:32 +00:00