Change c.Visit(u) call to blocking, from goroutine #102

asdf · 2019-11-27T08:34:55Z

asdf commented

2019-11-27 08:34:55 +00:00

Fixes #101

Call to c.Visit(u) reverted to a blocking call, from calling it as a goroutine (i.e. 'go c.Visit(u)).

When both c.Visit() and c.TakeControlInput() are run as goroutines, a situation can occur where both c.TakeControlInput() and c.handleGemini() will try to get keyboard input at the same time. This can result in the client not responding to keyboard input.

This change may be temporary, as it could have an effect on performance.

Fixes #101 Call to c.Visit(u) reverted to a blocking call, from calling it as a goroutine (i.e. 'go c.Visit(u)). When both c.Visit() and c.TakeControlInput() are run as goroutines, a situation can occur where both c.TakeControlInput() and c.handleGemini() will try to get keyboard input at the same time. This can result in the client not responding to keyboard input. This change may be temporary, as it could have an effect on performance.

asdf added the

bug

label 2019-11-27 08:34:55 +00:00

sloum commented

2019-11-28 06:03:37 +00:00

Looks good to me! Merging in.

sloum closed this pull request

2019-11-28 06:03:42 +00:00

sloum referenced this pull request

2019-11-28 06:04:00 +00:00

Buggy redirect input in gemini #101

Sign in to join this conversation.