Users can now check settings in the client and receive better messages #11

sloum · 2019-05-09T04:09:14Z

sloum commented

2019-05-09 04:09:14 +00:00

Removed a few quickMessage defers. Messaging has changed enough that it only needs to be explicitly removed if it needs to be removed before further user input.
Added '?' to the parser as a command to bring up the help info
Added 'check' and 'c' to the parser. Added related functions in main to allow a user to check the values of their settings (:check homeurl). This uses the improved messaging system. The message that is displayed lasts until a meaningful user command.
Ran gofmt and govet on the files in question

Closes issue (#9)[#9]

- Removed a few quickMessage defers. Messaging has changed enough that it only needs to be explicitly removed if it needs to be removed before further user input. - Added '?' to the parser as a command to bring up the help info - Added 'check' and 'c' to the parser. Added related functions in main to allow a user to check the values of their settings (`:check homeurl`). This uses the improved messaging system. The message that is displayed lasts until a meaningful user command. - Ran gofmt and govet on the files in question Closes issue (#9)[https://tildegit.org/sloum/bombadillo/issues/9]

jboverf was assigned by sloum

2019-05-09 04:09:14 +00:00

jboverf approved these changes 2019-05-09 23:35:11 +00:00

main.go Outdated

						
				@ -62,3 +64,3 @@

					}

					return fmt.Errorf(saveMsg)

					// return fmt.Errorf(saveMsg)

jboverf commented

2019-05-09 13:54:10 +00:00

Looks like this might have been left in from debugging/testing

jboverf commented

2019-05-09 23:35:31 +00:00

Looks good - only thing that caught my eye was the commented out code

👍 1

sloum commented

2019-05-10 04:42:19 +00:00

I removed the dead code and cleaned up a few other odds and ends I found that relate to the update (some comments that no longer apply). Merging in new command: check. :)

sloum closed this pull request

2019-05-10 04:42:25 +00:00

sloum commented

2019-05-10 04:43:09 +00:00

Closes issue #9

Closes issue https://tildegit.org/sloum/bombadillo/issues/9

Sign in to join this conversation.

No reviewers