Automatically renew an expired cert, rather than throwing an error tot he user #143

sloum · 2020-05-09T23:30:23Z

sloum commented

2020-05-09 23:30:23 +00:00

When a cert expires for a gemini site the user is informed and they have to decide to purge the cert. This has been because we do not store the expiration date.

This PR updates the code to store the expiration along with the certificate hash as a | delimited string. This can be checked against and if the certificate has expired we can then just take the new certificate that is offered. If not non-expired cert is offered by the server, the user will still see an expired certificate error. Otehrwise, they should be able to seamlessly update their cert without having to resort to purge.

This PR is in response to issue #142

When a cert expires for a gemini site the user is informed and they have to decide to purge the cert. This has been because we do not store the expiration date. This PR updates the code to store the expiration along with the certificate hash as a `|` delimited string. This can be checked against and if the certificate has expired we can then just take the new certificate that is offered. If not non-expired cert is offered by the server, the user will still see an expired certificate error. Otehrwise, they should be able to seamlessly update their cert without having to resort to purge. This PR is in response to issue #142

sloum added the

bug

enhancement

gemini

labels 2020-05-09 23:30:23 +00:00

sloum referenced this pull request

2020-05-09 23:30:57 +00:00

Store expiration of certs #142

asdf commented

2020-05-11 02:53:07 +00:00

This is a good thing to fix, and it seems to work well in that I can browse to a few different gemini sites I've not visited in a while without having to purge certs to get things working.

sloum commented

2020-05-13 14:30:39 +00:00

Awesome. I ahve had the same experience (far fewer purges). I'll merge this in when I get a moment and may have this one and the other that is on develop move over to master as a minor version since this ends up fixing something reasonably significant.