Adds a release target to makefile #170

sloum · 2020-05-28T05:38:19Z

sloum commented

2020-05-28 05:38:19 +00:00

I had been using a shell script to do this, but then realized that was stupid: use make! While I break with DRY here, this seems more direct than trying to use make to loop over the available OS and ARCH targets. At least while we only officially support a few platforms.

I have tested this locally and it works well. I also added a step to clean to remove any release files on clean.

I also updated the README to mention that a GNU Make compatible is required to run the Makefile. This had never occured to me until I started using BSD this week... which does not, by default, use GNU Make but instead uses BSD Make. They are not strictly compatible (at least not in their extensions). We use GNU Make extensions (our conditionals and I think some others) so building with the makefile on BSD is out. I felt like that should be mentioned in the README. Anyone using BSD likely knows to use gmake to build it, but they may need to install it (I'm mostly not worried about it as anyone that managed to get a working BSD build on their system will likely be able to figure this out).

In the future I would like to try to get our makefile to work for both if possible. They share compatibility with the core make features, they both just added on incompatible stuff.

I had been using a shell script to do this, but then realized that was stupid: use make! While I break with DRY here, this seems more direct than trying to use make to loop over the available OS and ARCH targets. At least while we only officially support a few platforms. I have tested this locally and it works well. I also added a step to clean to remove any release files on clean. I also updated the README to mention that a GNU Make compatible is required to run the Makefile. This had never occured to me until I started using BSD this week... which does not, by default, use GNU Make but instead uses BSD Make. They are not strictly compatible (at least not in their extensions). We use GNU Make extensions (our conditionals and I think some others) so building with the makefile on BSD is out. I felt like that should be mentioned in the README. Anyone using BSD likely knows to use gmake to build it, but they may need to install it (I'm mostly not worried about it as anyone that managed to get a working BSD build on their system will likely be able to figure this out). In the future I would like to try to get our makefile to work for both if possible. They share compatibility with the core make features, they both just added on incompatible stuff.

sloum added the

documentation

build

labels 2020-05-28 05:38:44 +00:00

sloum referenced this issue from a commit

2020-05-29 02:34:31 +00:00

Merge pull request 'Adds a release target to makefile' (#170) from make-release into release-2.3.1 Merging in since there is no code to the application here and none of the core makefile targets are altered.

sloum closed this pull request

2020-05-29 02:34:32 +00:00

sloum deleted branch make-release

2020-05-29 02:34:40 +00:00

Sign in to join this conversation.