Cleanup #2

jboverf · 2019-04-28T19:49:45Z

jboverf commented

2019-04-28 19:49:45 +00:00

Gofmt all code
Switch to canonical function naming
Add a go.mod file for use with the latest go version
Correct import paths

This is purely a cleanup PR - no functionality was changed and no code was refactored. My plan is make subsequent, smaller PRs for other kinds of refactors.

* Gofmt all code * Switch to canonical function naming * Add a go.mod file for use with the latest go version * Correct import paths This is purely a cleanup PR - no functionality was changed and no code was refactored. My plan is make subsequent, smaller PRs for other kinds of refactors.

sloum approved these changes 2019-04-28 20:31:30 +00:00

sloum left a comment

While I still prefer snake case to camel (snake is just so much more readable), this all looks good. I have generally hesitated to use Go's web link style imports... the web, particularly small servers like tildegit, seems so impermanent... it feels unwise to tie module imports to it rather than using local file structure. That said, if that is the way things have gone then I guess that is the way that the code should be.

Thanks so much for getting this set up :)

While I still prefer snake case to camel (snake is just so much more readable), this all looks good. I have generally hesitated to use Go's web link style imports... the web, particularly small servers like tildegit, seems so impermanent... it feels unwise to tie module imports to it rather than using local file structure. That said, if that is the way things have gone then I guess that is the way that the code should be. Thanks so much for getting this set up :)

sloum closed this pull request

2019-04-28 20:41:13 +00:00

jboverf commented

2019-04-28 21:26:47 +00:00

r.e. variable names - it seems like each language community has come up with their own style they stick to. I'm not sure I personally prefer one way over the other but it is nice the language has picked one style and stuck with it I think. Same thing with gofmt - it just short circuits any disagreement about it!

r.e. the imports - the move to Go modules actually helps your concern here. There's actually no need for that url to exist for the code to compile. You can check out the repo anywhere on your system and compile and it works. As long as the module path in the go.mod file and the import statements match, you're good.

r.e. variable names - it seems like each language community has come up with their own style they stick to. I'm not sure I personally prefer one way over the other but it is nice the language has picked one style and stuck with it I think. Same thing with gofmt - it just short circuits any disagreement about it! r.e. the imports - the move to Go modules actually helps your concern here. There's actually no need for that url to exist for the code to compile. You can check out the repo anywhere on your system and compile and it works. As long as the module path in the go.mod file and the import statements match, you're good.

jboverf deleted branch cleanup

2019-04-28 21:27:12 +00:00

sloum commented

2019-04-29 03:48:38 +00:00

@jboverf

On balance, I agree that code being consistent mostly trumps individual preferences and I am for that with projects that other people will be seeing. :)

I think I must just be really confused about the module system. I am glad to hear that it is not tied to the web location, but I am confused about how it would know where on a hard drive the cloned version of the repo would be.

Thanks for being patient with my confusion! I really appreciate the help!

@jboverf On balance, I agree that code being consistent mostly trumps individual preferences and I am for that with projects that other people will be seeing. :) I think I must just be really confused about the module system. I am glad to hear that it is not tied to the web location, but I am confused about how it would know where on a hard drive the cloned version of the repo would be. Thanks for being patient with my confusion! I really appreciate the help!

Sign in to join this conversation.

No reviewers