sloum/bombadillo
sloum
/
bombadillo
5
27
Fork 7
Code Issues 18 Pull Requests 1 Releases 9 Activity

Solves issue where 0 crashes program #22

Merged
sloum merged 1 commits from bad-link-num-fix into master 2019-05-26 17:52:35 +00:00
Conversation 0 Commits 1 Files Changed 1 +5 -2
sloum commented 2019-05-26 17:52:11 +00:00
Owner
Copy Link

Adds an extra check to make sure a link number is greater than zero. Also adds handling for negative link numbers and decimal link numbers (all of which now receive proper error messaging).

Adds an extra check to make sure a link number is greater than zero. Also adds handling for negative link numbers and decimal link numbers (all of which now receive proper error messaging).
sloum closed this pull request 2019-05-26 17:52:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Needs clarification

  
bug

Something is not working

  
build

Relating to the build process/toolchain

  
documentation

Relates to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
finger

Relates to the finger module

  
gemini

Relates to the gemini module

  
gopher

Relates to the gopher module

  
help wanted

Need some help

  
http

Relates to the http module

  
in progress

Denotes that a member of the team is actively working on this issue

  
invalid

Something is wrong

  
local

Relates to the local file module

  
needs-info

We do not have enough information for this issue

  
non-code

Does not correpond to code issue

  
non-functional

Code cleanup/refactor

  
non-urgent

Take your time

  
question

A request for comment or open question

  
release

This PR is from develop to master

  
rendering

Relates to visual output

  
suggestion

A suggestion for a feature

  
telnet

Relates to the telnet module

  
terminal

Issues with terminal handling

  
urgent

Handle ASAP

  
wontfix

This won't be fixed

No Label
blocked
bug
build
documentation
duplicate
enhancement
finger
gemini
gopher
help wanted
http
in progress
invalid
local
needs-info
non-code
non-functional
non-urgent
question
release
rendering
suggestion
telnet
terminal
urgent
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sloum/bombadillo#22
No description provided.
Delete Branch "bad-link-num-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?