Fixes scrolling issues on smaller screens #25

sloum · 2019-05-29T02:39:07Z

sloum commented

2019-05-29 02:39:07 +00:00

Will close #23

@asdf pointed out that when the screen/terminal size gets narrower they were not able to scroll to the bottom of a view anymore.

It turns out this was caused by the fact that the scrolling commands were only aware of the original content length, and not the modified content length.

I had not liked referencing specific windows in the window module anyway, so I moved the resize check to a function in main (which feels better). However, due to the flow of how things happen the code does get a little weird. I think it is possible that a larger reflow of how things work will be needed eventually. However, I think moving forward with something along these lines is ok for the moment (better than having users that cannot see the bottom of a page).

I also have some concerns about how the text-wrapping works. It does not reflow smoothly at all... there are full lines followed by short lines. I understand the mechanism of why and feel hesitant to change it as it could mess up gophermaps and ascii art to redefine where newlines appear. Just noting it here for future reference.

Will close https://tildegit.org/sloum/bombadillo/issues/23 @asdf pointed out that when the screen/terminal size gets narrower they were not able to scroll to the bottom of a view anymore. It turns out this was caused by the fact that the scrolling commands were only aware of the original content length, and not the modified content length. I had not liked referencing specific windows in the window module anyway, so I moved the resize check to a function in main (which feels better). However, due to the flow of how things happen the code does get a little weird. I think it is possible that a larger reflow of how things work will be needed eventually. However, I think moving forward with something along these lines is ok for the moment (better than having users that cannot see the bottom of a page). I also have some concerns about how the text-wrapping works. It does not reflow smoothly at all... there are full lines followed by short lines. I understand the mechanism of why and feel hesitant to change it as it could mess up gophermaps and ascii art to redefine where newlines appear. Just noting it here for future reference.

sloum added the

bug

label 2019-05-29 02:40:17 +00:00

sloum closed this pull request

2019-06-01 05:36:06 +00:00

Sign in to join this conversation.

No reviewers