A tab in a URL no longer causes a msg bar overflow into the next line #33

sloum · 2019-09-04T03:24:29Z

sloum commented

2019-09-04 03:24:29 +00:00

There may still be an edge case for this in which it can overflow (sort of) on smaller screens. However, this should fix the base case where just having the tab there at all was causing an overflow.

This should solve/close #32

There may still be an edge case for this in which it can overflow (sort of) on smaller screens. However, this should fix the base case where just having the tab there at all was causing an overflow. This should solve/close #32

sloum added the

bug

label 2019-09-04 03:24:29 +00:00

asdf was assigned by sloum

2019-09-05 16:02:38 +00:00

sloum commented

2019-09-05 16:05:03 +00:00

@asdf I have added you as a collaborator to the project with write privileges. I really appreciate all your help. Let me know if this seems to fix the primary title bar wrapping issue whenever you get a chance.

asdf commented

2019-09-06 10:54:24 +00:00

OK I can reproduce what you have found - this fixes overflow when fullscreen, and does not address overflow for a terminal at 80 characters wide. I'd say proceed with this one as is to get the fix applied.

sloum commented

2019-09-06 16:14:34 +00:00

@asdf sounds good. I'll merge in.

Also, I dont know if you noticed, but I added you as a collaborator for the repo with write (though not admin) privileges. You've been a big help :) If this is something you are not interested in or do not want just let me know and I can remove that setting (there are no responsibilities or anything, just thought it might make some things easier for you).

@asdf sounds good. I'll merge in. Also, I dont know if you noticed, but I added you as a collaborator for the repo with write (though not admin) privileges. You've been a big help :) If this is something you are not interested in or do not want just let me know and I can remove that setting (there are no responsibilities or anything, just thought it might make some things easier for you).

sloum closed this pull request

2019-09-06 16:14:48 +00:00

sloum deleted branch msg-bar-tab-fix

2019-09-06 16:14:57 +00:00

asdf commented

2019-09-07 10:56:24 +00:00

Glad we could get this resolved.

Thanks for the additional access and thanks for letting me collaborate. I'm new to git so I'll avoid taking action that breaks anything.

Glad we could get this resolved. Thanks for the additional access and thanks for letting me collaborate. I'm new to git so I'll avoid taking action that breaks anything.

sloum commented

2019-09-07 14:30:10 +00:00

👍 No problem at all. You have been a big help. Do you usually use a different version control system (mercurial, bazaar, etc)?

:+1: No problem at all. You have been a big help. Do you usually use a different version control system (mercurial, bazaar, etc)?

Sign in to join this conversation.

No reviewers