sloum/bombadillo
sloum
/
bombadillo
5
27
Fork 7
Code Issues 18 Pull Requests 1 Releases 9 Activity

WIP first go at updating the readme #70

Manually merged
asdf merged 10 commits from update-readme into develop 2019-11-02 03:47:48 +00:00
Conversation 2 Commits 10 Files Changed 1 +86 -38
asdf commented 2019-11-01 02:41:48 +00:00
Collaborator
Copy Link

We've both done work on README.md and there are enough changes to warrant merging this in.

There are some parts I would like some clarification on that I'll mark for review.

We've both done work on `README.md` and there are enough changes to warrant merging this in. There are some parts I would like some clarification on that I'll mark for review.
asdf added this to the 2.0.0 milestone 2019-11-01 02:41:48 +00:00
asdf self-assigned this 2019-11-01 02:41:48 +00:00
sloum was assigned by asdf 2019-11-01 02:41:48 +00:00
asdf added the
documentation
 label 2019-11-01 02:41:48 +00:00
asdf reviewed 2019-11-01 02:43:07 +00:00
README.md Outdated
asdf commented 2019-11-01 02:43:07 +00:00
Author
Collaborator
Copy Link

Which setting can't be changed within Bombadillo?

Which setting can't be changed within Bombadillo?
asdf commented 2019-11-01 03:03:34 +00:00
Author
Collaborator
Copy Link

(I assume you can see the message I've left on line 56 asking which option cannot be set within bombadillo?)

(I assume you can see the message I've left on line 56 asking which option cannot be set within bombadillo?)
sloum reviewed 2019-11-01 03:13:55 +00:00
README.md Outdated
sloum commented 2019-11-01 03:13:55 +00:00
Owner
Copy Link

configlocation. This is due tot he fact that when bombadillo loads, it always loads the defaults first. Then checks configlocation and loads the user config. This cannot be set within bombadillo, because it will always use whatever is in the default (which can be set at compile time).

`configlocation`. This is due tot he fact that when bombadillo loads, it always loads the defaults first. Then checks `configlocation` and loads the user config. This cannot be set within bombadillo, because it will always use whatever is in the default (which can be set at compile time).
sloum approved these changes 2019-11-01 03:29:47 +00:00
sloum left a comment
Owner
Copy Link

This is really great! You have a much better way with words for stuff like this than I seem to. I'm really happy with it, in particular the section on contributions to the project.

It seems there are merge conflicts into develop, but aside from getting those solved I definitely approve this to get merged in. :)

This is really great! You have a much better way with words for stuff like this than I seem to. I'm really happy with it, in particular the section on contributions to the project. It seems there are merge conflicts into develop, but aside from getting those solved I definitely approve this to get merged in. :)
README.md Outdated
@ -4,0 +14,4 @@
* http/https
* Web support is opt-in (turned off by default)
* Links can be opened in a user's default web browser when in a graphical environment
* Web pages can be rendered directly in Bombadillo if [Lynx](https://lynx.invisible-island.net/) is installed on the system to handle the document parsing.
sloum commented 2019-11-01 03:18:33 +00:00
Owner
Copy Link

This is probably my bad, but the period should be removed from the end of this. None of the other list items end in a period.

This is probably my bad, but the period should be removed from the end of this. None of the other list items end in a period.
README.md Outdated
@ -50,1 +105,3 @@
## Contributing
- Try out the client and let us know if you have a suggestion for improvement, or if you find a bug.
- Read the documentation and let us know if something isn't well explained, or needs correction.
- Maybe you have a cool logo or some art that you think would look nice.
sloum commented 2019-11-01 03:25:24 +00:00
Owner
Copy Link

This whole list and the leadin text above is really great. Well put!

This whole list and the leadin text above is really great. Well put!
README.md Outdated
@ -52,1 +109,3 @@
Bombadillo development is largely handled by Sloum, with help from jboverf, asdf, and some community input. If you would like to get involved, please reach out or submit an issue. At present the developers use the tildegit issues system to discuss new features, track bugs, and communicate with users about hopes and/or issues for/with the software. If you have forked and would like to make a pull request, please make the pull request into `develop` where it will be reviewed by one of the maintainers. That said, a heads up or comment/issue somewhere is advised.
If you have something in mind, please reach out or [open an issue](https://tildegit.org/sloum/bombadillo/issues).
We aim for simplicity and quality, and do our best to make Bombadillo useful to its users. Any proposals for change are reviewed by the maintainers with this in mind, and not every request will be accepted. Furthermore, this software is developed in our spare time for the good of all, and help is provided as best efforts. In general, we want to help!
sloum commented 2019-11-01 03:26:07 +00:00
Owner
Copy Link

Yeah, this. Much more eloquent than what I had. Thanks!

Yeah, this. Much more eloquent than what I had. Thanks!
asdf commented 2019-11-02 03:47:37 +00:00
Author
Collaborator
Copy Link

Fixed merge conflict, made further changes to the opening paragraphs/lists, as well as the Custom Installation section.

I'm going to merge this in now, but let me know if there is something you would like changed. This can wait until just before the 2.0.0 launch.

Fixed merge conflict, made further changes to the opening paragraphs/lists, as well as the Custom Installation section. I'm going to merge this in now, but let me know if there is something you would like changed. This can wait until just before the 2.0.0 launch.
👍 1
asdf closed this pull request 2019-11-02 03:47:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Needs clarification

  
bug

Something is not working

  
build

Relating to the build process/toolchain

  
documentation

Relates to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
finger

Relates to the finger module

  
gemini

Relates to the gemini module

  
gopher

Relates to the gopher module

  
help wanted

Need some help

  
http

Relates to the http module

  
in progress

Denotes that a member of the team is actively working on this issue

  
invalid

Something is wrong

  
local

Relates to the local file module

  
needs-info

We do not have enough information for this issue

  
non-code

Does not correpond to code issue

  
non-functional

Code cleanup/refactor

  
non-urgent

Take your time

  
question

A request for comment or open question

  
release

This PR is from develop to master

  
rendering

Relates to visual output

  
suggestion

A suggestion for a feature

  
telnet

Relates to the telnet module

  
terminal

Issues with terminal handling

  
urgent

Handle ASAP

  
wontfix

This won't be fixed

No Label
blocked
bug
build
documentation
duplicate
enhancement
finger
gemini
gopher
help wanted
http
in progress
invalid
local
needs-info
non-code
non-functional
non-urgent
question
release
rendering
suggestion
telnet
terminal
urgent
wontfix
Milestone
Clear milestone
No items
No Milestone
2.0.0
Assignees
Clear assignees
No Assignees
asdf
sloum
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sloum/bombadillo#70
No description provided.
Delete Branch "update-readme"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?