sloum/bombadillo
sloum
/
bombadillo
5
27
Fork 7
Code Issues 18 Pull Requests 1 Releases 9 Activity

Adds in missing calls to draw the message #89

Manually merged
asdf merged 1 commits from fix-footbar into develop 2019-11-14 01:07:13 +00:00
Conversation 0 Commits 1 Files Changed 1 +6 -4
sloum commented 2019-11-13 05:20:03 +00:00
Owner
Copy Link

This should close issue #88 . If a command does not exist it should land at the switch's default case for the command structure type (simple command, do, doas, etc). This was happening correctly; the message was being updated. However, the calls to actually draw the message were not present (for most of the mentioned cases). I also fixed up a small related logic issue (a variable that wasnt needed was created and returned where nil could just be returned directly) and changed some error messaging to be more uniform.

This should close issue #88 . If a command does not exist it should land at the switch's default case for the command structure type (simple command, do, doas, etc). This was happening correctly; the message was being updated. However, the calls to actually draw the message were not present (for most of the mentioned cases). I also fixed up a small related logic issue (a variable that wasnt needed was created and returned where nil could just be returned directly) and changed some error messaging to be more uniform.
sloum added this to the 2.0.0 milestone 2019-11-13 05:20:03 +00:00
asdf was assigned by sloum 2019-11-13 05:20:03 +00:00
sloum added the
bug
 label 2019-11-13 05:20:03 +00:00
asdf approved these changes 2019-11-14 01:05:56 +00:00
asdf left a comment
Collaborator
Copy Link

Reviewed code and linting, tested build. Tested client, behaviour is now much nicer. Cool!

Reviewed code and linting, tested build. Tested client, behaviour is now much nicer. Cool!
asdf closed this pull request 2019-11-14 01:07:13 +00:00
asdf deleted branch fix-footbar 2019-11-14 01:07:22 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked

Needs clarification

  
bug

Something is not working

  
build

Relating to the build process/toolchain

  
documentation

Relates to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
finger

Relates to the finger module

  
gemini

Relates to the gemini module

  
gopher

Relates to the gopher module

  
help wanted

Need some help

  
http

Relates to the http module

  
in progress

Denotes that a member of the team is actively working on this issue

  
invalid

Something is wrong

  
local

Relates to the local file module

  
needs-info

We do not have enough information for this issue

  
non-code

Does not correpond to code issue

  
non-functional

Code cleanup/refactor

  
non-urgent

Take your time

  
question

A request for comment or open question

  
release

This PR is from develop to master

  
rendering

Relates to visual output

  
suggestion

A suggestion for a feature

  
telnet

Relates to the telnet module

  
terminal

Issues with terminal handling

  
urgent

Handle ASAP

  
wontfix

This won't be fixed

No Label
blocked
bug
build
documentation
duplicate
enhancement
finger
gemini
gopher
help wanted
http
in progress
invalid
local
needs-info
non-code
non-functional
non-urgent
question
release
rendering
suggestion
telnet
terminal
urgent
wontfix
Milestone
Clear milestone
No items
No Milestone
2.0.0
Assignees
Clear assignees
No Assignees
asdf
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sloum/bombadillo#89
No description provided.
Delete Branch "fix-footbar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?