solderpunk
/
AV-98
9
21
Fork 15
Code Issues 4 Pull Requests 4 Releases Wiki Activity

Pass extra information to _handle_cert_request #26

Closed
govynnus wants to merge 3 commits from govynnus/AV-98:master into master
pull from: govynnus/AV-98:master
merge into: solderpunk:master
Conversation 2 Commits 3 Files Changed 1 +29 -10
govynnus commented 2020-09-22 16:14:59 +00:00
Contributor
Copy Link

This fixes a bug introduced in f45630 when handling a certificate request was
factored out of _fetch_over_network.
Also make the options consistent in terms of grammar.

This fixes a bug introduced in f45630 when handling a certificate request was factored out of _fetch_over_network. Also make the options consistent in terms of grammar.
govynnus commented 2020-11-08 13:12:39 +00:00
Author
Contributor
Copy Link

Whoops, I added a separate commit to this same pull request.

661619 wraps headings and links if they are over the configured width. Normally long headings and links aren't an issue, but I often use AV-98 on my phone with set width 50 which leads to line breaks in the middle of words. I'm not sure about the link wrapping in all contexts (e.g. ls -l and history) - people other than me might dislike links wrapping.

Whoops, I added a separate commit to this same pull request. [661619](https://tildegit.org/solderpunk/AV-98/commit/6616194bfdd887394b86c895bf3e061a77f039f6) wraps headings and links if they are over the configured width. Normally long headings and links aren't an issue, but I often use AV-98 on my phone with `set width 50` which leads to line breaks in the middle of words. I'm not sure about the link wrapping in all contexts (e.g. `ls -l` and `history`) - people other than me might dislike links wrapping.
govynnus force-pushed master from bd526ffb51 to d3734a9a26 2021-01-03 11:21:21 +00:00 Compare
govynnus commented 2021-01-03 11:25:44 +00:00
Author
Contributor
Copy Link

This is getting a bit confusing with different commits so I'm going to close it and try do something with branches.

This is getting a bit confusing with different commits so I'm going to close it and try do something with branches.
govynnus closed this pull request 2021-01-03 11:25:45 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: solderpunk/AV-98#26
No description provided.
Delete Branch "govynnus/AV-98:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?