solene
/
openbsd-webzine
6
0
Fork 8
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

converts ISO-8601 metadata.sh date to human readable #18

Closed
prx wants to merge 0 commits from date_on_each_issue into main
pull from: date_on_each_issue
merge into: solene:main
Conversation 4 Commits - Files Changed -
prx commented 2021-10-02 14:14:27 +00:00
Collaborator
Copy Link

of course, PUBLISHED_DATE for issue-2 should be modified when necessary.

of course, PUBLISHED_DATE for issue-2 should be modified when necessary.
prx added 1 commit 2021-10-02 14:14:27 +00:00
solene commented 2021-10-02 15:01:00 +00:00
Owner
Copy Link

Doesn't this prevent "make test" and "make testsite" to work if the date is wrong?

Doesn't this prevent "make test" and "make testsite" to work if the date is wrong?
prx commented 2021-10-02 15:16:08 +00:00
Author
Collaborator
Copy Link

what do you mean by "if the date is wrong" ?
The date in metadata.sh ?

what do you mean by "if the date is wrong" ? The date in metadata.sh ?
solene commented 2021-10-02 15:32:11 +00:00
Owner
Copy Link

what do you mean by "if the date is wrong" ?
The date in metadata.sh ?

Yes, for example if you copy _template as a new issue, make test will fail with a weird error because the default metadata.sh has an invalid value. https://tildegit.org/solene/openbsd-webzine/src/branch/main/issues/_template/metadata.sh

I'd advise trying to convert the date and catch an error done by date if any to display a proper error message

> what do you mean by "if the date is wrong" ? > The date in metadata.sh ? Yes, for example if you copy `_template` as a new issue, `make test` will fail with a weird error because the default `metadata.sh` has an invalid value. https://tildegit.org/solene/openbsd-webzine/src/branch/main/issues/_template/metadata.sh I'd advise trying to convert the date and catch an error done by date if any to display a proper error message
prx added 1 commit 2021-10-02 15:40:10 +00:00
prx commented 2021-10-02 15:41:04 +00:00
Author
Collaborator
Copy Link

done.
What do you think?

done. What do you think?
prx added 1 commit 2021-10-02 19:05:29 +00:00
prx added 1 commit 2021-10-02 19:07:57 +00:00
prx closed this pull request 2021-10-02 19:13:14 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
Easy

This is easy to do

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
Easy
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: solene/openbsd-webzine#18
No description provided.
Delete Branch "date_on_each_issue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?