working bash version #1

ben · 2018-09-20T16:49:50Z

ben commented

2018-09-20 16:49:50 +00:00

i'm open to discussion on this but it's super simple to do in bash.

i wasn't keen to handle a bunch of subprocesses in python.

i'm open to discussion on this but it's super simple to do in bash. i wasn't keen to handle a bunch of subprocesses in python.

khuxkm commented

2018-09-21 13:43:35 +00:00

I have 2 main issues with this.

I don't agree with GPL licensing, seeing as how any edits to this would be trivial. (change name, change what email is used for the sudoers, etc.)
You spend about 87% of the script just making error handlers, taking care of input, etc.
(I'm counting lines 92-107 as the ones that actually do what the script is intended for.) My Python script I'm writing, on the other hand, takes 6 lines (1 import, 1 init, 3 argument additions, and 1 parse call) for the error handling, allowing me to get to work much faster and leaving not a lot of clutter. That's why I wanted it in Python: Batteries included make it easier and more clear what's happening.

Also, we don't need to deal with a lot of subprocesses. Password generation can be done in-script, crypting the password can be done in-script. The only subprocesses are 1) add user, 2) add SSH key, and 3) send toot, all of which are trivial.

I have 2 main issues with this. 1. I don't agree with GPL licensing, seeing as how any edits to this would be trivial. (change name, change what email is used for the sudoers, etc.) 2. You spend about 87% of the script just making error handlers, taking care of input, etc. ([I'm counting lines 92-107 as the ones that actually do what the script is intended for.](https://tildegit.org/team/makeuser/src/commit/abaff4c37df37eab60a24b6db749630b80e05beb/makeuser#L83-L112)) My Python script I'm writing, on the other hand, takes 6 lines (1 import, 1 init, 3 argument additions, and 1 parse call) for the error handling, allowing me to get to work much faster and leaving not a lot of clutter. That's why I wanted it in Python: Batteries included make it easier and more clear what's happening. Also, we don't need to deal with a lot of subprocesses. Password generation can be done in-script, `crypt`ing the password can be done in-script. The only subprocesses are 1) add user, 2) add SSH key, and 3) send toot, all of which are trivial.

ben commented

2018-09-21 13:50:12 +00:00

what's wrong with a gpl license?

khuxkm commented

2018-09-21 13:51:41 +00:00

why require people to share their changes if nobody's going to change it massively? it works already, someone might do rebranding I guess. there's no real need.

ben commented

2018-09-21 13:53:01 +00:00

what license would you prefer?

I just used a script template (new_script iirc) and it handled all the boilerplate for me. it can definitely be tidied up.

python still seems like a lot of overhead to me.

what license would you prefer? I just used a script template (new_script iirc) and it handled all the boilerplate for me. it can definitely be tidied up. python still seems like a lot of overhead to me.

khuxkm commented

2018-09-21 14:00:11 +00:00

I prefer the MIT license, the one that I put on the repo when I made it.