team/site
team
/
site
7
17
Fork 56
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Style <select> tag #22

Merged
khuxkm merged 2 commits from style-select-dropdowns into master 2018-12-13 14:28:13 +00:00
Conversation 4 Commits 2 Files Changed 4 +169 -164
khuxkm commented 2018-11-24 13:18:58 +00:00
Owner
Copy Link

In current software:

Before this PR

With this PR:

After this PR

(take my word for it, dracula's even worse)

In current software: ![Before this PR](https://ttm.sh/iM.png) With this PR: ![After this PR](https://ttm.sh/iX.png) (take my word for it, dracula's even worse)
ben commented 2018-11-24 18:50:23 +00:00
Owner
Copy Link

did you add the form-control class to that select tag?

did you add the form-control class to that select tag?
ben commented 2018-11-24 19:34:33 +00:00
Owner
Copy Link

this is a non-issue. it's styled correctly if you use the form-control class. use the bootstrap docs for a reference: https://getbootstrap.com/docs/3.3/

this is a non-issue. it's styled correctly if you use the `form-control` class. use the bootstrap docs for a reference: https://getbootstrap.com/docs/3.3/
khuxkm commented 2018-11-25 14:52:09 +00:00
Author
Owner
Copy Link

I prefer this solution as I don't think the select needs to span the entire screen. :P

I prefer this solution as I don't think the select needs to span the entire screen. :P
ben commented 2018-11-25 16:28:44 +00:00
Owner
Copy Link

ok! feel free to merge. I was just making sure you were aware of the reason that it was working the way it did.

ok! feel free to merge. I was just making sure you were aware of the reason that it was working the way it did.
khuxkm changed title from WIP: Style <select> tag to Style <select> tag 2018-11-29 14:51:49 +00:00
khuxkm closed this pull request 2018-12-13 14:28:13 +00:00
khuxkm deleted branch style-select-dropdowns 2018-12-13 14:28:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: team/site#22
No description provided.
Delete Branch "style-select-dropdowns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?