team/site
team
/
site
7
17
Fork 56
Code Issues 2 Pull Requests 1 Releases Wiki Activity

Some tweaks I'm porting over from am32.org #80

Merged
ben merged 4 commits from :master into master 2021-01-03 23:45:00 +00:00
Conversation 0 Commits 4 Files Changed 7 +20 -3
anton commented 2020-12-30 17:07:05 +00:00
Contributor
Copy Link
No description provided.
anton added 3 commits 2020-12-30 17:07:16 +00:00
continuous-integration/drone/pr Build encountered an error Details
72c58e972e Fix
xfnw approved these changes 2020-12-30 17:11:58 +00:00
xfnw left a comment
Contributor
Copy Link

hmm cool, nice footer source urls

hmm cool, nice footer source urls
ben reviewed 2020-12-31 01:50:54 +00:00
index.php
@ -1,4 +1,6 @@
<?php
$path = new SplFileInfo(__FILE__);
$filepath = $path->getRealPath();
ben commented 2020-12-31 01:48:29 +00:00
Owner
Copy Link

__FILE__ should have the same contents here, is there a difference with the getRealPath() method?

`__FILE__` should have the same contents here, is there a difference with the getRealPath() method?
ben commented 2020-12-31 19:39:12 +00:00
Owner
Copy Link

looks like you can use realpath(__FILE__) to avoid instantiating another object but just __FILE__ would probably be fine

looks like you can use [`realpath(__FILE__)`](http://php.net/realpath) to avoid instantiating another object but just `__FILE__` would probably be fine
index.php Outdated
@ -75,3 +77,2 @@
<em>
<a href="/news/<?=basename($page, ".md")?>">
<?=$yaml["date"]?></a> - <a href="/~<?=$yaml["author"]?>/"><?=$yaml["author"]?></a>
<?=$yaml["date"]?>
ben commented 2020-12-31 01:50:36 +00:00
Owner
Copy Link

i think i prefer having the link on the date instead of the name. i guess it's just a preference thing

i think i prefer having the link on the date instead of the name. i guess it's just a preference thing
anton added 1 commit 2020-12-31 16:26:45 +00:00
continuous-integration/drone/pr Build encountered an error Details
6322781bf6 Put link back around date
ben merged commit a712e41cd8 into master 2021-01-03 23:45:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
xfnw
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: team/site#80
No description provided.
Delete Branch ":master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?