tidy up code in counter
This commit is contained in:
parent
b5a9ec9998
commit
fc203d55bd
|
@ -73,8 +73,7 @@ header("Cache-Control: post-check=0, pre-check=0", false);
|
|||
header("Pragma: no-cache");
|
||||
|
||||
// Is page ID set?
|
||||
if ( ! isset($_GET['page']) )
|
||||
{
|
||||
if (!isset($_GET['page'])) {
|
||||
die('ERROR: The gcount.php file must be called with a <b>?page=PAGEID</b> parameter, for example <b>gcount.php?page=test</b>');
|
||||
}
|
||||
|
||||
|
@ -82,14 +81,18 @@ if ( ! isset($_GET['page']) )
|
|||
$page = preg_replace('/[^a-zA-Z0-9\-_\.]/', '', $_GET['page']);
|
||||
|
||||
// Stop if $page is not valid
|
||||
if ( ! strlen($page) )
|
||||
{
|
||||
if (!strlen($page)) {
|
||||
die('ERROR: Page ID is missing or contains only invalid chars. Please use only these chars for the page ID: a-z, A-Z, 0-9, ".", "-" and "_"');
|
||||
}
|
||||
|
||||
// Get style and extension information
|
||||
$style = isset($_GET['style']) ? preg_replace('/[^a-zA-Z0-9\-_\.]/','',$_GET['style']) : $default_style;
|
||||
$ext = isset($_GET['ext']) ? preg_replace('/[^a-zA-Z0-9\-_\.]/','',$_GET['ext']) : $default_ext;
|
||||
$style = isset($_GET['style'])
|
||||
? preg_replace('/[^a-zA-Z0-9\-_\.]/', '', $_GET['style'])
|
||||
: $default_style;
|
||||
|
||||
$ext = isset($_GET['ext'])
|
||||
? preg_replace('/[^a-zA-Z0-9\-_\.]/', '', $_GET['ext'])
|
||||
: $default_ext;
|
||||
|
||||
// Set values for cookie, log file and style flye names
|
||||
$cname = 'gcount_unique_'.$page;
|
||||
|
@ -97,26 +100,22 @@ $logfile = 'logs/' . $page . '.txt';
|
|||
$style_dir = 'styles/' . $style . '/';
|
||||
|
||||
// Does the log file exist?
|
||||
if ( ! file_exists($logfile) )
|
||||
{
|
||||
if (!file_exists($logfile)) {
|
||||
die('ERROR: Log file not found. Make sure there is a file called <b>' . $page . '.txt</b> inside your <b>logs</b> folder. On most servers file names are CaSe SeNSiTiVe!');
|
||||
}
|
||||
|
||||
// Open log file for reading and writing
|
||||
if ($fp = @fopen($logfile, 'r+'))
|
||||
{
|
||||
if ($fp = @fopen($logfile, 'r+')) {
|
||||
// Lock log file from other scripts
|
||||
$locked = flock($fp, LOCK_EX);
|
||||
|
||||
// Lock successful?
|
||||
if ($locked)
|
||||
{
|
||||
if ($locked) {
|
||||
// Let's read current count
|
||||
$count = intval(trim(fread($fp, filesize($logfile))));
|
||||
|
||||
// If counting unique hits is enabled make sure it's a unique hit
|
||||
if ( $count_unique == 0 || ! isset($_COOKIE[$cname]) )
|
||||
{
|
||||
if ($count_unique == 0 || ! isset($_COOKIE[$cname])) {
|
||||
// Update count by 1 and write the new value to the log file
|
||||
$count = $count + 1;
|
||||
rewind($fp);
|
||||
|
@ -127,8 +126,7 @@ if ($fp = @fopen($logfile, 'r+'))
|
|||
setcookie($cname, 1, time()+60*60*$unique_hours);
|
||||
}
|
||||
}
|
||||
else
|
||||
{
|
||||
else {
|
||||
// Lock not successful. Better to ignore than to damage the log file
|
||||
$count = 1;
|
||||
}
|
||||
|
@ -137,23 +135,22 @@ if ($fp = @fopen($logfile, 'r+'))
|
|||
flock($fp, LOCK_UN);
|
||||
fclose($fp);
|
||||
}
|
||||
else
|
||||
{
|
||||
else {
|
||||
die("ERROR: Can't read/write to the log file ($logfile). Make sure this file is writable by PHP scripts. On UNIX servers, CHMOD the log file to 666 (rw-rw-rw-).");
|
||||
}
|
||||
|
||||
// Is zero-padding enabled? If yes, add zeros if required
|
||||
if ($min_digits)
|
||||
{
|
||||
if ($min_digits) {
|
||||
$count = sprintf('%0' . $min_digits . 's', $count);
|
||||
}
|
||||
|
||||
// Print out Javascript code and exit
|
||||
$len = strlen($count);
|
||||
for ($i=0; $i<$len; $i++)
|
||||
{
|
||||
echo 'document.write(\'<img src="'.$base_url . $style_dir . substr($count,$i,1) . '.' . $ext .'" border="0" />\');';
|
||||
for ($i = 0; $i < $len; $i++) {
|
||||
$url = $base_url . $style_dir . substr($count, $i, 1) . '.' . $ext;
|
||||
echo 'document.write(\'<img src="'. $url .'" border="0" />\');';
|
||||
}
|
||||
|
||||
exit();
|
||||
?>
|
||||
|
||||
|
|
|
@ -1 +1 @@
|
|||
303
|
||||
333
|
Loading…
Reference in New Issue