Some application and post changes #20

Merged
ubergeek merged 6 commits from anton/journal:master into master 8 months ago
anton commented 8 months ago
  • Changes "author" to "author-name"
  • Add "author-link"
  • Add ability to specify "original" post
- Changes "author" to "author-name" - Add "author-link" - Add ability to specify "original" post
anton added 1 commit 8 months ago
3ba92adaf4
Some application and post changes
Poster

Would it be better to send this as an email instead? I perfer git email anyways.

Would it be better to send this as an email instead? I perfer git email anyways.
anton added 1 commit 8 months ago
6cc162582a
Remove from public site
tomasino requested changes 8 months ago
tomasino left a comment

There's a few inconsistencies in the code and opportunities for a bit of error checking. Otherwise looks good.

There's a few inconsistencies in the code and opportunities for a bit of error checking. Otherwise looks good.
</h1>
<p>author: <?=$author?></p>
<p>author: <a href="<?=$author_link?>"><?=$author_name?></a></p>

There's a possibility of $author_name without $author_link, right? There's also a possibility a user might have a link and no name due to yaml misconfiguration. This might need a bit more logic to stay flexible to the yaml possibilities.

There's a possibility of $author_name without $author_link, right? There's also a possibility a user might have a link and no name due to yaml misconfiguration. This might need a bit more logic to stay flexible to the yaml possibilities.
<p>author: <a href="<?=$author_link?>"><?=$author_name?></a></p>
<p>date: <?=$yml["date"]?></p>
<br />
<?php if ($yml["original"]): ?>

Should probably use the $original_link variable for testing here since you alreday grabbed it clean of special characters above. It would align with the $author_link test just above.

Should probably use the $original_link variable for testing here since you alreday grabbed it clean of special characters above. It would align with the $author_link test just above.
---
title: "hello"
author: "Ben Harris"

You forgot to change author to author-name in the sample.

You forgot to change author to author-name in the sample.

With the latest commit, this is essentially reopening #19, which you have already been told not to.

With the latest commit, this is essentially reopening https://tildegit.org/tildeverse/journal/pulls/19, which you have already been told not to.

With the latest commit, this is essentially reopening #19, which you have already been told not to.

I disagree with the outcome of 19. The terms of CC SA state "Of course, you may choose to respect the licensor’s wishes and stop using the work." While we can't retroactively remove the posts from people who have forked the journal, we could certainly do so here.

> With the latest commit, this is essentially reopening https://tildegit.org/tildeverse/journal/pulls/19, which you have already been told not to. I disagree with the outcome of 19. The terms of CC SA state "Of course, you may choose to respect the licensor’s wishes and stop using the work." While we can't retroactively remove the posts from people who have forked the journal, we could certainly do so here.
Owner

And as per PR 19, We do not "choose" to. He flip flops constantly on content he has "contributed". Its a waste of our time. If he really wants it removed then so be it. But he will no longer be able to contribute to any tildeverse repos afterwards as it always ends up being a headache for everyone.

And as per PR 19, We do not "choose" to. He flip flops constantly on content he has "contributed". Its a waste of our time. If he really wants it removed then so be it. But he will no longer be able to contribute to any tildeverse repos afterwards as it always ends up being a headache for everyone.
anton added 3 commits 8 months ago
anton requested review from tomasino 8 months ago
anton added 1 commit 8 months ago
tomasino approved these changes 8 months ago
ubergeek merged commit 82a598b6e7 into master 8 months ago

Reviewers

tomasino approved these changes 8 months ago
continuous-integration/drone/pr Build encountered an error
The pull request has been merged as 82a598b6e7.
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: tildeverse/journal#20
Loading…
There is no content yet.