Some application and post changes #20
Loading…
Reference in New Issue
No description provided.
Delete Branch "anton/journal:master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Would it be better to send this as an email instead? I perfer git email anyways.
There's a few inconsistencies in the code and opportunities for a bit of error checking. Otherwise looks good.
@ -34,3 +36,3 @@
</h1>
<p>author: <?=$author?></p>
<p>author: <a href="<?=$author_link?>"><?=$author_name?></a></p>
There's a possibility of $author_name without $author_link, right? There's also a possibility a user might have a link and no name due to yaml misconfiguration. This might need a bit more logic to stay flexible to the yaml possibilities.
@ -37,2 +38,4 @@
<p>author: <a href="<?=$author_link?>"><?=$author_name?></a></p>
<p>date: <?=$yml["date"]?></p>
<br />
<?php if ($yml["original"]): ?>
Should probably use the $original_link variable for testing here since you alreday grabbed it clean of special characters above. It would align with the $author_link test just above.
@ -1,6 +1,7 @@
---
title: "hello"
author: "Ben Harris"
You forgot to change author to author-name in the sample.
With the latest commit, this is essentially reopening #19, which you have already been told not to.
I disagree with the outcome of 19. The terms of CC SA state "Of course, you may choose to respect the licensor’s wishes and stop using the work." While we can't retroactively remove the posts from people who have forked the journal, we could certainly do so here.
And as per PR 19, We do not "choose" to. He flip flops constantly on content he has "contributed". Its a waste of our time. If he really wants it removed then so be it. But he will no longer be able to contribute to any tildeverse repos afterwards as it always ends up being a headache for everyone.