housekeeping
If you don't want color in rspec output, you can add it to your ~/.rspec.
This commit is contained in:
parent
60c7a9cc3a
commit
6c7f6677ba
|
@ -1,4 +0,0 @@
|
||||||
<!--
|
|
||||||
Feature requests are no longer being accepted, unless in the form of a pull request with code.
|
|
||||||
-->
|
|
||||||
|
|
|
@ -0,0 +1,7 @@
|
||||||
|
<!--
|
||||||
|
Feature requests are no longer being accepted, unless in the form of a pull request with code.
|
||||||
|
Don't be fooled by the feature requests pushcx posts to share plans and invite contributions.
|
||||||
|
|
||||||
|
Issues and PRs are typically reviewed Wednesday and some Thursday mornings.
|
||||||
|
-->
|
||||||
|
|
|
@ -0,0 +1,3 @@
|
||||||
|
<!--
|
||||||
|
Issues and PRs are typically reviewed Wednesday and some Thursday mornings.
|
||||||
|
-->
|
|
@ -27,7 +27,7 @@ to avoid wasted efforts.
|
||||||
|
|
||||||
* (Optional) Create a branch to house your changes.
|
* (Optional) Create a branch to house your changes.
|
||||||
|
|
||||||
* Wrap code at 80 characters with 2-space soft tabs for Ruby code. For other
|
* Run `bundle exec rubocop` to check the style of your Ruby. For other
|
||||||
languages, use the existing style of the files being edited. 3rd party,
|
languages, use the existing style of the files being edited. 3rd party,
|
||||||
externally-maintained code such as Javascript libraries can remain in their
|
externally-maintained code such as Javascript libraries can remain in their
|
||||||
own style.
|
own style.
|
||||||
|
@ -42,8 +42,8 @@ present-tense explanation of the change. Wrap all lines at 80 characters.
|
||||||
* If applicable, add tests for your changes. Not all changes require tests,
|
* If applicable, add tests for your changes. Not all changes require tests,
|
||||||
and tests should not be added just for the sake of code coverage.
|
and tests should not be added just for the sake of code coverage.
|
||||||
|
|
||||||
* Run _all_ tests (with `rake` in the root directory) to ensure nothing has
|
* Run _all_ tests (with `bundle exec rspec` in the root directory) to ensure
|
||||||
been broken by your changes.
|
nothing has been broken by your changes.
|
||||||
|
|
||||||
### Submitting Changes
|
### Submitting Changes
|
||||||
|
|
||||||
|
|
|
@ -19,8 +19,9 @@ file.
|
||||||
|
|
||||||
#### Initial setup
|
#### Initial setup
|
||||||
|
|
||||||
Use the steps below for a local install or consider the external
|
Use the steps below for a local install or
|
||||||
project [docker-lobsters](https://github.com/jamesbrink/docker-lobsters).
|
[lobsters-ansible](https://github.com/lobsters/lobsters-ansible) for our production deployment config.
|
||||||
|
There's an external project [docker-lobsters](https://github.com/jamesbrink/docker-lobsters) if you want to use Docker.
|
||||||
|
|
||||||
* Install Ruby 2.3.
|
* Install Ruby 2.3.
|
||||||
|
|
||||||
|
|
|
@ -75,12 +75,18 @@ describe Story do
|
||||||
end
|
end
|
||||||
|
|
||||||
it "parses domain properly" do
|
it "parses domain properly" do
|
||||||
expect(Story.new(url: "http://example.com").domain).to eq("example.com")
|
story = Story.new
|
||||||
expect(Story.new(url: "https://example.com").domain).to eq("example.com")
|
{
|
||||||
expect(Story.new(url: "http://example.com:8000").domain).to eq("example.com")
|
"http://example.com": "example.com",
|
||||||
expect(Story.new(url: "http://example.com:8000/").domain).to eq("example.com")
|
"https://example.com": "example.com",
|
||||||
expect(Story.new(url: "http://www3.example.com/goose").domain).to eq("example.com")
|
"http://example.com:8000": "example.com",
|
||||||
expect(Story.new(url: "http://flub.example.com").domain).to eq("flub.example.com")
|
"http://example.com:8000/": "example.com",
|
||||||
|
"http://www3.example.com/goose": "example.com",
|
||||||
|
"http://flub.example.com": "flub.example.com",
|
||||||
|
}.each_pair do |url, domain|
|
||||||
|
story.url = url
|
||||||
|
expect(story.domain).to eq(domain)
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
it "converts a title to a url properly" do
|
it "converts a title to a url properly" do
|
||||||
|
|
Loading…
Reference in New Issue