Commit Graph

1216 Commits

Author SHA1 Message Date
dependabot[bot] 8062d62cb6
Bump mysql2 from 0.4.10 to 0.5.0
Bumps [mysql2](https://github.com/brianmario/mysql2) from 0.4.10 to 0.5.0.
- [Release notes](https://github.com/brianmario/mysql2/releases)
- [Changelog](https://github.com/brianmario/mysql2/blob/master/CHANGELOG.md)
- [Commits](https://github.com/brianmario/mysql2/compare/0.4.10...0.5.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-03-21 18:54:32 +00:00
Peter Bhat Harkins 55da55cb9e fix mysql/AR version incompatibility 2018-03-21 13:53:38 -05:00
Peter Bhat Harkins 069a2e3b11 don't give author bump without an author link 2018-03-21 13:48:37 -05:00
Andrew Shu 7d0135ea16 comments: fix tree lines on edit 2018-03-21 13:48:29 -05:00
Grey Baker 3cc57b786c Update dependencies
* Bump rspec-rails from 3.6.0 to 3.7.2

Bumps [rspec-rails](https://github.com/rspec/rspec-rails) from 3.6.0 to 3.7.2.
- [Changelog](https://github.com/rspec/rspec-rails/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-rails/compare/v3.6.0...v3.7.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump activerecord-typedstore from 1.1.1 to 1.1.3

Bumps [activerecord-typedstore](https://github.com/byroot/activerecord-typedstore) from 1.1.1 to 1.1.3.
- [Commits](https://github.com/byroot/activerecord-typedstore/compare/v1.1.1...v1.1.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump nokogiri from 1.8.1 to 1.8.2

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.8.1 to 1.8.2.
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.8.1...v1.8.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump scenic from 1.4.0 to 1.4.1

Bumps [scenic](https://github.com/thoughtbot/scenic) from 1.4.0 to 1.4.1.
- [Changelog](https://github.com/thoughtbot/scenic/blob/master/NEWS.md)
- [Commits](https://github.com/thoughtbot/scenic/compare/v1.4.0...v1.4.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump exception_notification from 4.2.1 to 4.2.2

Bumps [exception_notification](https://github.com/smartinez87/exception_notification) from 4.2.1 to 4.2.2.
- [Changelog](https://github.com/smartinez87/exception_notification/blob/master/CHANGELOG.rdoc)
- [Commits](https://github.com/smartinez87/exception_notification/compare/v4.2.1...v4.2.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump oauth from 0.5.3 to 0.5.4

Bumps oauth from 0.5.3 to 0.5.4.

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump uglifier from 3.2.0 to 4.1.7

Bumps [uglifier](https://github.com/lautis/uglifier) from 3.2.0 to 4.1.7.
- [Changelog](https://github.com/lautis/uglifier/blob/master/CHANGELOG.md)
- [Commits](https://github.com/lautis/uglifier/compare/v3.2.0...v4.1.7)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump rotp from 3.3.0 to 3.3.1

Bumps [rotp](https://github.com/mdp/rotp) from 3.3.0 to 3.3.1.
- [Changelog](https://github.com/mdp/rotp/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mdp/rotp/commits)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump rails from 5.1.1 to 5.1.5

Bumps [rails](https://github.com/rails/rails) from 5.1.1 to 5.1.5.
- [Commits](https://github.com/rails/rails/compare/v5.1.1...v5.1.5)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump faker from 1.7.3 to 1.8.7

Bumps [faker](https://github.com/stympy/faker) from 1.7.3 to 1.8.7.
- [Changelog](https://github.com/stympy/faker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/stympy/faker/compare/v1.7.3...v1.8.7)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump unicorn from 5.3.0 to 5.4.0

Bumps [unicorn](https://bogomips.org/unicorn/) from 5.3.0 to 5.4.0.

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump mysql2 from 0.4.6 to 0.4.10

Bumps [mysql2](https://github.com/brianmario/mysql2) from 0.4.6 to 0.4.10.
- [Release notes](https://github.com/brianmario/mysql2/releases)
- [Changelog](https://github.com/brianmario/mysql2/blob/master/CHANGELOG.md)
- [Commits](https://github.com/brianmario/mysql2/compare/0.4.6...0.4.10)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-03-21 13:43:51 -05:00
Peter Bhat Harkins de21d1cc44 help for search features 2018-03-13 15:45:42 -06:00
Michael Williams d64700a9c1 add tag scoped search 2018-03-13 11:55:11 -06:00
Peter Bhat Harkins bb65fddd2a ignore an intermittent twitter bug
Related to #459
2018-02-26 13:34:30 -06:00
Peter Bhat Harkins a1486f8ce6 there are lobsters rarer than blue 2018-02-21 09:43:33 -06:00
Peter Bhat Harkins 06d5736aa0 allow mods to post quickly; useful for polls 2018-02-20 14:39:59 -06:00
Peter Bhat Harkins 05c613d356 don't undelete deleted comments when user is undeleted
I don't think User#undelete has been called in prod, but comments are no
longer all deleted when a user is and anyway this would undelete comments that
the user had manually deleted prior to account deletion, and undelete comments
that moderators had deleted.
2018-02-12 11:39:54 -06:00
Peter Bhat Harkins b7132cb953 friendlier error 2018-02-11 10:27:24 -06:00
Peter Bhat Harkins 2a17e10c67 help on replies pages 2018-02-09 19:52:35 -06:00
Peter Bhat Harkins 76fc3699de lower minimum comment score
Comments still collapse at -5 and can now hit -10. Lately the few heavily
downvoted comments bounce between -5 and -4, closed and open, because they
can't be downvoted further. If they're going to catch 10+ downvotes anyways,
I'd rather they do it a little sooner and more stably.
2018-02-09 09:36:16 -06:00
Andrew Shu f39ad5a09d fix create_view in schema.rb
Scenic created this with the name of the prod database and broke Travis.
2018-02-09 08:46:08 -06:00
Peter Bhat Harkins 33b333c7ed note to rm blog/author from titles 2018-02-07 18:39:54 -06:00
Peter Bhat Harkins a82888101c ban link shorteners and other ad tracking domains
Someone couldn't take the hint that Lobsters strips utm_ tracking parameters
from URLs. Maybe this will be clear.
2018-02-01 20:11:25 -06:00
Peter Bhat Harkins 1824fffe65 style delete button 2018-02-01 13:14:27 -06:00
Peter Bhat Harkins 640f2cdca1 respect comment deletion/moderation 2018-02-01 12:48:10 -06:00
Peter Bhat Harkins 0b55676299 fix sql join of user's votes
An inner join only returns the comments the user has voted on (not useful for
the Unread page in particular). A left join on comment_id or user_id returns
duplicate rows (any 'outer apply' is nonstandard). So this just subselects it.
2018-02-01 11:58:29 -06:00
Peter Bhat Harkins b220c0d463 edit migration
See #416. Newer/differently configured versions of MySQL set a 'strict mode'
flag prevening this migration from running at all.
https://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-strict
2018-01-31 22:25:25 -06:00
Peter Bhat Harkins b9efe88dec vote reason fix 2018-01-31 22:13:10 -06:00
Peter Bhat Harkins 6b893a5282 cast null/nil 2018-01-31 21:43:25 -06:00
Peter Bhat Harkins c9168f0f89 display votes on replies pages 2018-01-31 21:13:16 -06:00
Peter Bhat Harkins bf46bcaaac rm accidentally committed announce post 2018-01-31 20:40:40 -06:00
Peter Bhat Harkins 826c88f157 fix mysql '0000-00-00 00:00:00' default on hats.doffed_at
Fixes #451
2018-01-31 15:49:02 -06:00
Peter Bhat Harkins 9655df14a9 link to Unread when there are replies; use url building 2018-01-31 14:18:01 -06:00
Peter Bhat Harkins c2e8074c0c fix hiding
Users can hide Stories without visiting their comments pages and creating a
ReadRibbon. Rather than skip hide_replies_for, this creates a ribbon so that
they don't get one with is_following defaulted to true should they follow a
direct link in to the story from somewhere.
2018-01-31 13:12:29 -06:00
Peter Bhat Harkins c555fc83c0 tone down unread brightness to standard red 2018-01-31 12:45:19 -06:00
Peter Bhat Harkins c1c38bedf1 avoid extra query
This controller needs some tidying around loading @story, which is done in
several places and doesn't preload tags on show. The voting endpoints should
also be moved off into their own controller.
2018-01-31 11:49:19 -06:00
Peter Bhat Harkins fc82a65e77 unbreak story loading for logged-out users 2018-01-31 11:40:29 -06:00
Peter Bhat Harkins 66c57c6fdf create ReadRibbon on Story creation 2018-01-31 11:14:39 -06:00
Peter Bhat Harkins 694b6cbc91 fix replies to stories 2018-01-31 11:07:53 -06:00
Peter Bhat Harkins 76811f304d preload comment info for 1 + n query problem 2018-01-31 10:44:31 -06:00
Peter Bhat Harkins 804abf71a5 flip boolean 2018-01-31 10:39:56 -06:00
Peter Bhat Harkins 19a6e330d1 move replies filters to url path; remove 1 + n on unread tracking 2018-01-31 08:21:11 -06:00
Peter Bhat Harkins 3f17043e2e tidy whitespace; prod charset to schema 2018-01-31 07:56:15 -06:00
Peter Bhat Harkins 13a0aad1f8 .touch idiom, don't fetch story twice 2018-01-31 07:46:27 -06:00
Hunter Madison dd42cca880 Show story and comment replies, tracking unread ones 2018-01-31 07:43:07 -06:00
Peter Bhat Harkins 925bdc203c Don't serve commenting js to visitors who aren't logged in
Fix #447
2018-01-30 09:28:09 -06:00
avinassh 4603caed39 Make SMTP settings configurable from the env 2018-01-30 08:23:51 -06:00
mftaff b12e3e908f Use parameterize in title_as_url
Use the Rails feature for this cleanup to catch more corner cases.

Fixes #419
2018-01-30 08:14:20 -06:00
Joe Rafaniello 14a8b03f86 Workaround Ruby memory leak with pathnames in load path
Workaround a small Ruby 2.3/2.4 bug.

https://bugs.ruby-lang.org/issues/14372
2018-01-30 08:04:44 -06:00
Andrew Shu 49b8dd1116 comments: update parent tree line on reply
Fixes #443
2018-01-29 17:10:06 -06:00
Peter Bhat Harkins f9c4fdcf16 typo fix 2018-01-29 14:12:57 -06:00
Peter Bhat Harkins 0a69f512c6 might as well update this display 2018-01-29 13:10:29 -06:00
Peter Bhat Harkins 27febc315e Allow deleting users to disown their comments 2018-01-29 13:03:45 -06:00
Peter Bhat Harkins 6810e23854 Only delete negative-score stories on ban 2018-01-29 11:05:29 -06:00
Peter Bhat Harkins e916389a7f Only delete negative-score comments when user is deactivated
Helps keep discussions from turning into swiss cheese.
2018-01-29 10:55:06 -06:00
Peter Bhat Harkins a8415a675c bump nokogiri for security fix 2018-01-25 18:42:52 -06:00