Commit Graph

12 Commits

Author SHA1 Message Date
Peter Bhat Harkins b3d6903f05 standardrb: standard-rails 2023-09-14 08:45:21 -05:00
Peter Bhat Harkins c3f8625788 standardrb
I can't take Rubocop any more. Moving up to Ruby 3 forces us to update RuboCop,
and it comes with dozens of linters that I'd have to evaluate, none of which is
a marginal improvement. I'm done having opinions.
2023-09-08 15:39:50 -05:00
Thomas Dziedzic c6d27f3914 fix StderrPuts rubocop warnings
```
script/parse_inbound_mail:27:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
  STDERR.puts "no active user with mailing list token #{parser.user_token}"
  ^^^^^^^^^^^
script/parse_inbound_mail:34:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
  STDERR.puts "error parsing e-mail"
  ^^^^^^^^^^^
script/parse_inbound_mail:38:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
  STDERR.puts "no valid comment or story being replied to"
  ^^^^^^^^^^^
script/parse_inbound_mail:42:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
  STDERR.puts "no valid text/plain body found"
  ^^^^^^^^^^^
script/parse_inbound_mail:61:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
  STDERR.puts c.errors.inspect
  ^^^^^^^^^^^
script/sync_twitter_users:29:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
  STDERR.puts "need to implement paging for list members"
  ^^^^^^^^^^^
```
2019-06-13 09:00:21 -05:00
Peter Bhat Harkins 5ac4c48223 rubocop: Lint/UselessAssignment, 685 2018-03-17 14:07:26 -05:00
Peter Bhat Harkins a15c5d540e rubocop: Metrics/*, 655
Turned off everything but LineLength, which I bumped to 100 and manually
tidied.
2018-03-17 14:05:46 -05:00
joshua stein b75468a2c9 move inbound e-mail parsing guts into an extra, add tests for it 2014-02-03 19:06:20 -06:00
joshua stein 3241f34f75 don't interact with inactive users 2014-01-14 11:39:56 -06:00
joshua stein 9b5ab9b978 try really hard to convert inbound mail to utf8 2014-01-07 11:42:21 -06:00
joshua stein e63e45af2b record and show which comments were posted by e-mail, for no particular reason 2013-12-28 12:00:29 -06:00
Serge Paquet 8fbf76b484 use activerecord query interface instead of deprecated finder methods 2013-12-25 16:43:50 -05:00
joshua stein a471eb180a don't hardcode "Lobsters" and "lobste.rs" everywhere, use Rails.application.{name,domain} 2013-06-30 01:50:23 -05:00
joshua stein fd41bfa566 start on mailing list interface 2013-06-30 00:54:02 -05:00