Commit Graph

1827 Commits

Author SHA1 Message Date
Peter Bhat Harkins 8fccc2079e set color for bots/people browsing as 2019-04-28 10:31:32 -05:00
Peter Bhat Harkins 410f95d91b traffic: always a little red in the logo 2019-04-28 10:11:30 -05:00
Peter Bhat Harkins 797ad4a946 document how to get dark mode 2019-04-28 07:34:42 -05:00
Peter Bhat Harkins 316d894e50 fix intensity color; ignore bots/feeds 2019-04-23 22:36:55 -05:00
Peter Bhat Harkins f39cf897ba improve hat instructions 2019-04-23 16:00:51 -05:00
Peter Bhat Harkins dfb4453275 replace traffic counting with measuring
No parameters that need tuning and a single select for most hits.
Logo intensity is based on traffic in the last 15m compared to the last 90
days, and that calculation is cached for 5m. Deliberately does not use
transactions: we don't need the correctness, and it's cheaper to overwrite
a couple times than lock Keystore. Addresses #536; will know in a week if it
closes.
2019-04-21 18:53:39 -05:00
Peter Bhat Harkins 4a86f6d8f2 Convert spec to track current behavior
It took 2.5 years to address this bug, I don't want to see this warning of a
pending test for the next 2.5. Speccing current behavior so future people have
context for the corner case.

Also fixes a style error as long as I'm committing.
2019-04-17 09:18:59 -05:00
Brian Kung bedb54b0fc Q-encode characters as multiple encoded words 2019-04-17 13:06:00 +00:00
Peter Bhat Harkins 1018422b56 Two more dead styles
Detected by @bovarysme in #640
2019-04-17 07:52:27 -05:00
Emma a909b13276 remove unused CSS rules
Close #640
2019-04-17 12:51:59 +00:00
Peter Bhat Harkins 2fe67dceb8 Merge in assets from lobsters-ansible repo 2019-04-17 07:33:43 -05:00
Peter Bhat Harkins 8c1b4a4092 plonk 2019-04-15 13:29:24 -05:00
Peter Bhat Harkins a7cc60b902 logging: match format for logged-out user, simpler grepping 2019-04-07 19:43:01 -05:00
Brian Kung d3c3c8ea22 Forces encoding to utf-8 when fetching url titles
Fix #648
2019-04-03 12:57:53 +00:00
Brian Kung aea35552f9 Fix modlog for tag creation 2019-04-03 12:44:50 +00:00
leobastiani 97ef5cfe89 remove .thread dead code 2019-04-03 12:28:08 +00:00
Michael Howell b2ae092d20 Add a title attribute to the upvote button 2019-04-03 12:18:33 +00:00
Peter Bhat Harkins 9711868670 prefetch js from login page
We only serve js to logged-in users, may as well hint the browser to prefetch
that just before it's used.
2019-03-20 20:45:41 -05:00
Peter Bhat Harkins 6a637b49fe don't message moderators about their own moderations/hat usage
Fix #429
2019-03-20 09:11:24 -05:00
Brian Kung efe3505811 Replace images in story description with text links
Fix #645
2019-03-20 08:04:26 -05:00
Olle Jonsson 41cb46a97e CI: Get Bundler first 2019-03-20 12:45:04 +00:00
Peter Bhat Harkins 356cd601c5 bump rails for vulns
https://weblog.rubyonrails.org/2019/3/13/Rails-4-2-5-1-5-1-6-2-have-been-released/
2019-03-13 12:53:56 -05:00
Peter Bhat Harkins 4e653a9896 show all suggested tags/titles, lift work from view to db
Also extracted tag_link helper to dedupe that snippet of repeated code.
2019-03-13 08:46:51 -05:00
Peter Bhat Harkins 0cea4d497c greppable logging for sockpuppeting
When I cleaned up a sockpuppeter a couple days ago I had to do some ridiculous
shell scripting to combine multiple lines by their request id to see/search
IP, method + URL, and username together. Now basic checks are trivial:

>   Request 127.0.0.1 GET /stories/uohnuj/upvote user: 123 totallynotpushcx
2019-03-08 17:24:50 -08:00
Brian Kung fdd85dbe3d Adds more macOS specific mysql2 instructions 2019-03-05 14:20:54 -08:00
Peter Bhat Harkins 2cde69aa7d no images in story text; leaks browsing data to submitter
mostly reverts b7e5447
2019-03-04 21:11:38 -08:00
Peter Bhat Harkins e84fc8c679 recognize /foo and /foo/index.html as dupes 2019-02-26 09:30:14 -06:00
Peter Bhat Harkins d2963d4b80 title mod pages 2019-02-19 18:34:58 -06:00
Edward Loveall 600fcb9108 Fix comment spec's order dependence 2019-02-17 10:55:29 -06:00
Peter Bhat Harkins 31a938e916 fix so adding tags creates modlog entries 2019-02-16 15:25:46 -06:00
Peter Bhat Harkins df1bfacab7 typo 2019-02-11 13:05:41 -06:00
Peter Bhat Harkins d566b83e14 include deleted stories in flagged view 2019-02-08 09:59:09 -06:00
Peter Bhat Harkins 0dbbbaa213 Fix account deletion form
Fixes #636
2019-02-06 11:33:46 -06:00
Peter Bhat Harkins 9169b04fb6 fix similar story display on submit form 2019-01-25 18:38:58 +05:30
Abdullah Samman 1b6a0de73d Fix comment editing
Fixes #624 
Closes #625
2019-01-16 09:40:44 -06:00
Chris Lloyd 0a484e38d1 Give seed admin enough activity to take all normal user actions 2019-01-16 08:14:01 -06:00
Nikhil Jha 9ed740767d Fake Data: Hats, Comments 2019-01-16 08:11:08 -06:00
Peter Bhat Harkins d9fc5356d6 don't search dupe urls 2019-01-16 07:35:52 -06:00
SvintBel 4841d38894 Fix form tag
Fixes #633
2019-01-16 07:35:28 -06:00
Colin Dean 11592ac0a6 Notes mysql2 gem installation workaround for macOS
There is apparently a bug in the `mysql_config` script included in `mysql-connector-c` that the mysql2 gem uses to build the native extensions. This theoretically would trip up anyone using macOS 10.12+ without having MySQL or MariaDB running locally.
2018-12-24 18:04:29 -06:00
Peter Bhat Harkins 3cc6ff7aee revert changes to comment box until I can sort out form errors 2018-12-24 09:38:39 -06:00
Hunter Madison 93440ce5bc Fix #622 by renaming the invitation_code hidden field 2018-12-23 11:06:44 -05:00
Peter Bhat Harkins b10d659de4 fix hidden_fields for form_with 2018-12-22 11:38:51 -06:00
Peter Bhat Harkins c6759f3780 meet the new cop, same as the old cop 2018-12-22 10:42:41 -06:00
Alan Post 01993d4ac5 roles/lobsters: typo in database anchor close tag.
This typo was introduced when the links were converted from
markdown to HTML.

Reported by /u/kqr.
2018-12-22 07:54:27 -07:00
Peter Bhat Harkins 0b578ac8ca rm old yarn binary 2018-12-11 06:51:10 -08:00
Abdullah Samman 17bdf34667 Make merged votes voteable
Fix #424
Fix #500
2018-12-09 09:58:38 -06:00
Peter Bhat Harkins ab5973f203 note about running ruumba 2018-12-09 07:53:47 -08:00
Abdullah Samman 089f3475ba Migrate deprecated form_tag and form_for to form_with
See next commit for note on running view style checks.
2018-12-09 09:51:30 -06:00
Abdullah Samman 8f46f991f3 Fix quoted-printable subject question-mark not being encoded
Fix #396
2018-12-05 09:11:09 -06:00