We haven't attempted to maintain support for it as we've increased our custom
SQL, and it's long been best practice in Rails to use the same database system
in dev as prod.
```
app/models/user.rb:22:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :invited_by_user,
^^^^^^^^^^
app/models/user.rb:26:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :banned_by_user,
^^^^^^^^^^
app/models/user.rb:30:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :disabled_invite_by_user,
^^^^^^^^^^
app/models/message.rb:10:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :hat,
^^^^^^^^^^
app/models/story.rb:3:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :merged_into_story,
^^^^^^^^^^
app/models/invitation.rb:3:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :new_user, class_name: 'User', inverse_of: nil, required: false
^^^^^^^^^^
app/models/comment.rb:9:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :parent_comment,
^^^^^^^^^^
app/models/comment.rb:17:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :hat,
^^^^^^^^^^
app/models/moderation.rb:2:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :moderator,
^^^^^^^^^^
app/models/moderation.rb:7:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :comment,
^^^^^^^^^^
app/models/moderation.rb:9:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :story,
^^^^^^^^^^
app/models/moderation.rb:11:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :tag,
^^^^^^^^^^
app/models/moderation.rb:13:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :user,
^^^^^^^^^^
app/models/vote.rb:2:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :user, required: false
^^^^^^^^^^
app/models/vote.rb:3:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :story, required: false
^^^^^^^^^^
app/models/vote.rb:4:3: C: Rails/BelongsTo: You specified required: false, in Rails > 5.0 the required option is deprecated and you want to use optional: true.
belongs_to :comment, required: false
^^^^^^^^^^
```
```
script/parse_inbound_mail:27:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
STDERR.puts "no active user with mailing list token #{parser.user_token}"
^^^^^^^^^^^
script/parse_inbound_mail:34:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
STDERR.puts "error parsing e-mail"
^^^^^^^^^^^
script/parse_inbound_mail:38:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
STDERR.puts "no valid comment or story being replied to"
^^^^^^^^^^^
script/parse_inbound_mail:42:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
STDERR.puts "no valid text/plain body found"
^^^^^^^^^^^
script/parse_inbound_mail:61:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
STDERR.puts c.errors.inspect
^^^^^^^^^^^
script/sync_twitter_users:29:3: C: Style/StderrPuts: Use warn instead of STDERR.puts to allow such output to be disabled.
STDERR.puts "need to implement paging for list members"
^^^^^^^^^^^
```
```
spec/controllers/tags_controller_spec.rb:31:8: C: Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash, unless items are split onto multiple lines.
}, }
^
```
```
Error: The `Layout/IndentHash` cop has been renamed to `Layout/IndentFirstHashElement`.
(obsolete configuration found in .rubocop.yml, please update it)
```
Using URI.parse with IDN/non-ASCII URLs won't work, and as far as I can
find there is no stdlib way of doing it. This regexp should be good enough
and not reject any valid URLs.
Closes#669
Francesco Turco
Peter Bhat Harkins
Peter Bhat Harkins
Jean-Baptiste Barth
Thomas Dziedzic
Gus Caplan
jordigh
Preston Mueller
Alexander Maslov
mukund
Casey R
Martin Tournoij
Alan Post
Abdallah Samman
Brian Kung
lvlts