tildeverse
/
tilde.news
mirror of https://github.com/tildeverse/lobsters
5
3
Fork 3
Code Issues 2 Releases Wiki Activity
1,686 Commits 3 Branches 0 Tags 6.6 MiB
Commit Graph

1686 Commits

Author SHA1 Message Date
Abdullah Samman 92a768e604 make `rails test` run `rails spec` instead 
Fix #585
 2018-11-26 18:42:01 -06:00
Peter Bhat Harkins 922ef94cb7 warn against style churn because folks aren't seeing #460 2018-11-26 18:12:40 -06:00
Peter Bhat Harkins 1e5a7fc81f whitespace; shallow name 2018-11-24 16:43:43 -06:00
SengMing Tan 0b6476e4ce add rubocop cop to prevent the safe navigation operator 
Close #596
 2018-11-24 16:41:09 -06:00
Peter Bhat Harkins 04753278b3 rubocop 2018-11-24 16:02:45 -06:00
Peter Bhat Harkins b23f106477 fix appearance of deleted comments on /comments and user thread pages 
Also fixes 1 + n queries on those pages.
 2018-11-24 09:20:01 -06:00
Peter Bhat Harkins 54abea7ed6 better wording 
https://lobste.rs/s/sfzmwr/proposal_set_everyone_s_invite_count_zero#c_np1ubv
 2018-11-22 23:50:59 -06:00
Peter Bhat Harkins 8554cef9ef Story#similar_stories should not include deleted stories 2018-11-22 08:48:04 -06:00
Peter Bhat Harkins 1c04acec58 fix #similar_stories to not include merged stories 2018-11-21 21:06:30 -06:00
Peter Bhat Harkins 0724c706fc name exceptions so we can ignore most of them 
Now that we've had this in prod a while I've collected a few transient DNS
issues. Because webmentions are a nice-to-have, we can just drop the mention
if someone's DNS is flaking on us. We let BadIPsError hit logs because it
might be someone attempting to use this to enumerate our internal network
(tho it's most likely misconfiguration).
 2018-11-20 08:18:10 -06:00
Peter Bhat Harkins 087df3bb6b bugfix empty string urls 
Empty string URLs (any story with text and no link) passed this nil check but
threw an exception out of extras/sponge when it tried to get the host.
 2018-11-20 08:07:12 -06:00
Peter Bhat Harkins bdb3098320 strip Facebook tracking param 
http://thisinterestsme.com/facebook-fbclid-parameter/
 2018-11-19 22:12:27 -06:00
Peter Bhat Harkins c1ef5b5b29 bundle update 2018-11-19 20:40:37 -06:00
Lucas Charles 8c0be535ea Add JSON MIME to StoriesController#check_url_dupe 
Used by http://discussitapp.com for indexing our pages.

Merge #594 
Close #555
 2018-11-19 20:39:28 -06:00
Peter Bhat Harkins bcaeb6839b fix 7498867 for s/duplicate/similar/ 2018-11-09 08:09:23 -06:00
Peter Bhat Harkins 849329b476 test password resetting 2018-11-08 11:28:15 -06:00
Peter Bhat Harkins 79b6a2b69c don't 500 if a user banned/deleted before server move tries to log in 
Also add a rake task documenting what jcs did before the server move.
(Though ModNote is new since then.)
 2018-11-08 10:56:20 -06:00
Peter Bhat Harkins 26a9cadc10 add specs for LoginController 2018-11-08 10:24:51 -06:00
Peter Bhat Harkins 20dfcb963d placeholder for rails test 
For #585
 2018-11-08 08:55:51 -06:00
Frederik b2527d03e3 Fix </a> 2018-11-08 08:30:05 -06:00
Peter Bhat Harkins 4870da7ec6 ok, it's come up at least four times now 2018-11-08 08:13:05 -06:00
Andreza Medeiros 7e056d07b8 Fix invalid URI on script/send_new_webmentions 
Fix #586
 2018-11-07 12:17:56 -06:00
Peter Bhat Harkins 7498867255 tweaks to display of similar stories 2018-11-07 11:49:33 -06:00
Brian Gerson 5eb0a40aee Surface duplicate stories on submission + display 2018-11-07 08:42:59 -06:00
Jason Schweier 18167b36a5 better handling of deleted stories + comments on user views 2018-11-07 08:28:50 -06:00
ur5us ff5b7373b5 Switch to database cleaner approach for cleaning up test data 
While the previous approach of hand-rolling test data cleanup + setup works
it’s prone to become insufficient with regards to future test scenarios. Recent
commits 6a6da094 and later 4620a9221 highlight the issue.

Using the database cleaner gem provides a cleaner (pun intended) approach to
setup a clean room environment before and after each specific test.

Annotating specs with with `:js` or `truncate` will switch from a transaction
based cleanup strategy to a truncation based one to enable feature/request specs
for which a web server is spun up in separate process by RSpec, in other words
the process executing the spec is not the same as the process handling the
request so RSpec/DatabaseCleaner wouldn’t know when to rollback the transaction.

The downside of this approach might be that RSpec takes a few more seconds to
run all specs.
 2018-11-07 07:45:02 -06:00
Alan Post d11da232a8 operational wording of error messages on HTTP error pages. 2018-11-07 07:42:45 -06:00
Peter Bhat Harkins 386a3452b9 bump dependencies for rack CVEs 
https://groups.google.com/forum/#!topic/rubyonrails-security/GKsAFT924Ag
https://groups.google.com/forum/#!topic/rubyonrails-security/U_x-YkfuVTg
 2018-11-05 17:15:31 -06:00
Peter Bhat Harkins bf3451a80f don't notify inactive users 2018-10-30 18:04:14 -05:00
Ben Sima 3803cf5680 Use code tags instead of backticks 2018-10-30 15:21:25 -05:00
ur5us f08243e90b Fix deprecation warnings for upcoming Rails 6 
DEPRECATION WARNING: Delegating exists to arel is deprecated and will be
removed in Rails 6.0. (called from block in <class:Story> at
./lobsters/app/models/story.rb:75)
 2018-10-20 19:02:11 -05:00
ur5us dfd35cd1fc Fix typo 2018-10-20 19:01:09 -05:00
Félix Baylac-Jacqué 0c5e22ba5c Fix story author microformat tag. 
The author entity was specified as a u-url instead of as a u-author.
 2018-10-20 08:04:32 -05:00
Peter Bhat Harkins ecefb37e8c rm medium tracking parameter 2018-10-18 14:15:34 -05:00
Peter Bhat Harkins 4620a9221b bump gems 
* Disabling a new linter that rubocop added
 * CommonMarker made SAFE the default
 * The FK support or the bump left some test data around between runs
 2018-10-18 08:25:06 -05:00
Juri Hahn 6a6da094d9 Fix failing test data cleanup due to foreign key constraint 
Before this change, running `Tag.destroy_all` would fail due to existing
`Moderation` records with a foreign key on some of those tags.
 2018-10-18 08:18:52 -05:00
Peter Bhat Harkins d07908176b update to current version of autosize.js 
For #559. Our version may be causing mobile scrolling to stutter as browser
chrome appears and disappears. This is an easy check.
 2018-10-17 13:32:17 -05:00
Michael Howell 42791e568e Add flag reason for bad links 2018-10-17 12:23:32 -05:00
Peter Bhat Harkins 864e853572 add good_migrations to catch model use 2018-10-17 11:20:28 -05:00
Guillermo Bonvehí b4d3775288 fix voting on newly-posted comments 
Bind click event to comments ol instead of existing elements so new
ajaxed-in comments can be voted on.

Fix #571
 2018-10-17 07:59:22 -05:00
Peter Bhat Harkins b4e18e08e6 only put wearable hats in dropdown 
https://www.youtube.com/watch?v=ducG55pfCMQ
 2018-10-13 17:10:25 -05:00
Peter Bhat Harkins 5f18cd222b It's now 'rails', not 'rake' 
Also has some wording updates as people have shown up in #lobsters confused
about running the dev mode in prod, etc.
 2018-10-11 13:31:54 -05:00
SengMing Tan 2234631f85 Add foreign keys 
What do we want?
Referential integrity!
When do we want it?
1992!
 2018-10-10 10:40:52 -05:00
SengMing Tan 7e43a0f599 Schema fix for unsigned bigints migration 
Something went wrong in 12644b27 that it didn't update schema.rb to reflect the column types.
 2018-10-10 08:26:47 -05:00
Guillermo Bonvehí d3753cfb1b Fix small markup error 2018-10-10 07:26:27 -05:00
Jason Schweier b43a5999b4 Fix Rubocop violation 2018-10-08 17:01:41 -05:00
Peter Bhat Harkins 5e6f1e6455 send webmentions 
Merge #535
 2018-10-03 10:16:50 -05:00
Peter Bhat Harkins 12644b2713 normalize ids as unsigned bigints 
PR #548 revealed a lot of FKs that didn't match the ID they pointed at. This
noramlizes all of them to unsigned bigints and adds several missing 'not null'
constraints.
 2018-09-28 22:07:46 -05:00
Christian Wesselhoeft 6e2fef88bf README.md: Remove secret_key_base instructions 
secret_key_base is set via secrets.yml in production
 2018-09-26 08:25:56 -05:00
Christian Wesselhoeft ebde57125d Remove redundant validations 
Became redundant after #508 switched on belongs_to_required_by_default
 2018-09-26 08:21:04 -05:00