Commit Graph

102 Commits

Author SHA1 Message Date
Paul Licameli 8a074770e8 IdentInterface::GetDescription() returns a translated string...
... See commit 3b90538b84 which removed the
only use of the untranslated strings.

Also follows better i18n guidelines for composing the VSTEffect description.
2018-01-07 21:16:26 -05:00
James Crook d2fe7b1757 Clean up most remaining MSVC warnings. 2018-01-06 13:03:48 +00:00
Paul Licameli 3fbfef0eb1 Plot Spectrum, Change Pitch localize pitch names; Unicode sharp/flat 2018-01-02 12:20:04 -05:00
Paul Licameli 80a958f8a4 Rewrite empty prompts to ShuttleGUI functions as {} ...
... so we might more easily redefine the type of the function argument,
some other day (not this release)
2018-01-01 22:51:25 -05:00
Paul Licameli 7fd78183d2 Remove needless uses of wxString::c_str() in wxString::Format...
... and similar wx "variadics," which all treat wxString smartly enough that
you don't need this.

Don't need c_str either to convert wxString to const wxChar * because
wxString has a conversion operator that does the same.
2018-01-01 20:34:33 -05:00
Paul Licameli d3b1ae512b Effect param keys don't need to localize; audacity.pot can shrink...
... The keys are only ever used as internal identifiers in wxConfigFile
objects.  So they are often space-less and camel-cased.

I have noticed a couple instances of translators confused by these.
2017-11-05 11:48:15 -05:00
Steve Daulton e7a9c37745 Add help buttons for normal built-in effects 2017-05-20 14:49:07 +01:00
Paul Licameli 6ca89c28ff Remove naked new[] in: builtin effects 2017-03-17 17:52:49 -04:00
Paul Licameli 08b99c533b Remove Effect::mWarper, and stack-allocate warpers instead 2017-03-17 17:52:32 -04:00
Paul Licameli 004df48438 Make Effect::mTracks private 2017-03-17 17:52:25 -04:00
Paul Licameli ed21545c80 pixel column counts and sample window sizes use unsigned types 2016-09-11 20:28:13 -04:00
Paul Licameli 79c79f9cd3 Remove many mentions of sampleCount with auto and decltype...
... This makes much code agnostic about how other things (functions and
arguments) are typed.

Many of these neeed to become size_t instead of sampleCount.
2016-08-24 14:50:45 -04:00
Steve Daulton 7b14e68b37 Pass name of proxy effect to EffectSBSMS
Allows progress bar to show meaningful title when using SBSMS
time stretching in Change Pitch/Tempo.
2016-08-16 14:54:34 +01:00
Steve Daulton 90e400b0a7 Add SBSMS option to Change Pitch effect 2016-08-13 17:28:49 +01:00
Paul Licameli 6fec00149b Remove some naked new amd delete in: Built-in Effects 2016-08-08 07:51:25 -04:00
Taiki Kim 5421cf487a Correctly load parameters for Change Pitch effect
Partial fix for Bug 73.
Partial fix for Bug 1207.
2016-06-20 15:49:50 -07:00
Paul Licameli e70f91c64e Removed ShuttleGui.h from other headers 2015-07-19 12:31:03 -04:00
Steve Daulton d9f3c432d4 Fix for bugs 943, 942, 941, 843 and 775.
Non-linear effects now process tracks before mixing.
This will be slower when multiple tracks are selected
but the preview should now match the applied effect.
SetLinearEffectFlag(true) allows linear effects to
preview more quickly when multiple tracks selected, by
pre-mixing selected tracks.
Simple generators like Tone and Noise may be marked as
'linear' so that they only preview a few seconds.
Generators that vary over time (such as Chirp) must use
the full duration that is set. As this currently
requires calculating the full duration, preview for
'non-linear' generators are not limited to the preview
length.
2015-05-15 12:51:51 +01:00
Leland Lucius 27657ddea7 Restore non-preset values when Factory Preset -> Defaults is selected 2015-04-27 10:52:42 -05:00
Leland Lucius f3f7dca595 Further fixes based on Peter's feedback. 2015-04-25 11:23:00 -05:00
Leland Lucius 7f0c91bdfd Fix ChangePitch based on Peter's feedback 2015-04-22 13:05:04 -05:00
Leland Lucius 7a0aa43a82 Convert all wxTRANSLATE() to XO()
XO() can be used anywhere a string must be extracted for translation
but not automatically translated at runtime.
2015-04-18 23:03:49 -05:00
Leland Lucius 8fbfa460c4 Migrating the remaining effects
This brings the builtin, LV2, and VAMP effects inline with the
Audio Units, LADSPA, and VST effects.  All effects now share
a common UI.

This gives all effects (though not implemented for all):

User and factory preset capability
Preset import/export capability
Shared or private configuration options

Builtin effects can now be migrated to RTP, depending on algorithm.
LV2 effects now support graphical interfaces if the plugin supplies one.
Nyquist prompt enhanced to provide some features of the Nyquist Workbench.

It may not look like it, but this was a LOT of work, so trust me, there
WILL be problems and everything effect related should be suspect.  Keep
a sharp eye (or two) open.
2015-04-16 23:36:28 -05:00
benjamin.drung@gmail.com 277932dccb Remove trailing spaces. 2014-06-03 20:30:19 +00:00
v.audacity 18e45e1e58 Make some strings translatable, per Steve's 'Untranslated labels in effects' post on -quality. 2013-12-14 02:07:06 +00:00
richardash1981 62986f3b85 Free the buffer allocated at the start of the method, bug reported by Andrew Hallendorff 2013-10-27 20:49:58 +00:00
v.audacity 1f79c6ad0a changes per "[Audacity-devel] Change pitch dialog and Jaws" thread 2013-08-25 05:20:30 +00:00
v.audacity 8867d65df8 Fix typo in SetName() call. 2013-08-18 00:50:21 +00:00
v.audacity 51e0391b7d Campbell Barton's patch for mem leaks, http://www.graphicall.org/ftp/ideasman42/audacity_mem_leak_fix_r12450.diff 2013-08-03 00:24:26 +00:00
v.audacity 08dd4d9813 Safeguard against ChangePitchDialog::OnText_ToFrequency() from allowing OK or Preview if percent change is out of bounds.
Consolidate multiple #defines for Percent Change controls. 

Update copyright year.
2013-06-25 23:43:55 +00:00
v.audacity 3f6856e07a Simplify Leveller dialog. 2013-06-22 00:49:13 +00:00
v.audacity 298f0688cb Doh! .c_str() 2013-06-21 22:09:20 +00:00
v.audacity d8a9d774fe Fixed some missed cross-updating of octave controls. 2013-06-20 03:53:57 +00:00
v.audacity 0716c1f62b Add static text about "Estimated Start Pitch" per -quality discussion.
Fixed some weird layout issues due to ShuttleGui misuse. 

Fixed some SetName cut/paste errors (e.g., it used to say "To frequency in seconds" !). 

Fixed rounding direction in PitchOctave() for negative MIDI notes. 

Fixed a comment in ShuttleGui.cpp.
2013-06-20 02:28:55 +00:00
v.audacity ce8f6b09da Substantial code simplification and clarification, but should be no functional changes. The Effect does not need to store all the param values the dialog provides. 2013-06-19 02:25:21 +00:00
v.audacity b327e510b0 Improvements in Change Pitch effect.
* from and to octave spin controls and cross-updating

* new conversion utilities in PitchName.*

* code simplification, new documentation

* stop a few compiler warnings in FreqWindow.cpp on unused params
2013-06-18 04:35:35 +00:00
v.audacity 820b889475 bug 309: Get rid of incremental fix now that correct fix is in PitchIndex(). 2013-06-15 00:28:04 +00:00
v.audacity c39f9a4b53 further constraints regarding bug 309, from off-list discussion with Steve 2013-05-30 23:30:09 +00:00
v.audacity 16e1958501 incremental changes related to bug 309 based on Steve's off-list patch 2013-05-28 01:50:59 +00:00
v.audacity 9d8bdb1cca Steve pointed out to me that wx>TextCtrl Percent Change of -99.7 or lower causes crash in SoundTouch code, and anything below -99.0 is probably garbage, so I changed the bounds check to -99% (which matches the slider, too). 2013-05-23 00:42:21 +00:00
v.audacity 3f2c9d0c1d further constraints regarding bug 309, from off-list discussion with Steve 2013-05-22 04:32:43 +00:00
v.audacity 588d2976b0 further constraints, against negative pasted frequencies that wxValidator doesn't prevent 2013-05-21 02:35:29 +00:00
v.audacity 1589720d93 modified version of Steve's patch for bug 638 2013-05-21 01:58:11 +00:00
richardash1981 5c61ffc4a7 add missing include as per Benjamin Drung and Michael Chinen 2013-05-18 14:23:26 +00:00
v.audacity 16637e1268 bug 309, comment 14 2013-05-18 00:09:43 +00:00
v.audacity 4134d73125 Fix rounding error in ChangePitchDialog::Calc_ToPitchIndex(). 2013-05-14 02:49:56 +00:00
v.audacity a7d0ddc49a incremental layout updates based on Steve's mock-up 2013-05-13 01:22:14 +00:00
v.audacity 2c827c163e In effort on bug 253:
Get rid of Pitch Up/Down radio buttons. 

Change Semitones validator back to allow negative entries. 

Make "From:" and "To:" for Pitch be consistent with formatting for Frequency. 

Make the pitch wxChoice narrower. It's at most only 5 characters. 

Remove empty comments. Cruft.
2013-05-13 00:07:01 +00:00
v.audacity 1d6a5aaefa local fix for bug 253, plus prevents user entering negative values for From or To frequencies 2013-05-12 01:06:09 +00:00
james.k.crook@gmail.com 63f0b8b09e Fixed more internationalisation hints. 2012-03-20 16:17:37 +00:00
rbdannenberg f274c9fb2b Extended pitch, tempo, and speed effects to operate on NoteTracks. Fixed off-by-one error on channel buttons. 2010-10-28 17:57:14 +00:00
ra e74978ba77 Locate and position the current Audacity source code, and clear a variety of old junk out of the way into junk-branches 2010-01-23 19:44:49 +00:00