Paul Licameli
58574f2f78
Redo type HFFT as a smart pointer, remove malloc and free
2017-03-17 17:52:51 -04:00
Paul Licameli
6ca89c28ff
Remove naked new[] in: builtin effects
2017-03-17 17:52:49 -04:00
Paul Licameli
0af9b46eac
Move many fields out of Envelope that are needed only during editing
2017-03-17 17:52:31 -04:00
Paul Licameli
004df48438
Make Effect::mTracks private
2017-03-17 17:52:25 -04:00
Paul Licameli
81285ee0c1
More const and override
2017-03-17 17:52:20 -04:00
Steve Daulton
7517b2653e
Set minimum size of EditCurvesDialog (bug 470)
2017-02-24 18:52:25 +00:00
James Crook
53c3adfbe7
Bug 1577 - Application configuration file location incorrect on Linux/case-sensitive Macs
...
On windows the capitalisation does not matter.
On Mac/Windows we use 'audacity' in path names, even if the directories wxWidgets suggests have 'Audacity'.
2017-01-25 22:15:03 +00:00
David Bailes
6261bb5a9a
Equalization effect: revert one of the changes in commit fcb6221
...
Revert change in commit fcb6221
which affected behaviour in draw mode.
2016-09-26 09:03:54 +01:00
David Bailes
fcb6221b2c
Fix for bug #1517 - Equalization sliders bug
...
The bug was that when the Equalization effect opens in Graphics mode, the sliders are set to zero, and don't do the right thing. This was caused by my incorrect fix for bug #1346 .
Fix is to call UpdateGraphic to set the sliders up. Call to UpdateDraw also added, which includes the appropriate calls to Show, rather than have these in PopulateOrExchange.
2016-09-24 09:26:46 +01:00
David Bailes
3bb2a8b170
Fix for bug #1346 - Equalization effect always opens in draw mode
2016-09-23 13:53:47 +01:00
Paul Licameli
78be459fa1
Convert sampleCount <-> floating or -> long long explicitly ...
...
... A non-narrowing conversion out to long long is a necessity, but the
conversions to float and double are simply conveniences.
Conversion from floating is explicit, to avoid unintended consequences with
arithmetic operators, when later sampleCount ceases to be an alias for an
integral type.
Some conversions are not made explicit, where I expect to change the type of
the variable later to have mere size_t width.
2016-09-15 21:02:31 -04:00
Paul Licameli
ed21545c80
pixel column counts and sample window sizes use unsigned types
2016-09-11 20:28:13 -04:00
Paul Licameli
919d77d176
More uses of min and max
2016-09-06 20:46:25 -04:00
Paul Licameli
3b04bb1726
More uses of limitSampleBufferSize
2016-08-27 07:54:22 -04:00
Paul Licameli
52417c444d
Remove unnecessary casts to sampleCount
2016-08-24 14:50:46 -04:00
Paul Licameli
79c79f9cd3
Remove many mentions of sampleCount with auto and decltype...
...
... This makes much code agnostic about how other things (functions and
arguments) are typed.
Many of these neeed to become size_t instead of sampleCount.
2016-08-24 14:50:45 -04:00
Paul Licameli
39df8d0b51
Don't use conversion of sampleCount to bool
2016-08-22 21:45:54 -04:00
Paul Licameli
e599cfa6fa
Effect::mOutputTracks is managed by smart pointer
2016-08-13 10:37:51 -04:00
Paul Licameli
b548e641ae
Simplify iterations over WaveClips outside of WaveTrack/WaveClip; ...
...
... also add some const qualifiers
2016-08-12 20:53:37 -04:00
Paul Licameli
a52f7f8410
new -> NEW in comments, so text search for naked new excludes them
2016-08-08 10:07:37 -04:00
Paul Licameli
6fec00149b
Remove some naked new amd delete in: Built-in Effects
2016-08-08 07:51:25 -04:00
James Crook
163063f516
Merge pull request #143 from RaphaelMarinier/remove-old-fft2
...
Code cleanup: removed the old real FFT code not used for a long time
2016-07-13 18:32:42 +01:00
Paul Licameli
84c0337aba
Fix TAB key navigation on Mac for all dialogs (not only for panels)
2016-07-10 17:12:27 -04:00
Paul Licameli
4739f3e27b
Compensate for wxW 3 tab navigation deficiencies on Mac...
...
... using char hook event handlers. We don't need to go the extreme length
of patching wxWidgets source.
2016-06-25 19:14:05 -04:00
Raphaël Marinier
6ac68db5be
Code cleanup: removed the old real FFT code not used since at least 2009.
...
I confirmed that the currently used real FFT code in RealFFTf.cpp is faster
than the old one with a quick benchmark that calls PowerSpectrum() on 4-minute
audio file, with different sizes of computation windows:
Window_size: 256 method: new FFT time_s: 0.393
Window_size: 256 method: old FFT time_s: 1.065
Window_size: 1024 method: new FFT time_s: 0.38
Window_size: 1024 method: old FFT time_s: 0.958
Window_size: 4096 method: new FFT time_s: 0.413
Window_size: 4096 method: old FFT time_s: 1.084
Window_size: 16384 method: new FFT time_s: 0.518
Window_size: 16384 method: old FFT time_s: 1.338
Window_size: 65536 method: new FFT time_s: 0.655
Window_size: 65536 method: old FFT time_s: 1.524
Window_size: 262144 method: new FFT time_s: 0.735
Window_size: 262144 method: old FFT time_s: 1.873
2016-06-25 20:40:16 +02:00
Paul Licameli
ad711e783b
Bug470: Disable some Manage Curves buttons when no curve selected
2016-06-22 19:10:36 -04:00
Paul Licameli
db137ddf76
wxWindow takes ownership of its wxAccessible, so we can use safenew.
2016-05-06 21:03:37 -04:00
Paul Licameli
1bdd1a07ab
Similarly for Equalization: avoid assertion in debug build, if you ESC...
...
... while dragging a point in "Draw Curves".
2016-04-25 01:04:38 -04:00
Paul Licameli
2d7e21536e
Sweep for filename copying: prefs and effects
2016-04-10 22:25:49 -04:00
Paul Licameli
3ced1503ee
Make EXPERIMENTAL_EQ_SSE_THREADED compilable, at least on Windows.
2016-04-03 11:37:18 -04:00
Paul Licameli
3015a9c8d9
Track cut and copy functions return a unique_ptr argument...
...
... Because they are factory functions.
2016-03-26 11:50:13 -04:00
Paul Licameli
5ef4dd46a5
TrackFactory functions return std::unique_ptr, although some callers...
...
... release() them for now.
2016-03-26 11:50:12 -04:00
Steve Daulton
3cab059038
Tweak EQDefaultCurve update path
...
and add log message to aid testing.
2016-03-21 11:59:41 +00:00
Steve Daulton
7d5e54e364
Fix some assert error in EQ curves
...
Selected EQ curves in Draw mode should now retain their name
when they are selected.
2016-03-08 21:55:07 +00:00
Steve Daulton
4173bb1a37
Fix error in string comparison
2016-02-29 13:26:38 +00:00
Steve Daulton
36f3f8aab2
Update Eq factory presets on upgrade
...
Add search paths for EQDefaultCurves.xml
2016-02-27 21:20:53 +00:00
Steve Daulton
b5d2528c03
Enable Eq factory presets to be updated on upgrade
2016-02-27 13:17:27 +00:00
Paul Licameli
60bcd7aea2
Fix warnings for unused variables and functions
2016-02-26 14:56:26 -05:00
Paul Licameli
99f161c36c
Sweep unnecessary wxString copies: effects
2016-02-22 22:31:47 -05:00
Paul Licameli
dbaa811577
Stack-allocate where possible! ...
...
... Removed many unnecessary naked news and deletes.
2016-02-17 18:15:57 -05:00
Paul Licameli
df6a7c5464
More uses of safenew for classes we derive from wxWindow classes...
...
... Also removed some unnecessary deletes of widgets that are managed by parent
windows
2016-02-14 20:39:28 -05:00
Paul Licameli
3f237daddc
Use macro safenew for many allocations of wxWindow subclasses
2016-02-14 20:20:19 -05:00
Paul Licameli
6052b5f9be
Throw by value, catch by reference: don't use pointers...
...
... that's what the better books on C++ recommend.
2016-02-14 19:36:17 -05:00
Paul Licameli
7c4c45a0d5
"new"->"NEW" in comments, easier to find remaining naked operator new
2016-02-14 18:52:41 -05:00
Paul Licameli
56e7653343
"delete"->"DELETE" in comments, easier to find remaining naked operator delete
2016-02-14 18:50:45 -05:00
Leland Lucius
76436fc3fd
Don't display message if the EQ curves file is missing.
...
I can't think of a reason for having the message. Either the curves
are there or they are not.
2015-12-21 23:38:05 -06:00
Leland Lucius
2a234d86f8
"Should" fix the remaining issue in bug #1081
2015-08-27 10:16:28 -05:00
Leland Lucius
e15236efdc
Fix the assertion mentioned in bug #1081
2015-08-27 09:38:09 -05:00
Paul Licameli
1b8f44d053
ViewInfo does not redundantly (or inconsistently!) store the screen width
2015-08-21 22:39:18 -04:00
Leland Lucius
5a9025b558
Hopefully this'll fix the assertions
2015-08-16 15:04:24 -05:00