URL should display absolute path for relative links #149

New Issue

sloum · 2020-05-18T05:48:19Z

sloum commented

2020-05-18 05:48:19 +00:00

Reported via email by makeworld:

In the header area at the top of the client, where the URL bar is,
relative URLs aren't fixed, they're just added on to the end.
So if I'm on gemini://example.com/dir/test.gmi and then I click a link
that is relative, like ../test2.gmi, the header shows:

gemini://example.com/dir/test.gmi/../test2.gmi

The page itself loads fine, but this is confusing in the header. A
minor bug though for sure.

I agree that this is minor, but it should definitely be on our rader to fix at some point in the not distant future. The fact that the navigation still works reduces the urgency a slight bit though (at least if there are broken bits that need fixing first).

Reported via email by makeworld: > In the header area at the top of the client, where the URL bar is, > relative URLs aren't fixed, they're just added on to the end. > So if I'm on `gemini://example.com/dir/test.gmi` and then I click a link > that is relative, like `../test2.gmi`, the header shows: > > `gemini://example.com/dir/test.gmi/../test2.gmi` > > The page itself loads fine, but this is confusing in the header. A > minor bug though for sure. I agree that this is minor, but it should definitely be on our rader to fix at some point in the not distant future. The fact that the navigation still works reduces the urgency a slight bit though (at least if there are broken bits that need fixing first).

sloum added the

bug

non-urgent

labels 2020-05-18 05:48:19 +00:00

sloum referenced this issue

2020-05-19 03:12:25 +00:00

Reworks how relative URLs are handled for gemini #152

sloum referenced this issue

2020-05-19 03:13:22 +00:00

Reworks how relative URLs are handled for gemini #153

sloum commented

2020-05-19 03:18:48 +00:00

I have built this out sooner than I had expected to (and snuck in another pathing issue for gemini where a redirect would happen just to add a trailing slash on a directory).

It can be found in a PR here: #153

I will close this when/if that gets accepted and merged in.

I have built this out sooner than I had expected to (and snuck in another pathing issue for gemini where a redirect would happen just to add a trailing slash on a directory). It can be found in a PR here: #153 I will close this when/if that gets accepted and merged in.

sloum added the

in progress

label 2020-05-22 16:26:10 +00:00

sloum commented

2020-05-24 18:26:21 +00:00

Closing. This has been worked into version 2.3.0 and merged in by #160

Closing. This has been worked into version `2.3.0` and merged in by #160

sloum closed this issue

2020-05-24 18:26:27 +00:00

sloum removed the

in progress

label 2020-05-24 18:26:37 +00:00