solene
/
openbsd-webzine
6
0
Fork 8
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

HTML semantic! #14

New Issue
Closed
opened 2021-10-02 09:55:29 +00:00 by hucste · 14 comments
hucste commented 2021-10-02 09:55:29 +00:00
Contributor
Copy Link

Hi.

Your HTML code seems not semantic; and many bloc div not needed!

Hi. Your HTML code seems not semantic; and many bloc div not needed!
solene commented 2021-10-02 10:00:58 +00:00
Owner
Copy Link

Hello,
Could you give hints about where you think the semantic is wrong?

Hello, Could you give hints about where you think the semantic is wrong?
hucste commented 2021-10-02 10:10:11 +00:00
Author
Contributor
Copy Link

I prepare a PR ;-)

I prepare a PR ;-)
solene commented 2021-10-02 10:15:19 +00:00
Owner
Copy Link

Before doing so don't forget to git pull -r to have latest revision locally.

Before doing so don't forget to `git pull -r` to have latest revision locally.
pmjv commented 2021-10-02 10:16:19 +00:00
Contributor
Copy Link

There's a <p> inside a <p> where the art is. That's probably illegal. line 192-194 in issue-1.

There's a `<p>` inside a `<p>` where the art is. That's probably illegal. line 192-194 in issue-1.
solene commented 2021-10-02 17:37:57 +00:00
Owner
Copy Link

I didn't know it wasn't allowed to nest <p> tags, that explains the issue reported on the w3c validator about this.

I didn't know it wasn't allowed to nest `<p>` tags, that explains the issue reported on the w3c validator about this.
hucste commented 2021-10-02 18:31:25 +00:00
Author
Contributor
Copy Link

element p into element p is not allowed!
See the HTML code about artworks on issue 1 ;-)
Boo.

element p into element p is not allowed! See the HTML code about artworks on issue 1 ;-) Boo.
solene commented 2021-10-02 18:50:47 +00:00
Owner
Copy Link

element p into element p is not allowed!
See the HTML code about artworks on issue 1 ;-)
Boo.

wow, what an useful childish comment

> element p into element p is not allowed! > See the HTML code about artworks on issue 1 ;-) > Boo. wow, what an useful childish comment
👎 1 ❤️ 1
hucste commented 2021-10-02 19:34:28 +00:00
Author
Contributor
Copy Link

solene: wow, what a useless comment!

Clairement, tu ne m'as pas compris.

Regarde donc le fichier artwork de l'issue 1, tu verras qu'il y a un element p imbriqué dans un autre !

Là, ce n'est même pas un problème de sémantique HTML, mais de base du code HTML.
Rien à faire ici, et dans ce contexte.

solene: wow, what a useless comment! ---- Clairement, tu ne m'as pas compris. Regarde donc le fichier artwork de l'issue 1, tu verras qu'il y a un element p imbriqué dans un autre ! Là, ce n'est même pas un problème de sémantique HTML, mais de base du code HTML. Rien à faire ici, et dans ce contexte.
hucste reopened this issue 2021-10-02 19:42:53 +00:00
solene commented 2021-10-02 20:12:54 +00:00
Owner
Copy Link

solene: wow, what a useless comment!

Clairement, tu ne m'as pas compris.

Regarde donc le fichier artwork de l'issue 1, tu verras qu'il y a un element p imbriqué dans un autre !

Là, ce n'est même pas un problème de sémantique HTML, mais de base du code HTML.
Rien à faire ici, et dans ce contexte.

c'est le problème remonté par le w3c validator mentionné juste au-dessus #14 (comment)

> solene: wow, what a useless comment! > > ---- > > Clairement, tu ne m'as pas compris. > > Regarde donc le fichier artwork de l'issue 1, tu verras qu'il y a un element p imbriqué dans un autre ! > > Là, ce n'est même pas un problème de sémantique HTML, mais de base du code HTML. > Rien à faire ici, et dans ce contexte. c'est le problème remonté par le w3c validator mentionné juste au-dessus https://tildegit.org/solene/openbsd-webzine/issues/14#issuecomment-7799
hucste commented 2021-10-02 20:14:41 +00:00
Author
Contributor
Copy Link

c'est le problème remonté par le w3c validator mentionné juste au-dessus #14 (comment)

ça, j'ai personnellement compris !
Et, j'ai fais une réponse adéquate.

je vais t'envoyer un PR pour corriger ce fichu fichier.
(comme ça, on n'en parle plus - basta)

Voilà #21 si je ne me suis pas trompé quelque part ;-)

> c'est le problème remonté par le w3c validator mentionné juste au-dessus https://tildegit.org/solene/openbsd-webzine/issues/14#issuecomment-7799 ça, j'ai personnellement compris ! Et, j'ai fais une réponse adéquate. je vais t'envoyer un PR pour corriger ce fichu fichier. *(comme ça, on n'en parle plus - basta)* Voilà #21 si je ne me suis pas trompé quelque part ;-)
solene commented 2021-10-03 14:34:53 +00:00
Owner
Copy Link

Can I close this now? I think we merged all relative changes.

Can I close this now? I think we merged all relative changes.
hucste commented 2021-10-03 14:39:39 +00:00
Author
Contributor
Copy Link

yes, only if you does not want me to change the code of both index and issue1 files.
I think, it's necessary to change them… but I cant act now, perhaps in the evening, or tomorrow. ;-)

yes, only if you does not want me to change the code of both index and issue1 files. I think, it's necessary to change them… but I cant act now, perhaps in the evening, or tomorrow. ;-)
solene commented 2021-10-03 14:43:35 +00:00
Owner
Copy Link

Many changes have been done today, what kind of changes do you want to do?

Good news, with today efforts, the pages are now valid at the w3c validator.

Many changes have been done today, what **kind** of changes do you want to do? Good news, with today efforts, the pages are now valid at the w3c validator.
👍 1
hucste commented 2021-10-04 12:02:10 +00:00
Author
Contributor
Copy Link

See PR #28, #29!

See PR #28, #29!
hucste reopened this issue 2021-10-05 12:33:11 +00:00
solene referenced this issue from a commit 2023-09-13 08:51:34 +00:00
issue #14 is almost done
solene referenced this issue from a commit 2023-09-13 08:51:34 +00:00
shell tip #14
solene referenced this issue from a commit 2023-09-13 09:56:20 +00:00
fix publish date for #14
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
11-fr
enable_ci
fix_feed_summary
contributors_auto
title_legibility
production
headlines
fix_tabs
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
Easy

This is easy to do

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
Easy
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: solene/openbsd-webzine#14
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?