solene
/
openbsd-webzine
6
0
Fork 8
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

Added opengraph tags to header #9

Merged
solene merged 3 commits from :add_opengraph into main 2021-10-01 21:18:43 +00:00
Conversation 3 Commits 3 Files Changed 1 +5
pmjv commented 2021-10-01 19:23:04 +00:00
Contributor
Copy Link
No description provided.
pmjv added 2 commits 2021-10-01 19:23:04 +00:00
456539c318 Added og: title, description, url, type, locale 
left out <meta property="og:image" content="/PATH-TO-IMAGE" />
since we there is no "logo" image for the zine yet
pmjv added 1 commit 2021-10-01 19:29:01 +00:00
pmjv commented 2021-10-01 19:41:00 +00:00
Author
Contributor
Copy Link

If we are to use og:image tag, there needs to be a "mascot" image for the webzine

If we are to use og:image tag, there needs to be a "mascot" image for the webzine
solene commented 2021-10-01 21:18:39 +00:00
Owner
Copy Link

The code looks good. Indeed we need a mascot. I think I'll ask an artist to make one.

The code looks good. Indeed we need a mascot. I think I'll ask an artist to make one.
solene merged commit 0127829df8 into main 2021-10-01 21:18:43 +00:00
solene commented 2021-10-01 21:28:14 +00:00
Owner
Copy Link

I made some changes afterward to handle correctly the case of the index.html file in revision 6e2dd69679

I made some changes afterward to handle correctly the case of the index.html file in revision 6e2dd696797482b3dbbadb6822dbd2f001ce719b
pmjv deleted branch add_opengraph 2021-10-02 08:59:31 +00:00
solene referenced this issue from a commit 2022-04-21 21:05:59 +00:00
link russian #9
solene referenced this issue from a commit 2022-04-27 12:58:06 +00:00
Add FR Issue #9 Translation
solene referenced this issue from a commit 2022-04-27 18:57:27 +00:00
Fix typo on FR issue #9
solene referenced this issue from a commit 2022-04-29 18:40:46 +00:00
index: add czech page for #9
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
Easy

This is easy to do

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
Easy
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: solene/openbsd-webzine#9
No description provided.
Delete Branch ":add_opengraph"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?